SA-MP Forums Archive
HEADSHOT script won't work - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: HEADSHOT script won't work (/showthread.php?tid=567430)


HEADSHOT script won't work - Fantje - 13.03.2015

Hiye guys,

I have a script that works in another gamemode but not in the one I use now:

PHP код:
public OnPlayerTakeDamage ( playerid, issuerid, Float:amount, weaponid, bodypart ) {
    if(issuerid != INVALID_PLAYER_ID && weaponid == 34, 33 && bodypart == 9)
{
SetPlayerHealth(playerid, 0.0);
GameTextForPlayer(issuerid,"~g~HEADSHOT",2000,3);
GameTextForPlayer(playerid,"~r~HEAD~y~SHOT",2000,3);
}
    return 1;
} 
What's wrong?

Re: HEADSHOT script won't work - CalvinC - 13.03.2015

pawn Код:
weaponid == 34, 33
Shouldn't this be
pawn Код:
weaponid == 34 || weaponid == 33


Re: HEADSHOT script won't work - Fantje - 13.03.2015

Quote:
Originally Posted by CalvinC
Посмотреть сообщение
pawn Код:
weaponid == 34, 33
Shouldn't this be
pawn Код:
weaponid == 34 || weaponid == 33
Don't works.

Script:

PHP код:
new bodypart;
 // I don't believe that's the sound ID for the sound you're looking for.
        PlayerPlaySound(playerid, 17802, 0.0, 0.0, 0.0);
        PlayerPlaySound(issuerid, 17802, 0.0, 0.0, 0.0);
    if(gTeam[issuerid] == gTeam[playerid])
    {
           GameTextForPlayer(issuerid,"~r~Don't attack your team mates!", 3000, 3);
    }
    if(issuerid != INVALID_PLAYER_ID)
    {
          new str[26];
          format(str, sizeof(str),"-%.0f", amount);
          SetPlayerChatBubble(playerid, str, 0xFF0000FF, 100.0, 2000);
          PlayerPlaySound(issuerid,17802,0.0,0.0,0.0);
    }
    if(PlayerInfo[playerid][OnDuty] == 1 || PlayerInfo[playerid][God] == 1)
    {
        SetPlayerHealth(playerid, 1000.0);
        GameTextForPlayer(issuerid,"~r~Don't attack admins on-duty!", 3000, 3);}
        if(issuerid != INVALID_PLAYER_ID && weaponid == 34 || weaponid == 33 && bodypart == 9)
{
SetPlayerHealth(playerid, 0.0);
GameTextForPlayer(issuerid,"~g~HEADSHOT",2000,3);
GameTextForPlayer(playerid,"~r~HEAD~y~SHOT",2000,3);
}
    return 1;
} 


Respuesta: HEADSHOT script won't work - JuanStone - 13.03.2015

why do you add a variable called "bodypart" ?.

the "headshot" worked in version 0.3z ? This parameter was added in version 0.3z if you use earlier versions do not will function"bodypart".

Re: HEADSHOT script won't work - Fantje - 13.03.2015

The variable needs, or it gives undefined symbol. This is newest version

Re: HEADSHOT script won't work - Vince - 13.03.2015

If unsure about the order of operators, use brackets. That condition is most probably interpreted as:

pawn Код:
if((issuerid != INVALID_PLAYER_ID && weaponid == 34) || (weaponid == 33 && bodypart == 9))
Which means that this condition will be true if:
- the issuer is valid and uses weapon 34
OR
- the issuer uses weapon 33 to hit bodypart 9.

What you want is probably this:
pawn Код:
if(issuerid != INVALID_PLAYER_ID && (weaponid == 34 || weaponid == 33) && bodypart == 9)
Also got to love those "don't works" posts, without any explanation as to what exactly doesn't work.

Re: HEADSHOT script won't work - Mijata - 13.03.2015

use it is only for sniper and rep me if i help you

Код:
public OnPlayerTakeDamage(playerid, issuerid, Float: amount, weaponid,bodypart)
{
    if(issuerid != INVALID_PLAYER_ID)
    {
 if(GetPlayerTeam(issuerid) != GetPlayerTeam(playerid))
 {
                if((weaponid == 34) && bodypart == 9)
                {
                    SetPlayerHealth(playerid, 0.0);
                    GameTextForPlayer(issuerid, "~r~Head shot!", 3000, 3);
                    GameTextForPlayer(playerid, "~r~Head shot!", 3000, 3);
                }
    else return PlayerPlaySound(issuerid,17802,0.0,0.0,0.0);
 }else {GameTextForPlayer(issuerid, "~w~don't shoot team mates", 3000, 3);}
 }
   return 0;
}


Re: HEADSHOT script won't work - Fantje - 14.03.2015

Quote:
Originally Posted by Mijata
Посмотреть сообщение
use it is only for sniper and rep me if i help you

Код:
public OnPlayerTakeDamage(playerid, issuerid, Float: amount, weaponid,bodypart)
{
    if(issuerid != INVALID_PLAYER_ID)
    {
 if(GetPlayerTeam(issuerid) != GetPlayerTeam(playerid))
 {
                if((weaponid == 34) && bodypart == 9)
                {
                    SetPlayerHealth(playerid, 0.0);
                    GameTextForPlayer(issuerid, "~r~Head shot!", 3000, 3);
                    GameTextForPlayer(playerid, "~r~Head shot!", 3000, 3);
                }
    else return PlayerPlaySound(issuerid,17802,0.0,0.0,0.0);
 }else {GameTextForPlayer(issuerid, "~w~don't shoot team mates", 3000, 3);}
 }
   return 0;
}
+REPP!

Re: HEADSHOT script won't work - CalvinC - 14.03.2015

Just because you didn't define it, it doesn't mean using "new" will define it correctly.
What you did was just declaring a variable, that's set to 0 by default, and you don't change the value anywhere, that simply wont work.

As said on the wiki, you need to use #define to define the bodyparts manually, like this:
Quote:
#define BODY_PART_TORSO 3
#define BODY_PART_GROIN 4
#define BODY_PART_LEFT_ARM 5
#define BODY_PART_RIGHT_ARM 6
#define BODY_PART_LEFT_LEG 7
#define BODY_PART_RIGHT_LEG 8
#define BODY_PART_HEAD 9
Instead of declaring it with "new".