SA-MP Forums Archive
Command problem - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Command problem (/showthread.php?tid=557411)


Command problem - ZaBraNjeNi - 13.01.2015

Hi,

Problem is with "healall" comand, what's a wrong?
Код:
CMD:healall(playerid, params[])
{
	new
	    string[200]
	;

	LoginCheck(playerid);
	if(User[playerid][accountAdmin] >= 4)
	{
	   	foreach(new i : Player)
		{
			if(i != playerid && User[playerid][accountAdmin] < User[i][accountAdmin])
			{
				PlayerPlaySound(i, 1057, 0.0, 0.0, 0.0);
				SetPlayerHealth(i, 100.0);
			}
		}
		SendPlayerMessage(COLOR_RED, "[HEAL] "white"Everyone has been healed by an admin.");
		format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
		SendAMessage(COLOR_RED, string);
	}
	else
	{
	    SendClientMessage(playerid, -1, "» "red"You are not authorized to use this command.");
	}
	return 1;
}


Re: Command problem - SWAT4 - 13.01.2015

It Shows Errors Or Something?
or It Dosent Work?

Re: Command problem - ZaBraNjeNi - 13.01.2015

Oops, I forgot to write.
It doesn't work.
Compiled without errors / warnings.

Re: Command problem - SWAT4 - 13.01.2015

try this
pawn Код:
CMD:healall(playerid,params[])
{
    new string[200];
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 4)
    {
        foreach(Player, i)
        {
        PlayerPlaySound(i,1057,0.0,0.0,0.0);
        SetPlayerHealth(i,100.0);
        }
        }
        format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
        SendAMessage(COLOR_RED, string);
    }
    else return SendClientMessage(playerid, -1, "» "red"You are not authorized to use this command.");
}
Hope it works
im not rly sure i didn't test ,
i made some changes so Please Friendly Replys

Re: Command problem - ZaBraNjeNi - 13.01.2015

I get error and warning:
Код:
C:\Documents and Settings\2012\Desktop\JaKes FuN GM_Linux\JaKe_Linux\gamemodes\blank.pwn(3348) : warning 209: function "cmd_healall" should return a value
C:\Documents and Settings\2012\Desktop\JaKes FuN GM_Linux\JaKe_Linux\gamemodes\blank.pwn(3349) : error 010: invalid function or declaration
Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


1 Error.


Re: Command problem - SWAT4 - 13.01.2015

aight Show me Line 3349
And ,
About the Should Return Value , use this
pawn Код:
CMD:healall(playerid,params[])
{
    new string[200];
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 4)
    {
        foreach(Player, i)
        {
        PlayerPlaySound(i,1057,0.0,0.0,0.0);
        SetPlayerHealth(i,100.0);
        }
        }
        format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
        SendAMessage(COLOR_RED, string);
    }
        else
        {
            SendClientMessage(playerid, COLOR_GREY, "You are not authorized to use that command!"); // if not, send him only the following message
        }
        return 1;
    }
}
Remember : This should Fix THe Warning ,

About The Error , Show me line So i can know Wats Wrong

Re: Command problem - ZaBraNjeNi - 14.01.2015

Код:
C:\Documents and Settings\2012\Desktop\JaKes FuN GM_Linux\JaKe_Linux\gamemodes\blank.pwn(3348) : warning 209: function "cmd_healall" should return a value
C:\Documents and Settings\2012\Desktop\JaKes FuN GM_Linux\JaKe_Linux\gamemodes\blank.pwn(3349) : error 010: invalid function or declaration
C:\Documents and Settings\2012\Desktop\JaKes FuN GM_Linux\JaKe_Linux\gamemodes\blank.pwn(3353) : error 010: invalid function or declaration
Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


2 Errors.
Line 3348:
Код:
}
Line 3349:
Код:
else
Line 3353:
Код:
return 1;
Full code:
Код:
CMD:healall(playerid,params[])
{
    new string[200];
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 4)
    {
        foreach(Player, i)
        {
        PlayerPlaySound(i,1057,0.0,0.0,0.0);
        SetPlayerHealth(i,100.0);
        }
    }
    format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
    SendAMessage(COLOR_RED, string);
    } //-> Warning 3348
    else //-> Error 3349
    {
    	SendClientMessage(playerid, COLOR_GREY, "You are not authorized to use that command!"); // if not, send him only the following message
     }
     return 1; //-> Error 3353
    }
}


Re: Command problem - CalvinC - 14.01.2015

pawn Код:
CMD:healall(playerid,params[])
{
    new string[200];
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 4)
    {
        foreach(Player, i)
        {
        PlayerPlaySound(i,1057,0.0,0.0,0.0);
        SetPlayerHealth(i,100.0);
        }
    }
    format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
    SendAMessage(COLOR_RED, string);
    } //-> Warning 3348
    else //-> Error 3349
    {
        SendClientMessage(playerid, COLOR_GREY, "You are not authorized to use that command!"); // if not, send him only the following message
     }
    }
    return 1; // This needs to be at the last bracket, so it symbolizes the command
}
Read the warnings/errors, first the warning, the command should return a value.
Which means you should have a return 1 inside the commands brackets, like above.

And about the "else", you do not have an "if" to activate it?
You might have meant to do underneath.
pawn Код:
CMD:healall(playerid,params[])
{
    new string[200];
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] < 4) return SendClientMessage(playerid, COLOR_GREY, "You are not authorized to use that command!");
    foreach(Player, i)
    {
        PlayerPlaySound(i,1057,0.0,0.0,0.0);
        SetPlayerHealth(i,100.0);
    }
    format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
    SendAMessage(COLOR_RED, string);
    return 1; // This needs to be at the last bracket, so it symbolizes the command
}
Because you closed the "if" with a bracket, therefore the "else" cannot refer back to it. Using "return (function)" is a much better method though, so i changed it to that.

Re: Command problem - MBilal - 14.01.2015

PHP код:
CMD:healall(playerid,params[])
{
    new string[200];
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 4)
    {
        foreach(Player, i)
        {
        PlayerPlaySound(i,1057,0.0,0.0,0.0);
        SetPlayerHealth(i,100.0);
        }
    format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
    SendAMessage(COLOR_RED, string);
    }
    else 
    {
        SendClientMessage(playerid, COLOR_GREY, "You are not authorized to use that command!"); 
     }
     return 1; 
    } 


Re: Command problem - ZaBraNjeNi - 14.01.2015

Quote:
Originally Posted by CalvinC
Посмотреть сообщение
pawn Код:
CMD:healall(playerid,params[])
{
    new string[200];
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] >= 4)
    {
        foreach(Player, i)
        {
        PlayerPlaySound(i,1057,0.0,0.0,0.0);
        SetPlayerHealth(i,100.0);
        }
    }
    format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
    SendAMessage(COLOR_RED, string);
    } //-> Warning 3348
    else //-> Error 3349
    {
        SendClientMessage(playerid, COLOR_GREY, "You are not authorized to use that command!"); // if not, send him only the following message
     }
    }
    return 1; // This needs to be at the last bracket, so it symbolizes the command
}
Read the warnings/errors, first the warning, the command should return a value.
Which means you should have a return 1 inside the commands brackets, like above.

And about the "else", you do not have an "if" to activate it?
You might have meant to do underneath.
pawn Код:
CMD:healall(playerid,params[])
{
    new string[200];
    LoginCheck(playerid);
    if(User[playerid][accountAdmin] < 4) return SendClientMessage(playerid, COLOR_GREY, "You are not authorized to use that command!");
    foreach(Player, i)
    {
        PlayerPlaySound(i,1057,0.0,0.0,0.0);
        SetPlayerHealth(i,100.0);
    }
    format(string, 128, "[HEAL] "white"Everyone has been healed by %s.", GetName(playerid));
    SendAMessage(COLOR_RED, string);
    return 1; // This needs to be at the last bracket, so it symbolizes the command
}
Because you closed the "if" with a bracket, therefore the "else" cannot refer back to it. Using "return (function)" is a much better method though, so i changed it to that.
Thanks bro fixed.
REP+