Problem with sending hit contract message on death

Problem with sending hit contract message on death - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Problem with sending hit contract message on death (/showthread.php?tid=554054)

Problem with sending hit contract message on death - FunnyBear - 02.01.2015

Hey,

I'm currently scripting a Hit Contract system, and its going quite well except for one thing. When the player is killed by a bounty hunter, they receive the money and a message is sent, but it doesn't work.

Here is the code for it,

pawn Код:

if( hasHit[playerid] == true && gTeam[ killerid ] == TEAM_CIV_BOUNTY )
    {
        new
            str[128];

        format(str, sizeof(str), "[HIT] %s[%d] has been killed by Bounty Hunter %s[%d] for $%d", GetName(playerid), playerid, GetName(killerid), killerid, hitAmount[playerid]);
        SendClientMessageToAll(SERVER_MESSAGE, str);

        GivePlayerMoney(killerid, hitAmount[playerid]);
        hasHit[playerid] = false;
        hitAmount[playerid] = 0;
        SetPlayerScore(killerid, GetPlayerScore(killerid) + 2);
    }

How am I able to fix this?

Thanks,

FunnyBear

Re: Problem with sending hit contract message on death - Sledgehammer - 02.01.2015

Under what function did you place this code?

Re: Problem with sending hit contract message on death - FunnyBear - 02.01.2015

Quote:

Originally Posted by Death1300

Under what function did you place this code?

I placed the function under, OnPlayerDeath

And here is the bounty command,

pawn Код:

CMD:bounty(playerid, params[])
{

    if( gTeam [ playerid ] == TEAM_CIV_BOUNTY )
        return SendClientMessage(playerid, 0xFF0000FF, "ERROR:{FFFFFF} Bounty Hunters cannot place hits on other people");

    new
        id,
        amount;

    if( sscanf(params, "ui", id, amount))
        return SendUsageError( playerid, "/bounty [Name/ID] [Amount]" );

    if ( id == INVALID_PLAYER_ID )
        return InvalidPlayerError( playerid );

    if( id == playerid)
        return SendClientMessage(playerid, 0xFF0000FF, "ERROR:{FFFFFF} You cannot place a Bounty Hit on yourself");

    if( hasHit[id] == true)
        return SendClientMessage(playerid, 0xFF0000FF, "ERROR:{FFFFFF} This player already has a hit on them");

    if( amount <  1500)
        return SendClientMessage(playerid, 0xFF0000FF, "ERROR:{FFFFFF} Minimum hit amount is $1,500");

    if( amount >  1000000)
        return SendClientMessage(playerid, 0xFF0000FF, "ERROR:{FFFFFF} Maximum hit amount is $1,000,000");

    if( GetPlayerMoney( playerid ) < amount )
        return SendClientMessage(playerid, 0xFF0000FF, "ERROR:{FFFFFF} You do not have enough money to pay for the bounty");

    hasHit[id] = true;
    hitAmount[id] = amount;

    new
        str[128],
        str1[128];

    format(str, sizeof(str), "[HIT] A $%d hit has been placed on you. Beware!", amount);
    SendClientMessage(id, RED, str);
    GameTextForPlayer(id, "~r~HIT BOUNTY ~y~PLACED~r~ON YOU", 6000, 3);

    format(str1, sizeof(str1), "[HIT] You have placed a $%d hit on %s[%d]", amount, GetName(id), id);
    SendClientMessage(playerid, RED, str1);
    GivePlayerMoney(playerid, -amount);
    return 1;
}

Re: Problem with sending hit contract message on death - rickisme - 02.01.2015

i don't see anything wrong w your code, can you show me full OnPlayerDeath function ?

Re: Problem with sending hit contract message on death - ATGOggy - 02.01.2015

What is wrong? You said message is sent and money is given. I see no problem in the code.

Re: Problem with sending hit contract message on death - FunnyBear - 02.01.2015

The bounty command works fine when I place a hit on someone, but when I actually go to kill them, the function is not called.

Re: Problem with sending hit contract message on death - ATGOggy - 02.01.2015

Did you assign a value to the variable gTeam properly?

Re: Problem with sending hit contract message on death - Facerafter - 02.01.2015

Try putting the code at the begin of OnPlayerDeath

pawn Код:

public OnPlayerDeath(playerid, killerid, reason)
{
    if( hasHit[playerid] == true && gTeam[ killerid ] == TEAM_CIV_BOUNTY )
    {
        new
            str[128];

        format(str, sizeof(str), "[HIT] %s[%d] has been killed by Bounty Hunter %s[%d] for $%d", GetName(playerid), playerid, GetName(killerid), killerid, hitAmount[playerid]);
        SendClientMessageToAll(SERVER_MESSAGE, str);

        GivePlayerMoney(killerid, hitAmount[playerid]);
        hasHit[playerid] = false;
        hitAmount[playerid] = 0;
        SetPlayerScore(killerid, GetPlayerScore(killerid) + 2);
    }
    // The rest of your OnPlayerDeath code
    return 1;
}

Re: Problem with sending hit contract message on death - ATGOggy - 02.01.2015

Quote:

Originally Posted by Facerafter

Try putting the code at the begin of OnPlayerDeath

pawn Код:

public OnPlayerDeath(playerid, killerid, reason)
{
    if( hasHit[playerid] == true && gTeam[ killerid ] == TEAM_CIV_BOUNTY )
    {
        new
            str[128];

        format(str, sizeof(str), "[HIT] %s[%d] has been killed by Bounty Hunter %s[%d] for $%d", GetName(playerid), playerid, GetName(killerid), killerid, hitAmount[playerid]);
        SendClientMessageToAll(SERVER_MESSAGE, str);

        GivePlayerMoney(killerid, hitAmount[playerid]);
        hasHit[playerid] = false;
        hitAmount[playerid] = 0;
        SetPlayerScore(killerid, GetPlayerScore(killerid) + 2);
    }
    // The rest of your OnPlayerDeath code
    return 1;
}

Yes, because there might be a return in the rest of the code, so it'll skip these.

Re: Problem with sending hit contract message on death - FunnyBear - 02.01.2015

Yes it works, thanks guys