do-while loop help(SQLite / Name checks) - Printable Version
+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: do-while loop help(SQLite / Name checks) (/showthread.php?tid=544684)
+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: do-while loop help(SQLite / Name checks) (/showthread.php?tid=544684)
do-while loop help(SQLite / Name checks) - Kyance - 03.11.2014
I'm having some problems with my do-while loop..
I dunno how to explain it, but, It should do a loop trough the DB until a "free name" is found, but when a "free name" IS found, nothing happens D:
Code;
pawn Код:
//Gets shown if player fails to login 3x
case DIALOG_FAIL_LOGIN:
{
if( !response ) return SetTimerEx("KickTimer", 50, false, "i", playerid);
if( response )
{
new Query[106], name[24], string[66], character = 1, DBResult:Result;
format(name, sizeof(name), "%s_%d", GetName(playerid), character);
format(Query, sizeof(Query), "SELECT * FROM `USERS` WHERE `NAME` = '%s'", name);
Result = db_query(HDF, Query);
if(db_num_rows(Result))
{
do
{
character++;
format(name, sizeof(name), "%s_%d", GetName(playerid), character);
format(string, sizeof(string), "Skipping name '%s' because is in use.", name), SendClientMessage(playerid, COLOR_NOTES2, string);
}
while(db_next_row(Result));
}
else
{
format(string, sizeof(string), "Found a valid name - '%s' - setting. . .", name), SendClientMessage(playerid, COLOR_NOTES, string);
SetPlayerName(playerid, name);
SendClientMessage(playerid, COLOR_NOTES, "INFO: You will need to register now to save your stats");
PlayerPlaySound(playerid,1057,0.0,0.0,0.0);
ShowPlayerDialog(playerid, DIALOG_REGISTER, DIALOG_STYLE_INPUT, "{64CC66}Registration.", "{FFFFFF}Welcome to the server!\nYour name is detected as {64CC66}unregistered{FFFFFF}.\nYou are required to register to proceed playing.\n{64CC66}Enter your password below to complete the registration.", "Register", "Leave");
}
db_free_result(Result);
}
}
Re: do-while loop help(SQLite / Name checks) - BroZeus - 03.11.2014
This is because it is there is nothing to do when loop ends ._ like this --
pawn Код:
case DIALOG_FAIL_LOGIN:
{
if( !response ) return SetTimerEx("KickTimer", 50, false, "i", playerid);
if( response )
{
new Query[106], name[24], string[66], character = 1, DBResult:Result;
format(name, sizeof(name), "%s_%d", GetName(playerid), character);
format(Query, sizeof(Query), "SELECT * FROM `USERS` WHERE `NAME` = '%s'", name);
Result = db_query(HDF, Query);
if(db_num_rows(Result))
{
do
{
character++;
format(name, sizeof(name), "%s_%d", GetName(playerid), character);
format(string, sizeof(string), "Skipping name '%s' because is in use.", name), SendClientMessage(playerid, COLOR_NOTES2, string);
}
while(db_next_row(Result));
}
format(string, sizeof(string), "Found a valid name - '%s' - setting. . .", name), SendClientMessage(playerid, COLOR_NOTES, string);
SetPlayerName(playerid, name);
SendClientMessage(playerid, COLOR_NOTES, "INFO: You will need to register now to save your stats");
PlayerPlaySound(playerid,1057,0.0,0.0,0.0);
ShowPlayerDialog(playerid, DIALOG_REGISTER, DIALOG_STYLE_INPUT, "{64CC66}Registration.", "{FFFFFF}Welcome to the server!\nYour name is detected as {64CC66}unregistered{FFFFFF}.\nYou are required to register to proceed playing.\n{64CC66}Enter your password below to complete the registration.", "Register", "Leave");
db_free_result(Result);
}
}
Re: do-while loop help(SQLite / Name checks) - Kyance - 03.11.2014
Quote:
|
Originally Posted by BroZeus
 This is because it is there is nothing to do when loop ends ._ like this --
pawn Код:
|
[17:33:10] Found a valid name - 'Kyance_2' - setting. . .
:l
Re: do-while loop help(SQLite / Name checks) - Evocator - 03.11.2014
Nvm itll create an infinite loop.
Re: do-while loop help(SQLite / Name checks) - Stinged - 03.11.2014
The problem is this:
The query is running only once.
It's formatted to %s = Name_1
It never re-formats to re-call the query to re-check if the name is available.
EDIT: You probably wont understand what I mean, so I'll explain it with comments.
pawn Код:
case DIALOG_FAIL_LOGIN:
{
if( !response ) return SetTimerEx("KickTimer", 50, false, "i", playerid);
if( response )
{
new Query[106], name[24], string[66], character = 1, DBResult:Result;
format(name, sizeof(name), "%s_%d", GetName(playerid), character);
format(Query, sizeof(Query), "SELECT * FROM `USERS` WHERE `NAME` = '%s'", name);
// Let's say the query is now this
// SELECT * FROM `USERS` WHERE `NAME` = 'Example_1'
Result = db_query(HDF, Query);
if(db_num_rows(Result)) // If the name exists
{
do
{
character++;
format(name, sizeof(name), "%s_%d", GetName(playerid), character);
// You're adding the new number to the name.
// But where are you adding it to the query?
format(string, sizeof(string), "Skipping name '%s' because is in use.", name), SendClientMessage(playerid, COLOR_NOTES2, string);
}
while(db_next_row(Result)); // It's always checking for Example_1
}
else
{
format(string, sizeof(string), "Found a valid name - '%s' - setting. . .", name), SendClientMessage(playerid, COLOR_NOTES, string);
SetPlayerName(playerid, name);
SendClientMessage(playerid, COLOR_NOTES, "INFO: You will need to register now to save your stats");
PlayerPlaySound(playerid,1057,0.0,0.0,0.0);
ShowPlayerDialog(playerid, DIALOG_REGISTER, DIALOG_STYLE_INPUT, "{64CC66}Registration.", "{FFFFFF}Welcome to the server!\nYour name is detected as {64CC66}unregistered{FFFFFF}.\nYou are required to register to proceed playing.\n{64CC66}Enter your password below to complete the registration.", "Register", "Leave");
}
db_free_result(Result);
}
}
Re: do-while loop help(SQLite / Name checks) - xXShadowXx - 03.11.2014
pawn Код:
case DIALOG_FAIL_LOGIN:
{
#define MAX_CHARACTER 32
if(!response) return 0;
new query[128],name[24],string[128],DBResult:result;
for(new character = 0; character < MAX_CHARACTER; character ++)
{
format(name,sizeof(name),"%s_%d",GetName(playerid),character);
format(query,sizeof(query),"SELECT * FROM `USERS` WHERE `NAME` = '%s' LIMIT 1",name);
result = db_query(database,query);
if(db_num_rows(result))
{
format(string,sizeof(string),"> Skipping name \"%s\" - Already in use.",name);
SendClientMessage(playerid,COLOR_NOTES2,string);
if(character == MAX_CHARACTER)
{
SendClientMessage(playerid,COLOR_NOTES2,"> Out of "#MAX_CHARACTER" names, there was none available. You have been kicked.");
Kick(playerid);
return db_free_result(result);
}
}
else
{
format(string,sizeof(string),"> Found a valid name \"%s\" - Setting.",name);
SendClientMessage(playerid,COLOR_NOTES,string);
SendClientMessage(playerid, COLOR_NOTES, "INFO: You will need to register now to save your stats");
PlayerPlaySound(playerid,1057,0.0,0.0,0.0);
ShowPlayerDialog(playerid, DIALOG_REGISTER, DIALOG_STYLE_INPUT, "{64CC66}Registration.", "{FFFFFF}Welcome to the server!\nYour name is detected as {64CC66}unregistered{FFFFFF}.\nYou are required to register to proceed playing.\n{64CC66}Enter your password below to complete the registration.", "Register", "Leave");
db_free_result(result);
return 1;
}
db_free_result(result);
}
}
Re: do-while loop help(SQLite / Name checks) - Kyance - 03.11.2014
Quote:
|
Originally Posted by Stinged
The problem is this:
The query is running only once. It's formatted to %s = Name_1 It never re-formats to re-call the query to re-check if the name is available. EDIT: You probably wont understand what I mean, so I'll explain it with comments. pawn Код:
|
@xXShadowXx: That worked, thanks
