it takes the ID as the price!?

it takes the ID as the price!? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: it takes the ID as the price!? (/showthread.php?tid=526141)

it takes the ID as the price!? - Don_Cage - 15.07.2014

So, this is my code..

pawn Код:

if(strcmp(cmd, "/sellhouseto", true) == 0)
    {
        if(IsPlayerConnected(playerid))
        {
            GetPlayerName(playerid, playername, sizeof(playername));
            tmp = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                return 1;
            }
            giveplayerid = ReturnUser(tmp);
            if(giveplayerid != INVALID_PLAYER_ID)
            {
                if(!strlen(tmp))
                {
                    SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                    return 1;
                }
                new price,house;
                GetPlayerName(giveplayerid, giveplayer, sizeof(giveplayer));
                house = PlayerInfo[playerid][pHouseKey];
                price = strval(tmp);
                if(price < 1 || price > 2000000) return SCM(playerid, COLOR_GRAD1, "Price can't be lower than 1 or higher than 2000000!");
                if(PlayerInfo[playerid][pHouseKey] == 9999)
                {
                    SCM(playerid, COLOR_WHITE, "You don't own a house.");
                    return 1;
                }
                if(PlayerInfo[playerid][pHouseKey] != 9999 && strcmp(playername, HouseInfo[PlayerInfo[playerid][pHouseKey]][hOwner], true) == 0)
                {
                    format(string, sizeof(string),"%s Has offered you to buy his house for %i $.",playername, price);
                    SCM(giveplayerid, COLOR_RLRPGBLUE, string);
                    SCM(giveplayerid, COLOR_LIGHTGREEN,"To accept the offer, type /accept house");
                    format(string, sizeof(string),"You offered %s to buy your house for %i $.",giveplayer);
                    SCM(playerid, COLOR_RLRPGBLUE, string);
                    OfferHouse[giveplayerid] = playerid;
                    HouseInfo[house][hValue] = price;
                    OfferHouseKey[giveplayerid] = house;
                }
            }
            else
            {
                SCM(playerid, COLOR_GREY,"Player is not online");
                return 1;
            }
        }
        return 1;
    }

When someone do this cmd and offer the house to for example id 1, then the price will be 1 even if you offer the house for example 50000!? If you take id 2 the price will be 2 no matter what you type as the price it takes the ID of the player you're offering it to.. Why?

Re: it takes the ID as the price!? - kamiliuxliuxliux - 15.07.2014

I suggest you to move your commands to ZCMD. It's MUCH easier.

Re: it takes the ID as the price!? - Don_Cage - 15.07.2014

Quote:

Originally Posted by kamiliuxliuxliux

I suggest you to move your commands to ZCMD. It's MUCH easier.

I didn't want any suggestions. I wanted an awnser on my question. I know zcmd is easier but I don't want to re-make all my cmds into zcmd and sscanf

Re: it takes the ID as the price!? - BlackSirrah239 - 16.07.2014

Quote:

Originally Posted by Don_Cage

I didn't want any suggestions. I wanted an awnser on my question. I know zcmd is easier but I don't want to re-make all my cmds into zcmd and sscanf

Using ZCMD would make it a lot clearer and easier to understand why it isnt working.

Anyway, it looks like you have only used strtok once on the variable tmp and you are using that for both the playerid and price. I don't exactly know how strtok works, but that looks like it is the cause of the problem.

Код:

tmp = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                return 1;
            }
            giveplayerid = ReturnUser(tmp);
            if(giveplayerid != INVALID_PLAYER_ID)
            {
                if(!strlen(tmp))
                {
                    SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                    return 1;
                }
                new price,house;
                GetPlayerName(giveplayerid, giveplayer, sizeof(giveplayer));
                house = PlayerInfo[playerid][pHouseKey];
                price = strval(tmp);

Re: it takes the ID as the price!? - admiralspeedy - 16.07.2014

You could literally use Find and Replace (CTRL + F) and a regex expression to switch all of your commands to YCMD or ZCMD in about 5 seconds.

Re: it takes the ID as the price!? - R0 - 16.07.2014

There you go:

pawn Код:

if(strcmp(cmd, "/sellhouseto", true) == 0)
    {
        if(IsPlayerConnected(playerid))
        {
            GetPlayerName(playerid, playername, sizeof(playername));
            tmp = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                return 1;
            }
            giveplayerid = ReturnUser(tmp);
            if(giveplayerid != INVALID_PLAYER_ID)
            {
                if(!strlen(tmp))
                {
                    SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                    return 1;
                }
                new price,house;
                GetPlayerName(giveplayerid, giveplayer, sizeof(giveplayer));
                house = PlayerInfo[playerid][pHouseKey];
                tmp = strtok(cmdtext, idx);
                price = strval(tmp);
                if(price < 1 || price > 2000000) return SCM(playerid, COLOR_GRAD1, "Price can't be lower than 1 or higher than 2000000!");
                if(PlayerInfo[playerid][pHouseKey] == 9999)
                {
                    SCM(playerid, COLOR_WHITE, "You don't own a house.");
                    return 1;
                }
                if(PlayerInfo[playerid][pHouseKey] != 9999 && strcmp(playername, HouseInfo[PlayerInfo[playerid][pHouseKey]][hOwner], true) == 0)
                {
                    format(string, sizeof(string),"%s Has offered you to buy his house for %i $.",playername, price);
                    SCM(giveplayerid, COLOR_RLRPGBLUE, string);
                    SCM(giveplayerid, COLOR_LIGHTGREEN,"To accept the offer, type /accept house");
                    format(string, sizeof(string),"You offered %s to buy your house for %i $.",giveplayer);
                    SCM(playerid, COLOR_RLRPGBLUE, string);
                    OfferHouse[giveplayerid] = playerid;
                    HouseInfo[house][hValue] = price;
                    OfferHouseKey[giveplayerid] = house;
                }
            }
            else
            {
                SCM(playerid, COLOR_GREY,"Player is not online");
                return 1;
            }
        }
        return 1;
    }

Re: it takes the ID as the price!? - Don_Cage - 16.07.2014

Quote:

Originally Posted by BlackSirrah239

Код:

tmp = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                return 1;
            }
            giveplayerid = ReturnUser(tmp);
            if(giveplayerid != INVALID_PLAYER_ID)
            {
                if(!strlen(tmp))
                {
                    SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                    return 1;
                }
                new price,house;
                GetPlayerName(giveplayerid, giveplayer, sizeof(giveplayer));
                house = PlayerInfo[playerid][pHouseKey];
                price = strval(tmp);

Quote:

Originally Posted by R0

There you go:

pawn Код:

if(strcmp(cmd, "/sellhouseto", true) == 0)
    {
        if(IsPlayerConnected(playerid))
        {
            GetPlayerName(playerid, playername, sizeof(playername));
            tmp = strtok(cmdtext, idx);
            if(!strlen(tmp))
            {
                SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                return 1;
            }
            giveplayerid = ReturnUser(tmp);
            if(giveplayerid != INVALID_PLAYER_ID)
            {
                if(!strlen(tmp))
                {
                    SCM(playerid, COLOR_GRAD1, "USAGE: /sellhouseto [playerid/PartOfName] [price]");
                    return 1;
                }
                new price,house;
                GetPlayerName(giveplayerid, giveplayer, sizeof(giveplayer));
                house = PlayerInfo[playerid][pHouseKey];
                tmp = strtok(cmdtext, idx);
                price = strval(tmp);
                if(price < 1 || price > 2000000) return SCM(playerid, COLOR_GRAD1, "Price can't be lower than 1 or higher than 2000000!");
                if(PlayerInfo[playerid][pHouseKey] == 9999)
                {
                    SCM(playerid, COLOR_WHITE, "You don't own a house.");
                    return 1;
                }
                if(PlayerInfo[playerid][pHouseKey] != 9999 && strcmp(playername, HouseInfo[PlayerInfo[playerid][pHouseKey]][hOwner], true) == 0)
                {
                    format(string, sizeof(string),"%s Has offered you to buy his house for %i $.",playername, price);
                    SCM(giveplayerid, COLOR_RLRPGBLUE, string);
                    SCM(giveplayerid, COLOR_LIGHTGREEN,"To accept the offer, type /accept house");
                    format(string, sizeof(string),"You offered %s to buy your house for %i $.",giveplayer);
                    SCM(playerid, COLOR_RLRPGBLUE, string);
                    OfferHouse[giveplayerid] = playerid;
                    HouseInfo[house][hValue] = price;
                    OfferHouseKey[giveplayerid] = house;
                }
            }
            else
            {
                SCM(playerid, COLOR_GREY,"Player is not online");
                return 1;
            }
        }
        return 1;
    }

Thansk, forgot that strtok