SA-MP Forums Archive
Anti CS - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Anti CS (/showthread.php?tid=493919)



Anti CS - FaZeRs - 10.02.2014

I got some warnings when i added Anti CS System to my GM.

Code
PHP код:
// Anti CS
#define MAX_SLOTS 40
new NotMoving[MAX_PLAYERS];
new 
WeaponID[MAX_PLAYERS];
new 
CheckCrouch[MAX_PLAYERS];
new 
Ammo[MAX_PLAYERS][MAX_SLOTS];
public 
OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
    if((
newkeys & KEY_FIRE) && (oldkeys & KEY_CROUCH) && !((oldkeys & KEY_FIRE) || (newkeys & KEY_HANDBRAKE)) || (oldkeys & KEY_FIRE) && (newkeys & KEY_CROUCH) && !((newkeys & KEY_FIRE) || (newkeys & KEY_HANDBRAKE)) ) {
        switch(
GetPlayerWeapon(playerid)) {
            case 
23..25, 27, 29..34, 41: {
                if(
Ammo[playerid][GetPlayerWeapon(playerid)] > GetPlayerAmmo(playerid)) {
                    
OnPlayerCBug(playerid);
                }
                return 
1;
            }
        }
    }
    if(
CheckCrouch[playerid] == 1) {
        switch(
WeaponID[playerid]) {
            case 
23..25, 27, 29..34, 41: {
                if((
newkeys & KEY_CROUCH) && !((newkeys & KEY_FIRE) || (newkeys & KEY_HANDBRAKE)) && GetPlayerSpecialAction(playerid) != SPECIAL_ACTION_DUCK ) {
                    if(
Ammo[playerid][GetPlayerWeapon(playerid)] > GetPlayerAmmo(playerid)) {
                        
OnPlayerCBug(playerid);
                    }
                }
            }
        }
    }
    
//if(newkeys & KEY_CROUCH || (oldkeys & KEY_CROUCH)) return 1;
    
else if(((newkeys & KEY_FIRE) && (newkeys & KEY_HANDBRAKE) && !((newkeys & KEY_SPRINT) || (newkeys & KEY_JUMP))) ||
    (
newkeys & KEY_FIRE) && !((newkeys & KEY_SPRINT) || (newkeys & KEY_JUMP)) ||
    (
NotMoving[playerid] && (newkeys & KEY_FIRE) && (newkeys & KEY_HANDBRAKE)) ||
    (
NotMoving[playerid] && (newkeys & KEY_FIRE)) ||
    (
newkeys & KEY_FIRE) && (oldkeys & KEY_CROUCH) && !((oldkeys & KEY_FIRE) || (newkeys & KEY_HANDBRAKE)) ||
    (
oldkeys & KEY_FIRE) && (newkeys & KEY_CROUCH) && !((newkeys & KEY_FIRE) || (newkeys & KEY_HANDBRAKE)) ) {
        
SetTimerEx("CrouchCheck", 3000, 0, "d", playerid);
        
CheckCrouch[playerid] = 1;
        
WeaponID[playerid] = GetPlayerWeapon(playerid);
        
Ammo[playerid][GetPlayerWeapon(playerid)] = GetPlayerAmmo(playerid);
        return 
1;
    }
    return 
1;
}
public 
OnPlayerUpdate(playerid)
{
      
// AntiCS
        
new Keys, ud, lr; // This line have error
        
GetPlayerKeys(playerid, Keys, ud, lr);
        if(
CheckCrouch[playerid] == 1) {
            switch(
WeaponID[playerid]) {
                case 
23..25, 27, 29..34, 41: {
                    if((
Keys & KEY_CROUCH) && !((Keys & KEY_FIRE) || (Keys & KEY_HANDBRAKE)) && GetPlayerSpecialAction(playerid) != SPECIAL_ACTION_DUCK ) {
                        if(
Ammo[playerid][GetPlayerWeapon(playerid)] > GetPlayerAmmo(playerid)) {
                            
OnPlayerCBug(playerid);
                        }
                    }
                    
//else SendClientMessage(playerid, COLOR_RED, "Failed in onplayer update");
                
}
            }
        }
    return 
1;
}
// Anti CS
forward OnPlayerCBug(playerid);
public 
OnPlayerCBug(playerid) {
    if(!
EventKernel[playerid]) // This line have error
    
{
        new 
Float:H;
        
GetPlayerHealth(playerid, H);
        
SetPlayerHealth(playerid, H-5);
    }
    return 
1;
}
forward CrouchCheck(playerid);
public 
CrouchCheck(playerid) {
    
CheckCrouch[playerid] = 0;
    return 
1;
} 
Errors
PHP код:
C:\Users\Euronics Latvija\Desktop\LCRP\gamemodes\nlrp.pwn(6111) : warning 219: local variable "WeaponID" shadows a variable at a preceding level
C
:\Users\Euronics Latvija\Desktop\LCRP\gamemodes\nlrp.pwn(6111) : warning 219: local variable "Ammo" shadows a variable at a preceding level
C
:\Users\Euronics Latvija\Desktop\LCRP\gamemodes\nlrp.pwn(100093) : warning 219: local variable "Keys" shadows a variable at a preceding level
C
:\Users\Euronics Latvija\Desktop\LCRP\gamemodes\nlrp.pwn(100093) : warning 219: local variable "ud" shadows a variable at a preceding level
C
:\Users\Euronics Latvija\Desktop\LCRP\gamemodes\nlrp.pwn(100093) : warning 219: local variable "lr" shadows a variable at a preceding level
C
:\Users\Euronics Latvija\Desktop\LCRP\gamemodes\nlrp.pwn(108244) : warning 213: tag mismatch
Pawn compiler 3.2.3664              Copyright 
(c) 1997-2006, ITB CompuPhase
8 Warnings
. 
Error here
PHP код:
GivePlayerValidWeapon(playerid, WeaponID, Ammo) // Shows this line have error
{
    if((
PlayerInfo[playerid][pConnectTime] < 2 || PlayerInfo[playerid][pWRestricted] > 0) && WeaponID != 46 && WeaponID != 43) return 1;
    switch( 
WeaponID )
    {
          case 
0, 1:
        {
            
PlayerInfo[playerid][pGuns][ 0 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
2, 3, 4, 5, 6, 7, 8, 9:
        {
            
PlayerInfo[playerid][pGuns][ 1 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
22, 23, 24:
        {
            
PlayerInfo[playerid][pGuns][ 2 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
25, 26, 27:
        {
            
PlayerInfo[playerid][pGuns][ 3 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
28, 29, 32:
        {
            
PlayerInfo[playerid][pGuns][ 4 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
30, 31:
        {
            
PlayerInfo[playerid][pGuns][ 5 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
33, 34:
        {
            
PlayerInfo[playerid][pGuns][ 6 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
35, 36, 37, 38:
        {
            
PlayerInfo[playerid][pGuns][ 7 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
16, 17, 18, 39, 40:
        {
            
PlayerInfo[playerid][pGuns][ 8 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
41, 42, 43:
        {
            
PlayerInfo[playerid][pGuns][ 9 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
10, 11, 12, 13, 14, 15:
        {
            
PlayerInfo[playerid][pGuns][ 10 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
        case 
44, 45, 46:
        {
            
PlayerInfo[playerid][pGuns][ 11 ] = WeaponID;
            
GivePlayerWeapon( playerid, WeaponID, Ammo );
        }
    }
    return 
1;
} 



Re: Anti CS - PowerPC603 - 10.02.2014

pawn Код:
GivePlayerValidWeapon(playerid, WeaponID, Ammo) // Shows this line have error
This function uses the same variable-names as your global arrays:
pawn Код:
new WeaponID[MAX_PLAYERS];
new Ammo[MAX_PLAYERS][MAX_SLOTS];
That function tries to create 3 new variables (playerid, WeaponID and Ammo), but they exist already on the global level (your arrays).

Just change the variable-names in that function.


As for the others:
Do you have some other global variables that are called "Keys", "ud", "lr"?