foreach loop preferencing id0 over anyone else? - Printable Version
+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: foreach loop preferencing id0 over anyone else? (/showthread.php?tid=491300)
+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: foreach loop preferencing id0 over anyone else? (/showthread.php?tid=491300)
foreach loop preferencing id0 over anyone else? - Hoborific - 30.01.2014
so I've got a loop in a function on a 300ms timer, the timer gets called, it checks if the player has a Boolean set to true, if it does, it checks some math with their vehicle, now if i'm player 1 and player 0 has the Boolean to false, it works fine. but the second ID0 gets into the loop, it iterates id0 about 15 times before i'm lucky to see myself checked through.
before I post all my lengthy code for all prying eyes to steal my work, does anyone have any idea what could be causing this? Here's the start where it prints off if the player got an iteration done
pawn Код:
public FuncName()
{
foreach(new i : Player)
{
if(!IsPlayerConnected(i)) continue;
if(!PlayerStats[i][Boolean])
{
new str[80];
format(str,sizeof(str),"THIS GUY WAS FALSE:%i",i);
SendClientMessageToAll(ORANGE,str);
continue;
}
else
{
new str[80];
format(str,sizeof(str),"DRIFT TICK FOR PLAYERID %i",i);
SendClientMessageToAll(ORANGE,str);
Код:
[15:15:28] DRIFT TICK FOR PLAYERID 0 [15:15:28] DRIFT TICK FOR PLAYERID 0 [15:15:28] DRIFT TICK FOR PLAYERID 0 [15:15:29] DRIFT TICK FOR PLAYERID 0 [15:15:29] DRIFT TICK FOR PLAYERID 0 [15:15:29] DRIFT TICK FOR PLAYERID 0 [15:15:30] DRIFT TICK FOR PLAYERID 0 [15:15:30] DRIFT TICK FOR PLAYERID 1 [15:15:30] DRIFT TICK FOR PLAYERID 0 [15:15:30] DRIFT TICK FOR PLAYERID 1 [15:15:30] DRIFT TICK FOR PLAYERID 0 [15:15:30] DRIFT TICK FOR PLAYERID 1 [15:15:31] DRIFT TICK FOR PLAYERID 0 [15:15:31] DRIFT TICK FOR PLAYERID 1 [15:15:31] DRIFT TICK FOR PLAYERID 0 [15:15:31] DRIFT TICK FOR PLAYERID 0 [15:15:31] DRIFT TICK FOR PLAYERID 0 [15:15:32] DRIFT TICK FOR PLAYERID 0 [15:15:32] DRIFT TICK FOR PLAYERID 0 [15:15:32] DRIFT TICK FOR PLAYERID 0 [15:15:33] DRIFT TICK FOR PLAYERID 0 [15:15:33] DRIFT TICK FOR PLAYERID 0 [15:15:33] DRIFT TICK FOR PLAYERID 0 [15:15:34] DRIFT TICK FOR PLAYERID 0 [15:15:34] DRIFT TICK FOR PLAYERID 0 [15:15:34] DRIFT TICK FOR PLAYERID 0 [15:15:35] DRIFT TICK FOR PLAYERID 0 [15:15:35] DRIFT TICK FOR PLAYERID 0 [15:15:35] DRIFT TICK FOR PLAYERID 0 [15:15:35] DRIFT TICK FOR PLAYERID 0 [15:15:36] DRIFT TICK FOR PLAYERID 0 [15:15:36] DRIFT TICK FOR PLAYERID 0 [15:15:36] DRIFT TICK FOR PLAYERID 0 [15:15:37] DRIFT TICK FOR PLAYERID 0 [15:15:37] DRIFT TICK FOR PLAYERID 0 [15:15:37] DRIFT TICK FOR PLAYERID 0 [15:15:38] DRIFT TICK FOR PLAYERID 0 [15:15:38] DRIFT TICK FOR PLAYERID 0 [15:15:38] DRIFT TICK FOR PLAYERID 1
Re: foreach loop preferencing id0 over anyone else? - Patrick - 30.01.2014
4char
Re: foreach loop preferencing id0 over anyone else? - Hoborific - 30.01.2014
Else is supposed to be called if boolean is false, that's what the exclamation operator is for, it is supposed to be going into else, but it's supposed to be doing it evenly, the code should look like
Код:
[15:15:31] DRIFT TICK FOR PLAYERID 0 [15:15:31] DRIFT TICK FOR PLAYERID 1 [15:15:31] DRIFT TICK FOR PLAYERID 0 [15:15:31] DRIFT TICK FOR PLAYERID 1 [15:15:31] DRIFT TICK FOR PLAYERID 0 [15:15:31] DRIFT TICK FOR PLAYERID 1 [15:15:31] DRIFT TICK FOR PLAYERID 0 [15:15:31] DRIFT TICK FOR PLAYERID 1
Re: foreach loop preferencing id0 over anyone else? - Threshold - 30.01.2014
Quote:
|
Originally Posted by pds2k12
 Why do you use continue below PlayerStats[i][Boolean], try removing that because that continues that loop to else, that is why else is getting called most of the time.
|
pawn Код:
public FuncName()
{
foreach(Player, i)
{
new str[30];
if(PlayerStats[i][Boolean]) format(str, sizeof(str), "DRIFT TICK FOR PLAYERID %d", i);
else format(str, sizeof(str), "THIS GUY WAS FALSE: %d", i);
SendClientMessageToAll(ORANGE, str);
}
//Rest of code...
}
Re: foreach loop preferencing id0 over anyone else? - Hoborific - 30.01.2014
Turns out I had bad code terminating the loop early due to the function never finishing, because I have a dedicated server I test this on and something outside of sa-mp decided not to send a value back and just infinitely looped, I didn't notice the asynchronous loop not returning to the sa-mp server, so it basically timed out the for loop and started again from player 0, under certain conditions it would return a value and the loop continued, which is why the erratic number pattern was printed into chat instead of a smooth 0/1/0/1/0/1/0/1
tl;dr, plugin code gone bad, didn't talk back to for loop, loop would fail and return itself ( safety or else it hangs the whole server ) and now it's fixed.