All of function not being called.

All of function not being called. - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: All of function not being called. (/showthread.php?tid=449258)

All of function not being called. - Rokzlive - 08.07.2013

Ive debugged this for like a hour and finally found what is not being called. I cant figure out why.

pawn Код:

public OnPlayerPickUpDynamicPickup(playerid, pickupid)
{
    for (new i=1; i < MAX_HOUSES; i++) if (pickupid == Houses[i][house_pickup])
    {
        Players[playerid][last_house_entrance] = i;
        if (IsHouseOwnedByPlayer(playerid, i)) GameTextForPlayer(playerid, "~y~Press ~r~~k~~VEHICLE_ENTER_EXIT~ ~y~to enter your house", 3000, 3);
        break;
    }
    for(new i; i<= MAX_VEHICLE_DEALERS; i++)
    {
        print("1");
        if(pickupid == DealershipPickup[i])
        {
            print("22");
            new String[1000], String2[30];
            for(new n; n<= 500; n++)
            {
                print("333");
                if(BCarInfo[n][BCDealer] == i)
                {
                    print("4444");
                    format(String2,sizeof(String2),"%s - $%d\n",BCarInfo[n][BCName],BCarInfo[n][BCPrice]);
                    strcat(String,String2);
                }
            }
            new DialogID = 500+i;
            printf("%i",playerid);
            printf("%i",DialogID);
            printf("%f",DealerInfo[i][VDName]);
            printf("%f",String);
            ShowPlayerDialog(playerid,DialogID,DIALOG_STYLE_LIST,DealerInfo[i][VDName],String,"Buy","Cancel");
            print("55555");
            return 1;
        }
    }
    return 1;
}

Everything here is not being called:

pawn Код:

new DialogID = 500+i;
            printf("%i",playerid);
            printf("%i",DialogID);
            printf("%f",DealerInfo[i][VDName]);
            printf("%f",String);
            ShowPlayerDialog(playerid,DialogID,DIALOG_STYLE_LIST,DealerInfo[i][VDName],String,"Buy","Cancel");
            print("55555");
            return 1;

Can anyone see why?

Re: All of function not being called. - SuperViper - 08.07.2013

pawn Код:

n<= 500

should be

pawn Код:

n < 500

if it's a player loop. Otherwise it will go out of bounds and crash the callback.

Re: All of function not being called. - Rokzlive - 08.07.2013

Still not working.

Current Code

pawn Код:

public OnPlayerPickUpDynamicPickup(playerid, pickupid)
{
    for (new i=1; i < MAX_HOUSES; i++) if (pickupid == Houses[i][house_pickup])
    {
        Players[playerid][last_house_entrance] = i;
        if (IsHouseOwnedByPlayer(playerid, i)) GameTextForPlayer(playerid, "~y~Press ~r~~k~~VEHICLE_ENTER_EXIT~ ~y~to enter your house", 3000, 3);
        break;
    }
    for(new i; i< MAX_VEHICLE_DEALERS; i++)
    {
        print("1");
        if(pickupid == DealershipPickup[i])
        {
            print("22");
            new String[1000], String2[30];
            for(new n; n< 500; n++)
            {
                print("333");
                if(BCarInfo[n][BCDealer] == i)
                {
                    print("4444");
                    format(String2,sizeof(String2),"%s - $%d\n",BCarInfo[n][BCName],BCarInfo[n][BCPrice]);
                    strcat(String,String2);
                }
            }
            new DialogID = 500+i;
            printf("%i",playerid);
            printf("%i",DialogID);
            printf("%f",DealerInfo[i][VDName]);
            printf("%f",String);
            ShowPlayerDialog(playerid,DialogID,DIALOG_STYLE_LIST,DealerInfo[i][VDName],String,"Buy","Cancel");
            print("55555");
            return 1;
        }
    }
    return 1;
}

Re: All of function not being called. - Scenario - 08.07.2013

It's probably silent-crashing. Run the crashdetect plugin- it should show something.

Re: All of function not being called. - Rokzlive - 08.07.2013

Heres the error:

Код:

[21:31:11] [debug] Run time error 4: "Array index out of bounds"
[21:31:11] [debug]  Accessing element at index 132 past array upper bound 131
[21:31:11] [debug] AMX backtrace:
[21:31:11] [debug] #0 0000e0b8 in public OnPlayerPickUpDynamicPickup (0x00000000, 0x00000023) from MissionScript.amx
[21:31:11] [debug] #1 native Streamer_CallbackHook () [73defae0] from streamer.DLL
[21:31:11] [debug] #2 00000348 in public OnPlayerPickUpPickup (0x00000000, 0x00000000) from MissionScript.amx

Im assuming it means its overloading the string but the string. I dont know where it would do that though.

Re: All of function not being called. - SuperViper - 08.07.2013

Inside one of your loops you're trying to access an array with the index 132 but the limit is 131. Maybe MAX_PLAYERS is 131 but you're trying to loop 500 players or maybe MAX_HOUSES is 131 but the array is smaller. Maybe it's the dealerships.

Re: All of function not being called. - Rokzlive - 08.07.2013

Quote:

Originally Posted by SuperViper

Inside one of your loops you're trying to access an array with the index 132 but the limit is 131. Maybe MAX_PLAYERS is 131 but you're trying to loop 500 players or maybe MAX_HOUSES is 131 but the array is smaller. Maybe it's the dealerships.

Thank you so much. I was was letting it loop to 500 but there was only 131 in the enum that i defined. I fixed it by limiting it with sizeof(BCarInfo). It works now.