SA-MP Forums Archive
Huge bug - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Huge bug (/showthread.php?tid=445447)


Huge bug - Swyft™ - 21.06.2013

Well, zGaming (by iRage) has a HUGE bug in the script......

Mainly if you log on as someone else, if you place a random/wierd password it still logs you in... And this new version of it, still makes it happen. Anyway to fix it??

Currently
pawn Код:
new file[64], password[256], IP[16], password2[256];
            format(file, sizeof(file), "users/%s.ini", RPNU(playerid));
            WP_Hash(password2, sizeof(password2), inputtext);
            format(password, sizeof(password), "%s", dini_Get(file, "Password"));
            if(strcmp(dini_Get(file, "Password"), password2))
            {
                SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}Invalid password.");
                ShowDialog(playerid, 2);
                return 1;
            }
before it was

pawn Код:
new file[64], password[256], IP[16], password2[256];
            format(file, sizeof(file), "users/%s.ini", RPNU(playerid));
            WP_Hash(password2, sizeof(password2), inputtext);
            format(password, sizeof(password), "%s", dini_Get(file, "Password"));
            if(!strcmp(dini_Get(file, "Password"), password2))
            {
                SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}Invalid password.");
                ShowDialog(playerid, 2);
                return 1;
            }
Both do the same thing still.

Re: Huge bug - Copfan5 - 21.06.2013

Did you make the users folder where you need to have it?

Re: Huge bug - Swyft™ - 21.06.2013

I tried !strcmp, but it still allowed me to login.

Re: Huge bug - Swyft™ - 21.06.2013

I had it at (strcmp and it still allowed me to login with any password.... That's what I am telling you....

Re: Huge bug - MP2 - 21.06.2013

Remove the !.

Re: Huge bug - Swyft™ - 21.06.2013

I already did?


It says

Currently:
pawn Код:
new file[64], password[256], IP[16], password2[256];
            format(file, sizeof(file), "users/%s.ini", RPNU(playerid));
            WP_Hash(password2, sizeof(password2), inputtext);
            format(password, sizeof(password), "%s", dini_Get(file, "Password"));
            if(strcmp(dini_Get(file, "Password"), password2))
            {
                SendClientMessage(playerid, COLOR_LIGHTRED, "SERVER: {FFFFFF}Invalid password.");
                ShowDialog(playerid, 2);
                return 1;
            }


Re: Huge bug - KingHual - 21.06.2013

It should be
Код:
if(strcmp(dini_Get(file, "Password"), password2) != 0)
Quote:

Returns -1 if string1 comes before string2
1 if string1 comes after string2
0 if the strings are the same (for the matched length).
PS: Please, do NOT use dini

Re: Huge bug - Swyft™ - 21.06.2013

Sorry, but I don't see the big picture of Y_INI and DINI.....

Sure, we use tick rates to define if there faster... But the human eye can't detect it I believe. Dini likes me, and I work with it.... Y_INI is faster, who cares? It's not like I'm going to notice it...

Anyways, THANKS!

Re: Huge bug - Swyft™ - 22.06.2013

Re-bump, still can access it