SA-MP Forums Archive
OnPlayerTakeDamage - error - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: OnPlayerTakeDamage - error (/showthread.php?tid=426350)


OnPlayerTakeDamage - error - Davman - 28.03.2013

I've this error with this code:
Code:
public OnPlayerTakeDamage(playerid, issuerid, Float:amount, weaponid)
{

 if(issuerid != INVALID_PLAYER_ID && IsPlayerConnectedEx(issuerid))
 {

   if(tazer_out[issuerid])
  {

   if(GetPlayerWeapon(issuerid) == WEAPON_SILENCED)
   {

       if(GetDistanceBetweenPlayers(issuerid,playerid) < 10.0)
       {

        TazePlayer(issuerid,playerid);

    }

   }

  }

 }
 if(issuerid != INVALID_PLAYER_ID)
 {

     if(amount > 5.0 && weaponid != 0)
     {

         new Float:armor;
   GetPlayerArmour(playerid,armor);
   if(armor <= 0.0)
   {

          //TextDrawShowForPlayer(playerid,crash_screen);
          //SetTimerEx("HideCrash",250,0,"i",playerid);
          //SetPlayerDrunkLevel(playerid,(GetPlayerDrunkLevel(playerid) + 4000));

     }

     }

 }
 {
 if(issuerid == INVALID_PLAYER_ID) return 1;
 new Float:health,Float:armour;
 GetPlayerHealth(playerid,health);
 GetPlayerArmour(playerid,armour);
 new damage = 0;
 switch(weaponid)
 {
 case 22: damage = 58;
 }
 case 24: damage = 96;
 case 25:
 {
 if(amount < 45) damage = floatround(amount);
 else damage = 100 + floatround(amount);
 }
 case 27:
 {
 if(amount < 35) damage = floatround(amount);
 else damage = 100 + floatround(amount);
 }
 case 28: damage = 16;
 case 29: damage = 26;
 case 30: damage = 49;
 case 31: damage = 44;
 case 32: damage = 16;
 case 33: damage = 59;
 case 34: damage = 341;
 default: damage = floatround(amount);
}
}
C:\Users\Luca\Desktop\Server\rp.pwn(15257) : error 014: invalid statement; not in switch
C:\Users\Luca\Desktop\Server\rp.pwn(15257) : warning 215: expression has no effect
C:\Users\Luca\Desktop\Server\rp.pwn(15257) : error 001: expected token: ";", but found ":"
C:\Users\Luca\Desktop\Server\rp.pwn(15257) : error 029: invalid expression, assumed zero
C:\Users\Luca\Desktop\Server\rp.pwn(15257) : fatal error 107: too many error messages on one line

Re: OnPlayerTakeDamage - error - Konstantinos - 28.03.2013

Few braces with a different angle.
pawn Code:
public OnPlayerTakeDamage(playerid, issuerid, Float:amount, weaponid)
{

    if(issuerid != INVALID_PLAYER_ID && IsPlayerConnectedEx(issuerid))
    {
        if(tazer_out[issuerid])
        {
            if(GetPlayerWeapon(issuerid) == WEAPON_SILENCED)
            {
                if(GetDistanceBetweenPlayers(issuerid,playerid) < 10.0)
                {
                    TazePlayer(issuerid,playerid);
                }
            }
        }
    }
    if(issuerid != INVALID_PLAYER_ID)
    {
        if(amount > 5.0 && weaponid != 0)
        {
            new Float:armor;
            GetPlayerArmour(playerid,armor);
            if(armor <= 0.0)
            {
                //TextDrawShowForPlayer(playerid,crash_screen);
                //SetTimerEx("HideCrash",250,0,"i",playerid);
                //SetPlayerDrunkLevel(playerid,(GetPlayerDrunkLevel(playerid) + 4000));
            }
        }
    }
    if(issuerid == INVALID_PLAYER_ID) return 1;
    new Float:health,Float:armour;
    GetPlayerHealth(playerid,health);
    GetPlayerArmour(playerid,armour);
    new damage = 0;
    switch(weaponid)
    {
        case 22: damage = 58;
        case 24: damage = 96;
        case 25:
        {
            if(amount < 45) damage = floatround(amount);
            else damage = 100 + floatround(amount);
        }
        case 27:
        {
            if(amount < 35) damage = floatround(amount);
            else damage = 100 + floatround(amount);
        }
        case 28: damage = 16;
        case 29: damage = 26;
        case 30: damage = 49;
        case 31: damage = 44;
        case 32: damage = 16;
        case 33: damage = 59;
        case 34: damage = 341;
        default: damage = floatround(amount);
    }
    return 1;
}


Re: OnPlayerTakeDamage - error - Davman - 28.03.2013

Quote:
Originally Posted by Dwane
View Post
Few braces with a different angle.
pawn Code:
public OnPlayerTakeDamage(playerid, issuerid, Float:amount, weaponid)
{

    if(issuerid != INVALID_PLAYER_ID && IsPlayerConnectedEx(issuerid))
    {
        if(tazer_out[issuerid])
        {
            if(GetPlayerWeapon(issuerid) == WEAPON_SILENCED)
            {
                if(GetDistanceBetweenPlayers(issuerid,playerid) < 10.0)
                {
                    TazePlayer(issuerid,playerid);
                }
            }
        }
    }
    if(issuerid != INVALID_PLAYER_ID)
    {
        if(amount > 5.0 && weaponid != 0)
        {
            new Float:armor;
            GetPlayerArmour(playerid,armor);
            if(armor <= 0.0)
            {
                //TextDrawShowForPlayer(playerid,crash_screen);
                //SetTimerEx("HideCrash",250,0,"i",playerid);
                //SetPlayerDrunkLevel(playerid,(GetPlayerDrunkLevel(playerid) + 4000));
            }
        }
    }
    if(issuerid == INVALID_PLAYER_ID) return 1;
    new Float:health,Float:armour;
    GetPlayerHealth(playerid,health);
    GetPlayerArmour(playerid,armour);
    new damage = 0;
    switch(weaponid)
    {
        case 22: damage = 58;
        case 24: damage = 96;
        case 25:
        {
            if(amount < 45) damage = floatround(amount);
            else damage = 100 + floatround(amount);
        }
        case 27:
        {
            if(amount < 35) damage = floatround(amount);
            else damage = 100 + floatround(amount);
        }
        case 28: damage = 16;
        case 29: damage = 26;
        case 30: damage = 49;
        case 31: damage = 44;
        case 32: damage = 16;
        case 33: damage = 59;
        case 34: damage = 341;
        default: damage = floatround(amount);
    }
    return 1;
}
I've this warning:
PHP Code:
C:\Users\David\Desktop\rp.pwn(15300) : warning 204: symbol is assigned a value that is never used: "damage" 


Re: OnPlayerTakeDamage - error - dannyk0ed - 28.03.2013

Quote:
Originally Posted by Davman
View Post
I've this warning:
PHP Code:
C:\Users\David\Desktop\rp.pwn(15300) : warning 204: symbol is assigned a value that is never used: "damage" 
Because nothing happends after you detect what gun does how much damage..

Re: OnPlayerTakeDamage - error - Konstantinos - 29.03.2013

Quote:
Originally Posted by dannyk0ed
View Post
Because nothing happends after you detect what gun does how much damage..
True.

You set a value to the "damage" variable and then do nothing.
Use it somewhere!

Re: OnPlayerTakeDamage - error - Davman - 29.03.2013

Ah, and how could I do this? Could you post an example? I'm still a beginner with those kind of scripts.

Re: OnPlayerTakeDamage - error - Konstantinos - 29.03.2013

I don't know what do you want to do. Why did you calculate the "damage"? Use it for that!