[Tutorial] How to correct create commands with ZCMD + Sscanf 2.X

[Tutorial] How to correct create commands with ZCMD + Sscanf 2.X - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Tutorials (https://sampforum.blast.hk/forumdisplay.php?fid=70)
+---- Thread: [Tutorial] How to correct create commands with ZCMD + Sscanf 2.X (/showthread.php?tid=405761)

How to correct create commands with ZCMD + Sscanf 2.X - JM_Millers - 07.01.2013

Tutorial by JM_Millers

P.S: I'm Russian, sorry for my bad english

Introduction

Many users of American forum use ZCMD + Sscanf wrong.
I try to show the correct version.

Incorrect use of:

PHP код:



CMD:givemoney(playerid, params[])

{

    new playa, money;

    if(!IsPlayerAdmin(playerid)) return 1;

    if(sscanf(params, "ui", playa, money))

    return SendCientMessage(playerid, -1, "USE: /givemoney [playerid] [amount]");

    GivePlayerMoney(playerid, -money);

    GivePlayerMoney(playa, money);

    return 1;

}

100 commands = over 100 variables = stack Overflow

Correct usage:

PHP код:



CMD:givemoney(playerid, params[])

{

    if(!IsPlayerAdmin(playerid)) return 1;

    if(sscanf(params, "ui", params[0], params[1]))

    return SendCientMessage(playerid, -1, "USE: /givemoney [playerid] [amount]");

    GivePlayerMoney(playerid, -params[1]);

    GivePlayerMoney(params[0], params[1]);

    return 1;

}

Thank you for your attention and sorry for the grammatical errors.

Re: How to correct create commands with ZCMD + Sscanf 2.X - Fabio11 - 07.01.2013

Simple but clear tutorial. By the way, why just admins can givemoney?

Re: How to correct create commands with ZCMD + Sscanf 2.X - JM_Millers - 07.01.2013

Quote:

Originally Posted by Fabio11

Simple but clear tutorial. By the way, why just admins can givemoney?

Thanks, this is just example.

Re: How to correct create commands with ZCMD + Sscanf 2.X - Sanady - 07.01.2013

Lol I didn`t saw something like this before.Is that working perfect without problem?

Re: How to correct create commands with ZCMD + Sscanf 2.X - ThePhenix - 08.01.2013

A mistake here:

Quote:

Originally Posted by JM_Millers

PHP код:



    return SendCientMessage(playerid, -1, "USE: /givemoney [playerid] [amount]");

It's

PHP код:



SendClientMessage(playerid,-1, "USE: /givemoney [playerid] [amount]");

You should remove

PHP код:



GivePlayerMoney(playerid, -params[1]);

Otherwise the command won't work.

Re: How to correct create commands with ZCMD + Sscanf 2.X - JM_Millers - 08.01.2013

Quote:

Originally Posted by ThePhenix

A mistake here:

It's

PHP код:



SendClientMessage(playerid,-1, "USE: /givemoney [playerid] [amount]");

You should remove

PHP код:



GivePlayerMoney(playerid, -params[1]);

Otherwise the command won't work.

No, in my lesson all right

Re: How to correct create commands with ZCMD + Sscanf 2.X - JM_Millers - 08.01.2013

Quote:

Originally Posted by ******

No, the first version is correct, I don't think you understand how a stack works. Two commands will never be called at the same time, so there will never be 100 variables active at once.

In fact, your method has serious security problems when using optional specifiers and an empty "params".

Edit: Also, nothing like this is ever mentioned in the sscanf topic, so I'm not sure why you thought this was the correct way to do it.

PHP код:



CMD:veh(playerid, params[])

{

new heap = heapspace();

if(GetPVarInt(playerid, "Admin") < 3) return SendClientMessage(playerid, white, "["#Red"»"#White"] Вы не администратор 3 LVL");

new Float:Pos[3];

if(sscanf(params,"i", params[0])) return SendClientMessage(playerid, white, "Использовать: /veh [id автомобиля]");

if(GetPlayerPos(playerid, Pos[0], Pos[1], Pos[2]))

{

CreateVehicle(params[0], Pos[0], Pos[1], Pos[2], 90.0, random(128), random(128), 30000);

}

printf("VEH PARAMS STK %d (%d LOSS)", heapspace(), (heap - heapspace()));

return 1;

}


CMD:car(playerid, params[])

{

new heap = heapspace();

new vehicleid;

if(GetPVarInt(playerid, "Admin") < 3) return SendClientMessage(playerid, white, "["#Red"»"#White"] Вы не администратор 3 LVL");

new Float:Pos[3];

if(sscanf(params,"i", vehicleid)) return SendClientMessage(playerid, white, "Использовать: /veh [id автомобиля]");

if(GetPlayerPos(playerid, Pos[0], Pos[1], Pos[2]))

{

CreateVehicle(vehicleid, Pos[0], Pos[1], Pos[2], 90.0, random(128), random(128), 30000);

}

printf("CAR VERIABLE STK %d (%d LOSS)", heapspace(), (heap - heapspace()));

return 1;

}

Код:

[09/01/13 - 17:23:35] VEH PARAMS STK 16076 (16 LOSS)
[09/01/13 - 17:23:42] CAR VERIABLE STK 16104 (20 LOSS)