SA-MP Forums Archive
Pickup bug - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Pickup bug (/showthread.php?tid=398358)


Pickup bug - Louris - 09.12.2012

Код:
public OnPlayerPickUpPickup(playerid, pickupid)
{
    if(PlayerInfo[playerid][pLvDovana] == 0)
    {
        if(pickupid == dovana) GivePlayerMoney(playerid,1000);
        SendClientMessage(playerid, 0xDEEE20FF, "Sveikiname, prizas: 1000 LT.");
        PlayerInfo[playerid][pLvDovana] = true;
    }
    else
    {
        SendClientMessage(playerid, 0xDEEE20FF, "Jūs jau gavote priza!");
}

       if(PlayerInfo[playerid][pVip] == 1)
    {
        if(pickupid == vipams) GivePlayerWeapon(playerid, 31, 500);
        GivePlayerWeapon(playerid, 25, 500);
        SendClientMessage(playerid, 0xDEEE20FF, "Gavote VIP ginklus.");
    }
    else
    {
    SendClientMessage(playerid, 0xDEEE20FF, "Jūs ne VIP");
    }
    return 1;
}
When player pick up this pickup:
if(pickupid == vipams)

he get two messages:
SendClientMessage(playerid, 0xDEEE20FF, "Jūs jau gavote priza!");

SendClientMessage(playerid, 0xDEEE20FF, "Gavote VIP ginklus.");

Re: Pickup bug - [HK]Ryder[AN] - 09.12.2012

can you show us the code where you create those pickups?

Re: Pickup bug - Louris - 09.12.2012

Problem not in pickups create..

dovana = CreateDynamicPickup(19056, 2, 1326.5134,1365.1432,54);
vipams = CreateDynamicPickup(2969, 2, 2013.8668,2674.0786,11);

Re: Pickup bug - Lordzy - 09.12.2012

Well try this:
pawn Код:
public OnPlayerPickUpPickup(playerid, pickupid)
{
 if(PlayerInfo[playerid][pLvDovana] == 0)
 {
  if(pickupid == dovana)
  {  
    GivePlayerMoney(playerid,1000);
    SendClientMessage(playerid, 0xDEEE20FF, "Sveikiname, prizas: 1000 LT.");
    PlayerInfo[playerid][pLvDovana] = true;
  }
 }
 else   
 {
  SendClientMessage(playerid, 0xDEEE20FF, "Jūs jau gavote priza!");
 }
 if(PlayerInfo[playerid][pVip] == 1)
 {
   if(pickupid == vipams)
   {
    GivePlayerWeapon(playerid, 31, 500);
    GivePlayerWeapon(playerid, 25, 500);
    SendClientMessage(playerid, 0xDEEE20FF, "Gavote VIP ginklus.");
    }
 }
 else
 {
    SendClientMessage(playerid, 0xDEEE20FF, "Jūs ne VIP");
 }
 return 1;
}


Re: Pickup bug - Louris - 09.12.2012

I must have this message:
SendClientMessage(playerid, 0xDEEE20FF, "Gavote VIP ginklus.");

but i got this: SendClientMessage(playerid, 0xDEEE20FF, "Jūs jau gavote priza!");

With your code.

Re: Pickup bug - [HK]Ryder[AN] - 09.12.2012

it could be because your PlayerInfo[playerid][pLvDovana] is not 0

Re: Pickup bug - Louris - 09.12.2012

Quote:
Originally Posted by [HK]Ryder[AN]
Посмотреть сообщение
it could be because your PlayerInfo[playerid][pLvDovana] is not 0
PlayerInfo[playerid][pLvDovana] = true;

Re: Pickup bug - Louris - 09.12.2012

Any ideas?

Re: Pickup bug - [HK]Ryder[AN] - 09.12.2012

Quote:
Originally Posted by Louris
Посмотреть сообщение
PlayerInfo[playerid][pLvDovana] = true;
Do not post such huge stuff.

and btw THAT IS WHAT I AM SAYING

True = 1
False = 0
in the code it is checking if it is 0 (WHICH IS FALSE), then it executes the code or it sends the message you are getting..

to fix it use this
pawn Код:
public OnPlayerPickUpPickup(playerid, pickupid)
{
 if(PlayerInfo[playerid][pLvDovana] == true)
 {
  if(pickupid == dovana)
  {  
    GivePlayerMoney(playerid,1000);
    SendClientMessage(playerid, 0xDEEE20FF, "Sveikiname, prizas: 1000 LT.");
    PlayerInfo[playerid][pLvDovana] = true;
  }
 }
 else   
 {
  SendClientMessage(playerid, 0xDEEE20FF, "Jūs jau gavote priza!");
 }
 if(PlayerInfo[playerid][pVip] == 1)
 {
   if(pickupid == vipams)
   {
    GivePlayerWeapon(playerid, 31, 500);
    GivePlayerWeapon(playerid, 25, 500);
    SendClientMessage(playerid, 0xDEEE20FF, "Gavote VIP ginklus.");
    }
 }
 else
 {
    SendClientMessage(playerid, 0xDEEE20FF, "Jūs ne VIP");
 }
 return 1;
}
and PLEASE follow Lord's signature..maybe it can help control your temper

Quote:
Originally Posted by ******
Посмотреть сообщение
There are ways to highlight issues with includes and suggest improvements, and there are ways to just be mean to people. If you don't know the difference - don't reply, you'll just put people off posting who may turn out to be great coders!


Re: Pickup bug - Threshold - 09.12.2012

See how you're setting it to true, that means you're setting it to 1, and once it reaches the else statement, it is already set to 1, so it will also send that message. You need to use an else if statement here.

pawn Код:
public OnPlayerPickUpPickup(playerid, pickupid)
{
    if(PlayerInfo[playerid][pLvDovana] == 0)
    {
        if(pickupid == dovana) GivePlayerMoney(playerid,1000);
        SendClientMessage(playerid, 0xDEEE20FF, "Sveikiname, prizas: 1000 LT.");
        PlayerInfo[playerid][pLvDovana] = true;
    }
    else if(PlayerInfo[playerid][pLvDovana] == true)
    {
        SendClientMessage(playerid, 0xDEEE20FF, "Jūs jau gavote priza!");
}

       if(PlayerInfo[playerid][pVip] == 1)
    {
        if(pickupid == vipams) GivePlayerWeapon(playerid, 31, 500);
        GivePlayerWeapon(playerid, 25, 500);
        SendClientMessage(playerid, 0xDEEE20FF, "Gavote VIP ginklus.");
    }
    else
    {
    SendClientMessage(playerid, 0xDEEE20FF, "Jūs ne VIP");
    }
    return 1;
}