Whats wrong with this command?

Whats wrong with this command? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Whats wrong with this command? (/showthread.php?tid=397766)

Whats wrong with this command? - [CG]Milito - 06.12.2012

Hello!

This command is kinda bugged, it removes the object but i sends 10 messages saying the same
"[_Christmas_] %s(%d) has removed his santa hat. He doesn't like christmas"

PHP код:



    if(strcmp("/remao", cmdtext, true,10)== 0) // Remove Attached Objects

    {

        for(new i=0; i<MAX_PLAYER_ATTACHED_OBJECTS; i++)

        {

            if(IsPlayerAttachedObjectSlotUsed(playerid, 1)) RemovePlayerAttachedObject(playerid, 1);

            new pname[24];

            new string[128];

            GetPlayerName(playerid,pname,sizeof(pname));

            format(string,sizeof(string),"[_Christmas_] %s(%d) has removed his santa hat. He doesn't like christmas",pname,playerid);

            SendClientMessageToAll(COLOR_CYAN,string);

         }

        return 1;

    }

Thanks in advance

Re: Whats wrong with this command? - Babul - 06.12.2012

you forgot to create a { } block for more commands being executed in the if-statement:

Код:

	if(strcmp("/remao", cmdtext, true,10)== 0) // Remove Attached Objects
	{
		for(new i=0; i<MAX_PLAYER_ATTACHED_OBJECTS; i++)
		{
			if(IsPlayerAttachedObjectSlotUsed(playerid, i))
			{
				RemovePlayerAttachedObject(playerid, i);
				new pname[24];
				new string[128];
				GetPlayerName(playerid,pname,sizeof(pname));
				format(string,sizeof(string),"[_Christmas_] %s(%d) has removed his santa hat. He doesn't like christmas",pname,playerid);
				SendClientMessageToAll(COLOR_CYAN,string);
			}
		}
		return 1;
	}

but now, the (playerid,1) will get checked 10 times. isnt it supposed to be a (playerid,i) ? fixed it tho. idk if it works, just give it a try and tell us, if there are more bugs like only 1, not 2 attached objects being removed... or maybe all objects disappear, even if its not a santa hat? the script checks IF the object is used, not which one, but youll enhance that hehe

Respuesta: Re: Whats wrong with this command? - [CG]Milito - 06.12.2012

Quote:

Originally Posted by Babul

you forgot to create a { } block for more commands being executed in the if-statement:

Код:

	if(strcmp("/remao", cmdtext, true,10)== 0) // Remove Attached Objects
	{
		for(new i=0; i<MAX_PLAYER_ATTACHED_OBJECTS; i++)
		{
			if(IsPlayerAttachedObjectSlotUsed(playerid, i))
			{
				RemovePlayerAttachedObject(playerid, i);
				new pname[24];
				new string[128];
				GetPlayerName(playerid,pname,sizeof(pname));
				format(string,sizeof(string),"[_Christmas_] %s(%d) has removed his santa hat. He doesn't like christmas",pname,playerid);
				SendClientMessageToAll(COLOR_CYAN,string);
			}
		}
		return 1;
	}

Oh Thanks dude, i mean your code is working correctly!
+rep