SA-MP Forums Archive
What is wrong in this code? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: What is wrong in this code? (/showthread.php?tid=386626)


What is wrong in this code? - Gamer_007 - 21.10.2012

Guys here is my antihack script.Now see wht is wrong in it.
PHP код:
//Antihack
#include <a_samp>
#define COLOR_YELLOW "{FFFF00}"
new Text:banmessage;
new dm[MAX_PLAYERS];
public OnFilterScriptInit()
{
    printf("Anti Minigun By [A]Gamer_007 is loading now");
    printf("Anti Minigun By [A]Gamer_007 loaded");
    printf("NO WEAPON HACKS IN YOUR SERVER.ENJOY");
    banmessage = TextDrawCreate(190,200,"~r~Nice Hacks but Here they are not allowed.~n~~y~You are banned from this server.");
    TextDrawFont(banmessage, 2);
    TextDrawLetterSize(banmessage, 0.6, 1.0);
    TextDrawSetShadow(banmessage, 0);
    TextDrawSetOutline(banmessage, 1);
    return 1;
}
stock PlayerName(playerid)
{
    new name[MAX_PLAYER_NAME];
    GetPlayerName(playerid, name, sizeof(name));
    return name;
}
CMD:dm(playerid,parms[])
{
 dm(playerid) = 1;//set a palyer dm value to 1
 //My tele co ordinate here
 return 1;
 }
public OnPlayerUpdate(playerid)
{
   if(dm(playerid) == 1){
   return 1;
   }
   else
   {
   new string[128],Weapon,Ammo;
   GetPlayerWeaponData(playerid, 7, Weapon,Ammo);
   if(Weapon == 38 && !IsPlayerAdmin(playerid)) {
   format(string,128,"{FF0000}%s[%d] Has Been Banned From Server.[Reason: Minigun Hack]",PlayerName(playerid),playerid);
   SendClientMessageToAll(0xFF0000AA,string);
   TextDrawShowForPlayer(playerid, banmessage);
   Ban(playerid);
   }
   if(Weapon == 36 && !IsPlayerAdmin(playerid)) {
   format(string,128,"{FF0000}%s[%d] Has Been Banned From Server.[Reason: Heat Saker Hack]",PlayerName(playerid),playerid);
   SendClientMessageToAll(0xFF0000AA,string);
   TextDrawShowForPlayer(playerid, banmessage);
   Ban(playerid);
   }
   if(Weapon == 35 && !IsPlayerAdmin(playerid)) {
   format(string,128,"{FF0000}%s[%d] Has Been Banned From Server.[Reason: Rocket Launcher Hack]",PlayerName(playerid),playerid);
   SendClientMessageToAll(0xFF0000AA,string);
   TextDrawShowForPlayer(playerid, banmessage);
   Ban(playerid);
   }
   return 1;
} 


Re: What is wrong in this code? - JaKe Elite - 21.10.2012

Why are you using OnPlayerUpdate?

Use a timer. OnPlayerUpdate is worst thing callback to use for Anti-Cheats.

Anyway what's the problem?

Re: What is wrong in this code? - newbienoob - 21.10.2012

1) Change dm(playerid) to dm[playerid]
2) Under OnPlayerUpdate
new Weapon = GetPlayerWeapon(playerid);
and of course, remove "Weapon" and "Ammo".

Re: What is wrong in this code? - Gamer_007 - 21.10.2012

Quote:

C:\Users\DEVILS\Desktop\tri.pwn(2 : error 021: symbol already defined: "dm"
C:\Users\DEVILS\Desktop\tri.pwn(2 : error 021: symbol already defined: "dm"
C:\Users\DEVILS\Desktop\tri.pwn(31) : error 010: invalid function or declaration
C:\Users\DEVILS\Desktop\tri.pwn(35) : error 012: invalid function call, not a valid address
C:\Users\DEVILS\Desktop\tri.pwn(35) : warning 215: expression has no effect
C:\Users\DEVILS\Desktop\tri.pwn(35) : error 001: expected token: ";", but found ")"
C:\Users\DEVILS\Desktop\tri.pwn(35) : error 029: invalid expression, assumed zero
C:\Users\DEVILS\Desktop\tri.pwn(35) : fatal error 107: too many error messages on one line

Compilation aborted.Pawn compiler 3.2.3664 Copyright © 1997-2006, ITB CompuPhase


6 Errors.
6 Errors.

Re: What is wrong in this code? - Gamer_007 - 21.10.2012

3 errors
Quote:

C:\Users\DEVILS\Desktop\tri.pwn(2 : error 021: symbol already defined: "dm"
C:\Users\DEVILS\Desktop\tri.pwn(31) : error 010: invalid function or declaration
C:\Users\DEVILS\Desktop\tri.pwn(6 : error 030: compound statement not closed at the end of file (started at line 35)
Pawn compiler 3.2.3664 Copyright © 1997-2006, ITB CompuPhase


3 Errors.


Re: What is wrong in this code? - newbienoob - 21.10.2012

Now change CMD:dm(playerid,parms[]) to CMD:dm1(playerid,parms[])

Re: What is wrong in this code? - Gamer_007 - 21.10.2012

C:\Users\DEVILS\Desktop\tri.pwn(69) : warning 203: symbol is never used: "dm1"
Pawn compiler 3.2.3664 Copyright © 1997-2006, ITB CompuPhase


1 Warning.

on changing dm to dm1

Re: What is wrong in this code? - cessil - 21.10.2012

http://forum.sa-mp.com/showthread.ph...rrors+warnings

You're probably getting the error 21 because you have a variable named the same as the command.


Romel, OPU is a great callback to use in an anti cheat, read my thread about anti-cheat tips for more info
Quote:
Originally Posted by Romel
Посмотреть сообщение
Use a timer. OnPlayerUpdate is worst thing callback to use for Anti-Cheats.


Re: What is wrong in this code? - newbienoob - 21.10.2012

Make sure you have #include <zcmd> at the top.

Re: What is wrong in this code? - JaKe Elite - 21.10.2012

PHP код:
#include <zcmd>