Small help - Printable Version

Small help - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Small help (/showthread.php?tid=385289)

Small help - Face9000 - 15.10.2012

Hello,i got this score check for every vehicles, means if you dont have the required score, you can't drive a certain vehicle.It works but there is a problem, even if i have the required score, it keeps saying "You need XX score etc" but i can drive it.

Any tip?

pawn Код:

public OnPlayerStateChange(playerid, newstate, oldstate)
{
    new vehicleid = GetPlayerVehicleID(playerid);
    if(GetVehicleModel(vehicleid) == 520) //Hydra
    {
        if(GetPlayerScore(playerid) <= 1500) RemovePlayerFromVehicle(playerid);
        SendClientMessage(playerid,0xAA3333AA,"You need 1500 score to drive this Hydra.");
        return 1;
    }
    
    if(GetVehicleModel(vehicleid) == 432) //Rhino
    {
        if(GetPlayerScore(playerid) <= 300) RemovePlayerFromVehicle(playerid);
        SendClientMessage(playerid,0xAA3333AA,"You need 300 score to drive this Rhino.");
        return 1;
    }
    
    if(GetVehicleModel(vehicleid) == 425) //Hunter
    {
        if(GetPlayerScore(playerid) <= 1000) RemovePlayerFromVehicle(playerid);
        SendClientMessage(playerid,0xAA3333AA,"You need 1000 score to drive this Hunter.");
        return 1;
    }
    else return 1;
}

Re: Small help - JaKe Elite - 15.10.2012

I'm not sure but, maybe it is because you didn't call the return.

Return always stops the rest of the code (Below).

try doing this

PHP код:



if(GetPlayerScore(playerid) >= YourScore)
{

}
else
{

}

Re: Small help - Face9000 - 15.10.2012

Umh nothing, still the same.

Re: Small help - Babul - 15.10.2012

nah, you simply forgot to place some {} braces:

Код:

public OnPlayerStateChange(playerid, newstate, oldstate)
{
	new vehicleid = GetPlayerVehicleID(playerid);
	if(GetVehicleModel(vehicleid) == 520) //Hydra
	{
		if(GetPlayerScore(playerid) < 1500)
		{
			RemovePlayerFromVehicle(playerid);
			SendClientMessage(playerid,0xAA3333AA,"You need 1500 score to drive this Hydra.");
			return 1;
		}
	}
	if(GetVehicleModel(vehicleid) == 432) //Rhino
	{
		if(GetPlayerScore(playerid) < 300) 
		{
			RemovePlayerFromVehicle(playerid);
			SendClientMessage(playerid,0xAA3333AA,"You need 300 score to drive this Rhino.");
			return 1;
		}
	}
	if(GetVehicleModel(vehicleid) == 425) //Hunter
	{
		if(GetPlayerScore(playerid) < 1000)
		{
			RemovePlayerFromVehicle(playerid);
			SendClientMessage(playerid,0xAA3333AA,"You need 1000 score to drive this Hunter.");
			return 1;
		}
	}
	return 1;
}

edit: oops, now i changed the <= to just < so the score check wont remove a player at the certain score to drive/fly.

Re: Small help - Face9000 - 15.10.2012

Quote:

Originally Posted by Babul

nah, you simply forgot to place some {} braces:

Код:

public OnPlayerStateChange(playerid, newstate, oldstate)
{
	new vehicleid = GetPlayerVehicleID(playerid);
	if(GetVehicleModel(vehicleid) == 520) //Hydra
	{
		if(GetPlayerScore(playerid) < 1500)
		{
			RemovePlayerFromVehicle(playerid);
			SendClientMessage(playerid,0xAA3333AA,"You need 1500 score to drive this Hydra.");
			return 1;
		}
	}
	if(GetVehicleModel(vehicleid) == 432) //Rhino
	{
		if(GetPlayerScore(playerid) < 300) 
		{
			RemovePlayerFromVehicle(playerid);
			SendClientMessage(playerid,0xAA3333AA,"You need 300 score to drive this Rhino.");
			return 1;
		}
	}
	if(GetVehicleModel(vehicleid) == 425) //Hunter
	{
		if(GetPlayerScore(playerid) < 1000)
		{
			RemovePlayerFromVehicle(playerid);
			SendClientMessage(playerid,0xAA3333AA,"You need 1000 score to drive this Hunter.");
			return 1;
		}
	}
	return 1;
}

Aaaaand it works, thank you

edit: oops, now i changed the <= to just < so the score check wont remove a player at the certain score to drive/fly.

Quote:

Originally Posted by ******

THIS is EXACTLY the reason why we tell people to ALWAYS use braces and ALWAYS use proper indentation and proper new lines. While your code in the first post is technically valid, using good practice can reduce bugs.

Yeah, my mistake while adding braces.