/Engine and /Lights not working?

/Engine and /Lights not working? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: /Engine and /Lights not working? (/showthread.php?tid=382911)

/Engine and /Lights not working? - jeremy8810 - 05.10.2012

Hi guys,

Got two commands that are not working, I dont have any errors in my GM, so I dont know why they are not working...

Plz let me know here is the code:

pawn Код:

CMD:engine(playerid,params[])
{
    new engine,lights,alarm,doors,bonnet,boot,objective,vehicleid;
    vehicleid = GetPlayerVehicleID(playerid);
    if(!IsPlayerInAnyVehicle(playerid)) return SendClientMessage(playerid,-1,"ERROR:Your must be in a vehicle.");
    if(GetPlayerVehicleSeat(playerid) == 0)
    {
        GetVehicleParamsEx(vehicleid,engine,lights,alarm,doors,bonnet,boot,objective);
        if(engine == 0)
        {
            SetVehicleParamsEx(vehicleid,true,lights,alarm,doors,bonnet,boot,objective);
            GameTextForPlayer(playerid,"~g~Engine started",3000,1);
        }
        else if(engine == 1)
        {
            SetVehicleParamsEx(vehicleid,false,lights,alarm,doors,bonnet,boot,objective);
            GameTextForPlayer(playerid,"~r~Engine stopped",3000,1);
        }
    }
    return 1;
}

CMD:lights(playerid,params[])
{
    new engine,lights,alarm,doors,bonnet,boot,objective,vehicleid;
    vehicleid = GetPlayerVehicleID(playerid);
    if(!IsPlayerInAnyVehicle(playerid)) return SendClientMessage(playerid,-1,"ERROR:Your must be in a vehicle.");
    if(GetPlayerVehicleSeat(playerid) == 0)
    {
        GetVehicleParamsEx(vehicleid,engine,lights,alarm,doors,bonnet,boot,objective);
        if(lights == 0)
        {
            SetVehicleParamsEx(vehicleid,engine,true,alarm,doors,bonnet,boot,objective);
            GameTextForPlayer(playerid,"~g~Lights on",3000,1);
        }
        else if(lights == 1)
        {
            SetVehicleParamsEx(vehicleid,engine,false,alarm,doors,bonnet,boot,objective);
            GameTextForPlayer(playerid,"~r~Lights off",3000,1);
        }
    }
    return 1;
}

Thnx,

Jer

Re: /Engine and /Lights not working? - Dizzle - 05.10.2012

Try this -

Код:

CMD:engine(playerid,params[])
{
    new engine,lights,alarm,doors,bonnet,boot,objective,vehicleid;
    vehicleid = GetPlayerVehicleID(playerid);
    if(!IsPlayerInAnyVehicle(playerid)) return SendClientMessage(playerid,-1,"ERROR:Your must be in a vehicle.");
    if(GetPlayerVehicleSeat(playerid) == 0)
    {
        GetVehicleParamsEx(vehicleid,engine,lights,alarm,doors,bonnet,boot,objective);
        if(engine == 0)
        {
            SetVehicleParamsEx(vehicleid,VEHICLE_PARAMS_ON,lights,alarm,doors,bonnet,boot,objective);
            GameTextForPlayer(playerid,"~g~Engine started",3000,1);
        }
        else if(engine == 1)
        {
            SetVehicleParamsEx(vehicleid,VEHICLE_PARAMS_OFF,lights,alarm,doors,bonnet,boot,objective);
            GameTextForPlayer(playerid,"~r~Engine stopped",3000,1);
        }
    }
    return 1;
}

CMD:lights(playerid,params[])
{
    new engine,lights,alarm,doors,bonnet,boot,objective,vehicleid;
    vehicleid = GetPlayerVehicleID(playerid);
    if(!IsPlayerInAnyVehicle(playerid)) return SendClientMessage(playerid,-1,"ERROR:Your must be in a vehicle.");
    if(GetPlayerVehicleSeat(playerid) == 0)
    {
        GetVehicleParamsEx(vehicleid,engine,VEHICLE_PARAMS_ON,alarm,doors,bonnet,boot,objective);
        if(lights == 0)
        {
            SetVehicleParamsEx(vehicleid,engine,true,alarm,doors,bonnet,boot,objective);
            GameTextForPlayer(playerid,"~g~Lights on",3000,1);
        }
        else if(lights == 1)
        {
            SetVehicleParamsEx(vehicleid,engine,VEHICLE_PARAMS_OFF,alarm,doors,bonnet,boot,objective);
            GameTextForPlayer(playerid,"~r~Lights off",3000,1);
        }
    }
    return 1;
}

EDIT: Try it now, I made it wrong the first time.

Re: /Engine and /Lights not working? - tsonn1 - 05.10.2012

The thing is, that u don't tell the script to set the lights and engine to 1 if u turn em on and also the SetVehParamsEx is a little bit wrong. It should be VEHICLE_PARAMS_ON or VEHICLE_PARAMS_OFF.

Here's the right script:

pawn Код:

CMD:engine(playerid,params[])
{
    new engine,lights,alarm,doors,bonnet,boot,objective,vehicleid;
    vehicleid = GetPlayerVehicleID(playerid);
    if(!IsPlayerInAnyVehicle(playerid)) return SendClientMessage(playerid,-1,"ERROR:Your must be in a vehicle.");
    if(GetPlayerVehicleSeat(playerid) == 0)
    {
        if(engine = 0)
        {
            GetVehicleParamsEx(vehicleid,engine,lights,alarm,doors,bonnet,boot,objective);
            SetVehicleParamsEx(vehicleid,VEHICLE_PARAMS_ON,lights,alarm,doors,bonnet,boot,objective);
            engine = 1;
            GameTextForPlayer(playerid,"~g~Engine started",3000,1);
        }
        else if(engine == 1)
        {
            GetVehicleParamsEx(vehicleid,engine,lights,alarm,doors,bonnet,boot,objective);
            SetVehicleParamsEx(vehicleid,VEHICLE_PARAMS_OFF,lights,alarm,doors,bonnet,boot,objective);
            engine = 0;
            GameTextForPlayer(playerid,"~r~Engine stopped",3000,1);
        }
    }
    return 1;
}

CMD:lights(playerid,params[])
{
    new engine,lights,alarm,doors,bonnet,boot,objective,vehicleid;
    vehicleid = GetPlayerVehicleID(playerid);
    if(!IsPlayerInAnyVehicle(playerid)) return SendClientMessage(playerid,-1,"ERROR:Your must be in a vehicle.");
    if(GetPlayerVehicleSeat(playerid) == 0)
    {
        if(lights == 0)
        {
            GetVehicleParamsEx(vehicleid,engine,lights,alarm,doors,bonnet,boot,objective);
            SetVehicleParamsEx(vehicleid,engine,VEHICLE_PARAMS_ON,alarm,doors,bonnet,boot,objective);
            lights = 1;
            GameTextForPlayer(playerid,"~g~Lights on",3000,1);
        }
        else if(lights == 1)
        {
            GetVehicleParamsEx(vehicleid,engine,lights,alarm,doors,bonnet,boot,objective);
            SetVehicleParamsEx(vehicleid,engine,VEHICLE_PARAMS_OFF,alarm,doors,bonnet,boot,objective);
            lights = 0;
            GameTextForPlayer(playerid,"~r~Lights off",3000,1);
        }
    }
    return 1;
}

Re: /Engine and /Lights not working? - jeremy8810 - 06.10.2012

Okey its working half, cause when I do /engine or /lights when they are on (engine is on and lights are on) they are not shutting off...

but that is because he dont know if the engine is 1 or 0... cause you are not getting the vehicle vehicleparams before...