Admin/VIP chat bugged. - Printable Version

Admin/VIP chat bugged. - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Admin/VIP chat bugged. (/showthread.php?tid=379539)

Admin/VIP chat bugged. - Ronaldo_raul™ - 22.09.2012

I am making admin and vip chat. Everything seems perfect but I don't know but they are bugged. What actually happens is -

For example, If I do -

Код:

#AdminChatTest


// So the text "AdminChatTest" should be send to all admins and not to the main chat.
// But When I type any text with # it is send to both the admin chat and the main chat.

Here is my code -

pawn Код:

public OnPlayerText(playerid, text[])
{
    if ( Muted [ playerid ] == 1 )
    {
        format ( SStr , 128 , "You've been muted from the chat" ) ;
        SendClientMessage ( playerid , -1 , SStr ) ;
        return 0 ;
    }

    
    if ( ( text [ 0 ] == '*' ) && PlayerData [ playerid ] [ VIPLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "|ChatVip| %s(%d): %s" , pName ( playerid ) , playerid , text [ 1 ] ) ;
        MessageToPlayerVIP ( -1 , SStr ) ;
        SaveLog ( "VIPChatLog" , SStr ) ;
        return 0 ;
    }
    
    if ( ( text [ 0 ] == '#' ) && PlayerData [ playerid ] [ AdmLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "Admin Chat: %s: %s" , pName ( playerid ) , text [ 1 ] ) ;
        MessageToAdmins ( green , SStr ) ;
        SaveLog ( "AdmChatLog" , SStr ) ;
        return 0 ;
    }
    SaveChatLog ( playerid , "ChatLogs" , text ) ;
    return 1 ;
}

I can't figure out the problem.

Re: Admin/VIP chat bugged. - clarencecuzz - 22.09.2012

Can you show us your MessageToAdmins and MessageToPlayerVIP functions?

Re: Admin/VIP chat bugged. - Ronaldo_raul™ - 22.09.2012

Quote:

Originally Posted by clarencecuzz

Can you show us your MessageToAdmins and MessageToPlayerVIP functions?

Sure, here -

pawn Код:

forward MessageToAdmins ( color , const string[] ) ;
public MessageToAdmins ( color , const string[] )
{
    foreach (new i : Player)
    {
        if ( IsPlayerConnected ( i ) == 1 && PlayerData [ i ][ AdmLvl ] >= 1 )
        {
            SendClientMessage ( i , color , string ) ;
        }
    }
    return 1;
}



forward MessageToPlayerVIP ( color , const string[] ) ;
public MessageToPlayerVIP ( color , const string[] )
{
    foreach (new i : Player)
    {
        if ( IsPlayerConnected ( i ) == 1 && PlayerData [ i ] [ VIPLvl ] >= 1 )
        {
            SendClientMessage ( i , color , string ) ;
        }
    }
    return 1;
}

Re: Admin/VIP chat bugged. - clarencecuzz - 22.09.2012

Try this:

pawn Код:

public OnPlayerText(playerid, text[])
{
    if ( Muted [ playerid ] == 1 ) return SendClientMessage ( playerid , -1 , "You've been muted from the chat." ) ;

    if ( ( text [ 0 ] == '*' ) && PlayerData [ playerid ] [ VIPLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "|ChatVip| %s(%d): %s" , pName ( playerid ) , playerid , text [ 1 ] ) ;
        MessageToPlayerVIP ( -1 , SStr ) ;
        SaveLog ( "VIPChatLog" , SStr ) ;
        return 0 ;
    }

    if ( ( text [ 0 ] == '#' ) && PlayerData [ playerid ] [ AdmLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "Admin Chat: %s: %s" , pName ( playerid ) , text [ 1 ] ) ;
        MessageToAdmins ( green , SStr ) ;
        SaveLog ( "AdmChatLog" , SStr ) ;
        return 0 ;
    }
    
    if(text[0] != '#' && text[0] != '*')
    {
        SendPlayerMessageToAll(playerid, text);
    }
    SaveChatLog ( playerid , "ChatLogs" , text ) ;
    return 0 ;
}

forward MessageToAdmins ( color , const string[] ) ;
public MessageToAdmins ( color , const string[] )
{
    foreach (new i : Player)
    {
        if(IsPlayerConnected(i))
        {
            if(PlayerData[ i ][ AdmLvl ] >= 1 )
            {
                SendClientMessage ( i , color , string ) ;
            }
        }
    }
    return 0;
}

forward MessageToPlayerVIP(color,const string[]);
public MessageToPlayerVIP(color,const string[])
{
    foreach(Player, i)
    {
        if(IsPlayerConnected(i))
        {
            if(PlayerData[i][VIPLvl] >= 1)
            {
                SendClientMessage ( i , color , string );
            }
        }
    }
    return 0;
}

If that does not work, try searching any other filterscripts or gamemodes you are using, and remove any code under OnPlayerText that might affect this outcome.

Re: Admin/VIP chat bugged. - Lordzy - 22.09.2012

Try using this stock as MessageToAdmins and try.

pawn Код:

stock MessageToAdmins(color, const message[])
{
    for(new i; i<MAX_PLAYERS; i++) if(IsPlayerConnected(i) && PlayerData[playerid][AdmLvl] >=1(i))
    {
        SendClientMessage(i, color, message);
    }
    return 1;
}

If working, use like this for VIP chat function also.

Re: Admin/VIP chat bugged. - Ronaldo_raul™ - 22.09.2012

Quote:

Originally Posted by clarencecuzz

Try this:

pawn Код:

public OnPlayerText(playerid, text[])
{
    if ( Muted [ playerid ] == 1 ) return SendClientMessage ( playerid , -1 , "You've been muted from the chat." ) ;

    if ( ( text [ 0 ] == '*' ) && PlayerData [ playerid ] [ VIPLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "|ChatVip| %s(%d): %s" , pName ( playerid ) , playerid , text [ 1 ] ) ;
        MessageToPlayerVIP ( -1 , SStr ) ;
        SaveLog ( "VIPChatLog" , SStr ) ;
        return 0 ;
    }

    if ( ( text [ 0 ] == '#' ) && PlayerData [ playerid ] [ AdmLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "Admin Chat: %s: %s" , pName ( playerid ) , text [ 1 ] ) ;
        MessageToAdmins ( green , SStr ) ;
        SaveLog ( "AdmChatLog" , SStr ) ;
        return 0 ;
    }
    
    if(text[0] != '#' && text[0] != '*')
    {
        SendPlayerMessageToAll(playerid, text);
    }
    SaveChatLog ( playerid , "ChatLogs" , text ) ;
    return 0 ;
}

forward MessageToAdmins ( color , const string[] ) ;
public MessageToAdmins ( color , const string[] )
{
    foreach (new i : Player)
    {
        if(IsPlayerConnected(i))
        {
            if(PlayerData[ i ][ AdmLvl ] >= 1 )
            {
                SendClientMessage ( i , color , string ) ;
            }
        }
    }
    return 0;
}

forward MessageToPlayerVIP(color,const string[]);
public MessageToPlayerVIP(color,const string[])
{
    foreach(Player, i)
    {
        if(IsPlayerConnected(i))
        {
            if(PlayerData[i][VIPLvl] >= 1)
            {
                SendClientMessage ( i , color , string );
            }
        }
    }
    return 0;
}

If that does not work, try searching any other filterscripts or gamemodes you are using, and remove any code under OnPlayerText that might affect this outcome.

I also tried without loading any filterscripts.

Quote:

Originally Posted by [xB]Lordz

Try using this stock as MessageToAdmins and try.

pawn Код:

stock MessageToAdmins(color, const message[])
{
    for(new i; i<MAX_PLAYERS; i++) if(IsPlayerConnected(i) && PlayerData[playerid][AdmLvl] >=1(i))
    {
        SendClientMessage(i, color, message);
    }
    return 1;
}

If working, use like this for VIP chat function also.

@Lordz, not working.

Unfortunately, none. HELP!

Re: Admin/VIP chat bugged. - XtremeR - 22.09.2012

try this :

pawn Код:

stock MessageToAdmins(color, const message[])
{
    for(new i = 0; i < MAX_PLAYERS; i++)
    {
    if PlayerData[playerid][AdmLvl] >=1 ) SendClientMessage(i, color, string);
    }
    return 1;
}

Works Perfect for me..

Re: Admin/VIP chat bugged. - IstuntmanI - 22.09.2012

You don't have why to check IsPlayerConnected in a foreach loop, remove this check, foreach is doing this for you.

This is all of your OnPlayerText code ?

Re: Admin/VIP chat bugged. - HuSs3n - 22.09.2012

Afaik , OnPlayerText Must return 0, or the text will be sent twice.

pawn Код:

public OnPlayerText(playerid, text[])
{
    if ( Muted [ playerid ] == 1 )
    {
        format ( SStr , 128 , "You've been muted from the chat" ) ;
        SendClientMessage ( playerid , -1 , SStr ) ;
        return 0 ;
    }

    
    if ( ( text [ 0 ] == '*' ) && PlayerData [ playerid ] [ VIPLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "|ChatVip| %s(%d): %s" , pName ( playerid ) , playerid , text [ 1 ] ) ;
        MessageToPlayerVIP ( -1 , SStr ) ;
        SaveLog ( "VIPChatLog" , SStr ) ;
        return 0 ;
    }
    
    if ( ( text [ 0 ] == '#' ) && PlayerData [ playerid ] [ AdmLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "Admin Chat: %s: %s" , pName ( playerid ) , text [ 1 ] ) ;
        MessageToAdmins ( green , SStr ) ;
        SaveLog ( "AdmChatLog" , SStr ) ;
        return 0 ;
    }
    else
    {
       SendPlayerMessageToAll(playerid, text);
    }
    SaveChatLog ( playerid , "ChatLogs" , text ) ;
    return 0 ;
}

Re: Admin/VIP chat bugged. - Ronaldo_raul™ - 23.09.2012

Quote:

Originally Posted by XtremeR

try this :

pawn Код:

stock MessageToAdmins(color, const message[])
{
    for(new i = 0; i < MAX_PLAYERS; i++)
    {
    if PlayerData[playerid][AdmLvl] >=1 ) SendClientMessage(i, color, string);
    }
    return 1;
}

Works Perfect for me..

pawn Код:

C:\Users\Vyom\Desktop\SA-MP 3e\gamemodes\StuntWars.pwn(3326) : error 001: expected token: "*then", but found ")"
C:\Users\Vyom\Desktop\SA-MP 3e\gamemodes\StuntWars.pwn(3326) : error 029: invalid expression, assumed zero
Pawn compiler 3.2.3664          Copyright (c) 1997-2006, ITB CompuPhase


2 Errors.

And as you're looping the playerid should be "i"

Quote:

Originally Posted by costel_nistor96

You don't have why to check IsPlayerConnected in a foreach loop, remove this check, foreach is doing this for you.

This is all of your OnPlayerText code ?

Yes, that's the only code on my OnPlayerText.

Quote:

Originally Posted by HuSs3n

Afaik , OnPlayerText Must return 0, or the text will be sent twice.

pawn Код:

public OnPlayerText(playerid, text[])
{
    if ( Muted [ playerid ] == 1 )
    {
        format ( SStr , 128 , "You've been muted from the chat" ) ;
        SendClientMessage ( playerid , -1 , SStr ) ;
        return 0 ;
    }

    
    if ( ( text [ 0 ] == '*' ) && PlayerData [ playerid ] [ VIPLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "|ChatVip| %s(%d): %s" , pName ( playerid ) , playerid , text [ 1 ] ) ;
        MessageToPlayerVIP ( -1 , SStr ) ;
        SaveLog ( "VIPChatLog" , SStr ) ;
        return 0 ;
    }
    
    if ( ( text [ 0 ] == '#' ) && PlayerData [ playerid ] [ AdmLvl ] >= 1 && strlen(text) > 1 )
    {
        format ( SStr , sizeof ( SStr ) , "Admin Chat: %s: %s" , pName ( playerid ) , text [ 1 ] ) ;
        MessageToAdmins ( green , SStr ) ;
        SaveLog ( "AdmChatLog" , SStr ) ;
        return 0 ;
    }
    else
    {
       SendPlayerMessageToAll(playerid, text);
    }
    SaveChatLog ( playerid , "ChatLogs" , text ) ;
    return 0 ;
}

I tried it before. Doesn't seems to be working.