Combine 2 scripts - Printable Version

Combine 2 scripts - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Combine 2 scripts (/showthread.php?tid=361856)

Combine 2 scripts - kbalor - 22.07.2012

Add this script...

pawn Код:

if (PRESSED(KEY_FIRE))
        {
            AddVehicleComponent(GetPlayerVehicleID(playerid),1010);
        }
    if(newkeys & KEY_SUBMISSION)
    {
    if (IsPlayerInAnyVehicle(playerid))
        {
            if((GetPlayerVehicleID(playerid) == 520) || (GetPlayerVehicleID(playerid) == 425) || (GetPlayerVehicleID(playerid) == 464)) {
        return 1;
        }
            else {
            new Float:vx, Float:vy, Float:vz;
            GetVehicleVelocity(GetPlayerVehicleID(playerid), vx, vy, vz);
            SetVehicleVelocity(GetPlayerVehicleID(playerid) ,vx*2,vy*2 ,vz*2);
            }
        }
    }
    return 1;
}

In here..

pawn Код:

public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
    if(newkeys == KEY_SECONDARY_ATTACK)
    {
        if(!IsPlayerInAnyVehicle(playerid))
        {
            new Float:x, Float:y, Float:z, vehicle;
            GetPlayerPos(playerid, x, y, z);
            GetVehicleWithinDistance(playerid, x, y, z, 20.0, vehicle);
            if(IsVehicleRc(vehicle))
            {
                PutPlayerInVehicle(playerid, vehicle, 0);
            }
        }
        else {
            new vehicleID = GetPlayerVehicleID(playerid);
            if(IsVehicleRc(vehicleID) || GetVehicleModel(vehicleID) == RC_CAM){
                if(GetVehicleModel(vehicleID) != D_TRAM){
                    new Float:x, Float:y, Float:z;
                    GetPlayerPos(playerid, x, y, z);
                    SetPlayerPos(playerid, x+0.5, y, z+1.0);
                }
            }
        }
    }
    if(!gPlayerUsingLoopingAnim[playerid]) return;
    if(IsKeyJustDown(KEY_SECONDARY_ATTACK,newkeys,oldkeys))
    {
        StopLoopingAnim(playerid);
        TextDrawHideForPlayer(playerid,txtAnimHelper);
    }
}

Coz i tried and it gives me lot of warnings also, not responding..

Re: Combine 2 scripts - SuperViper - 22.07.2012

pawn Код:

public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
    if(newkeys == KEY_SECONDARY_ATTACK)
    {
        if(!IsPlayerInAnyVehicle(playerid))
        {
            new Float:x, Float:y, Float:z, vehicle;
            GetPlayerPos(playerid, x, y, z);
            GetVehicleWithinDistance(playerid, x, y, z, 20.0, vehicle);
            if(IsVehicleRc(vehicle))
            {
                PutPlayerInVehicle(playerid, vehicle, 0);
            }
        }
        else {
            new vehicleID = GetPlayerVehicleID(playerid);
            if(IsVehicleRc(vehicleID) || GetVehicleModel(vehicleID) == RC_CAM){
                if(GetVehicleModel(vehicleID) != D_TRAM){
                    new Float:x, Float:y, Float:z;
                    GetPlayerPos(playerid, x, y, z);
                    SetPlayerPos(playerid, x+0.5, y, z+1.0);
                }
            }
        }
    }
    if(!gPlayerUsingLoopingAnim[playerid]) return;
    if(IsKeyJustDown(KEY_SECONDARY_ATTACK,newkeys,oldkeys))
    {
        StopLoopingAnim(playerid);
        TextDrawHideForPlayer(playerid,txtAnimHelper);
    }
    if (PRESSED(KEY_FIRE))
        {
            AddVehicleComponent(GetPlayerVehicleID(playerid),1010);
        }
    if(newkeys & KEY_SUBMISSION)
    {
    if (IsPlayerInAnyVehicle(playerid))
        {
            if((GetPlayerVehicleID(playerid) == 520) || (GetPlayerVehicleID(playerid) == 425) || (GetPlayerVehicleID(playerid) == 464)) {
        return 1;
        }
            else {
            new Float:vx, Float:vy, Float:vz;
            GetVehicleVelocity(GetPlayerVehicleID(playerid), vx, vy, vz);
            SetVehicleVelocity(GetPlayerVehicleID(playerid) ,vx*2,vy*2 ,vz*2);
            }
        }
    }
    return 1;
}

Re: Combine 2 scripts - kbalor - 22.07.2012

Quote:

Originally Posted by SuperViper

pawn Код:

public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
    if(newkeys == KEY_SECONDARY_ATTACK)
    {
        if(!IsPlayerInAnyVehicle(playerid))
        {
            new Float:x, Float:y, Float:z, vehicle;
            GetPlayerPos(playerid, x, y, z);
            GetVehicleWithinDistance(playerid, x, y, z, 20.0, vehicle);
            if(IsVehicleRc(vehicle))
            {
                PutPlayerInVehicle(playerid, vehicle, 0);
            }
        }
        else {
            new vehicleID = GetPlayerVehicleID(playerid);
            if(IsVehicleRc(vehicleID) || GetVehicleModel(vehicleID) == RC_CAM){
                if(GetVehicleModel(vehicleID) != D_TRAM){
                    new Float:x, Float:y, Float:z;
                    GetPlayerPos(playerid, x, y, z);
                    SetPlayerPos(playerid, x+0.5, y, z+1.0);
                }
            }
        }
    }
    if(!gPlayerUsingLoopingAnim[playerid]) return;
    if(IsKeyJustDown(KEY_SECONDARY_ATTACK,newkeys,oldkeys))
    {
        StopLoopingAnim(playerid);
        TextDrawHideForPlayer(playerid,txtAnimHelper);
    }
    if (PRESSED(KEY_FIRE))
        {
            AddVehicleComponent(GetPlayerVehicleID(playerid),1010);
        }
    if(newkeys & KEY_SUBMISSION)
    {
    if (IsPlayerInAnyVehicle(playerid))
        {
            if((GetPlayerVehicleID(playerid) == 520) || (GetPlayerVehicleID(playerid) == 425) || (GetPlayerVehicleID(playerid) == 464)) {
        return 1;
        }
            else {
            new Float:vx, Float:vy, Float:vz;
            GetVehicleVelocity(GetPlayerVehicleID(playerid), vx, vy, vz);
            SetVehicleVelocity(GetPlayerVehicleID(playerid) ,vx*2,vy*2 ,vz*2);
            }
        }
    }
    return 1;
}

Thanks but Im getting this warnings:

Код:

(939) : warning 209: function "OnPlayerKeyStateChange" should return a value
(954) : error 078: function uses both "return" and "return <value>"
(963) : error 078: function uses both "return" and "return <value>"

Lines:

Код:

    if(!gPlayerUsingLoopingAnim[playerid]) return;
    if(IsKeyJustDown(KEY_SECONDARY_ATTACK,newkeys,oldkeys))
    {
        StopLoopingAnim(playerid);
        TextDrawHideForPlayer(playerid,txtAnimHelper);
    }
    if (PRESSED(KEY_FIRE))
        {
            AddVehicleComponent(GetPlayerVehicleID(playerid),1010);
        }
    if(newkeys & KEY_SUBMISSION)
    {
    if (IsPlayerInAnyVehicle(playerid))
        {
            if((GetPlayerVehicleID(playerid) == 520) || (GetPlayerVehicleID(playerid) == 425) || (GetPlayerVehicleID(playerid) == 464)) {
        return 1;
        }
            else {
            new Float:vx, Float:vy, Float:vz;
            GetVehicleVelocity(GetPlayerVehicleID(playerid), vx, vy, vz);
            SetVehicleVelocity(GetPlayerVehicleID(playerid) ,vx*2,vy*2 ,vz*2);
            }
        }
    }
    return 1;
}

Re: Combine 2 scripts - Rob_Maate - 22.07.2012

that's because you return; and return 1; in the same function.

this is a sa-mp callback, therefore you shouldn't be returning without either 1 or 0 anyway.

Re: Combine 2 scripts - kbalor - 22.07.2012

Quote:

Originally Posted by Rob_Maate

that's because you return; and return 1; in the same function.

this is a sa-mp callback, therefore you shouldn't be returning without either 1 or 0 anyway.

Well after removing both returns then compile No warnings, but when im in-game it's not working.. zzz.

Re: Combine 2 scripts - Rob_Maate - 22.07.2012

I meant change 'return;' to 'return 1;' not delete them.

Re: Combine 2 scripts - kbalor - 22.07.2012

thanks but still not working ingame.

Re: Combine 2 scripts - Andi_Evandy - 23.07.2012

Try This:

pawn Код:

public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
    if(newkeys == KEY_SECONDARY_ATTACK)
    {
        if(!IsPlayerInAnyVehicle(playerid))
        {
            new Float:x, Float:y, Float:z, vehicle;
            GetPlayerPos(playerid, x, y, z);
            GetVehicleWithinDistance(playerid, x, y, z, 20.0, vehicle);
            if(IsVehicleRc(vehicle))
            {
                PutPlayerInVehicle(playerid, vehicle, 0);
            }
        }
        else
        {
            new vehicleID = GetPlayerVehicleID(playerid);
            if(IsVehicleRc(vehicleID) || GetVehicleModel(vehicleID) == RC_CAM)
            {
                if(GetVehicleModel(vehicleID) != D_TRAM)
                {
                    new Float:x, Float:y, Float:z;
                    GetPlayerPos(playerid, x, y, z);
                    SetPlayerPos(playerid, x+0.5, y, z+1.0);
                }
            }
        }
    }
    if(!gPlayerUsingLoopingAnim[playerid]) return 1;
    if(IsKeyJustDown(KEY_SECONDARY_ATTACK,newkeys,oldkeys))
    {
        StopLoopingAnim(playerid);
        TextDrawHideForPlayer(playerid,txtAnimHelper);
    }
    if(PRESSED(KEY_FIRE)) AddVehicleComponent(GetPlayerVehicleID(playerid),1010);
    if(newkeys & KEY_SUBMISSION)
    {
        if(IsPlayerInAnyVehicle(playerid))
        {
            if((GetPlayerVehicleID(playerid) == 520) || (GetPlayerVehicleID(playerid) == 425) || (GetPlayerVehicleID(playerid) == 464)) return 1;
            else
            {
                new Float:vx, Float:vy, Float:vz;
                GetVehicleVelocity(GetPlayerVehicleID(playerid), vx, vy, vz);
                SetVehicleVelocity(GetPlayerVehicleID(playerid) ,vx*2,vy*2 ,vz*2);
            }
        }
    }
    return 1;
}

Re: Combine 2 scripts - kbalor - 23.07.2012

Quote:

Originally Posted by Andi_Evandy

Try This:

pawn Код:

public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
    if(newkeys == KEY_SECONDARY_ATTACK)
    {
        if(!IsPlayerInAnyVehicle(playerid))
        {
            new Float:x, Float:y, Float:z, vehicle;
            GetPlayerPos(playerid, x, y, z);
            GetVehicleWithinDistance(playerid, x, y, z, 20.0, vehicle);
            if(IsVehicleRc(vehicle))
            {
                PutPlayerInVehicle(playerid, vehicle, 0);
            }
        }
        else
        {
            new vehicleID = GetPlayerVehicleID(playerid);
            if(IsVehicleRc(vehicleID) || GetVehicleModel(vehicleID) == RC_CAM)
            {
                if(GetVehicleModel(vehicleID) != D_TRAM)
                {
                    new Float:x, Float:y, Float:z;
                    GetPlayerPos(playerid, x, y, z);
                    SetPlayerPos(playerid, x+0.5, y, z+1.0);
                }
            }
        }
    }
    if(!gPlayerUsingLoopingAnim[playerid]) return 1;
    if(IsKeyJustDown(KEY_SECONDARY_ATTACK,newkeys,oldkeys))
    {
        StopLoopingAnim(playerid);
        TextDrawHideForPlayer(playerid,txtAnimHelper);
    }
    if(PRESSED(KEY_FIRE)) AddVehicleComponent(GetPlayerVehicleID(playerid),1010);
    if(newkeys & KEY_SUBMISSION)
    {
        if(IsPlayerInAnyVehicle(playerid))
        {
            if((GetPlayerVehicleID(playerid) == 520) || (GetPlayerVehicleID(playerid) == 425) || (GetPlayerVehicleID(playerid) == 464)) return 1;
            else
            {
                new Float:vx, Float:vy, Float:vz;
                GetVehicleVelocity(GetPlayerVehicleID(playerid), vx, vy, vz);
                SetVehicleVelocity(GetPlayerVehicleID(playerid) ,vx*2,vy*2 ,vz*2);
            }
        }
    }
    return 1;
}

Sorry man still it's not working... No warning after compiling.

Anyway I have this on top of the script:

Код:

#define PRESSED(%0) \
(((newkeys & (%0)) == (%0)) && ((oldkeys & (%0)) != (%0)))