Code not working - Printable Version

Code not working - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Code not working (/showthread.php?tid=328547)

Code not working - Faisal_khan - 25.03.2012

Hi SA-MP Community,
I have an error in my code. It is not working.

pawn Код:

public OnPlayerSpawn(playerid)
{
    SetPlayerInterior(playerid,0);
        if(gTeam[playerid] == STAT)
    {
        SetPlayerColor(playerid, COLOR_ORANGE);
        GivePlayerWeapon(playerid, 34, 500);
        GivePlayerWeapon(playerid, 17, 10);
        GivePlayerWeapon(playerid, 24, 200);
        GivePlayerWeapon(playerid, 28, 400);
        ShowPlayerDialog(playerid, 1, DIALOG_STYLE_LIST, "*******Welcome to STAT(Special Tactics Assualt Team)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
    }
        else if (gTeam[playerid] == SWAT)
    {
        SetPlayerColor(playerid, COLOR_LIGHTBLUE);
        GivePlayerWeapon(playerid, 30, 500);
        GivePlayerWeapon(playerid, 17, 20);
        GivePlayerWeapon(playerid, 23, 300);
        ShowPlayerDialog(playerid, 2, DIALOG_STYLE_LIST, "*******Welcome to SWAT(Special Weapons And Tactics)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
    }
        else if(gTeam[playerid] == POLICE)
    {
        SetPlayerColor(playerid, COLOR_BLUE);
        GivePlayerWeapon(playerid, 22, 400);
        GivePlayerWeapon(playerid, 17, 10);
        GivePlayerWeapon(playerid, 27, 200);
        GivePlayerWeapon(playerid, 32, 400);
        ShowPlayerDialog(playerid, 3, DIALOG_STYLE_LIST, "*******Welcome to SFPD(San Fierro Police Department)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
    }
        else if(gTeam[playerid] == ARMY)
    {
        SetPlayerColor(playerid, COLOR_TAN);
        GivePlayerWeapon(playerid, 16, 20);
        GivePlayerWeapon(playerid, 27, 200);
        GivePlayerWeapon(playerid, 29, 300);
        GivePlayerWeapon(playerid, 31, 400);
        ShowPlayerDialog(playerid, 4, DIALOG_STYLE_LIST, "*******Welcome to US Army*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
    }
        else if(gTeam[playerid] == CIVILIAN)
    {
        SetPlayerColor(playerid, COLOR_WHITE);
        ShowPlayerDialog(playerid, 5, DIALOG_STYLE_LIST, "*******Civilian Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
    }
        else if(gTeam[playerid] == PARAMEDIC)
    {
        SetPlayerColor(playerid, COLOR_INDIGO);
        GivePlayerWeapon(playerid, 22, 50);
        ShowPlayerDialog(playerid, 6, DIALOG_STYLE_LIST, "*******Para Medic Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
    }
        else if(gTeam[playerid] == MECHANIC)
    {
        SetPlayerColor(playerid, COLOR_GREY);
        ShowPlayerDialog(playerid, 7, DIALOG_STYLE_LIST, "*******Mechanic Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
    }
        else if(gTeam[playerid] == HITMAN)
    {
        SetPlayerColor(playerid, COLOR_WHITE);
        GivePlayerWeapon(playerid, 23, 200);
        GivePlayerWeapon(playerid, 30, 200);
        GivePlayerWeapon(playerid, 34, 100);
        ShowPlayerDialog(playerid, 8, DIALOG_STYLE_LIST, "*******Hitman Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
    }
        if(!gPlayerAnimLibsPreloaded[playerid])
    {
        PreloadAnimLib(playerid,"BOMBER");
        PreloadAnimLib(playerid,"RAPPING");
        PreloadAnimLib(playerid,"SHOP");
        PreloadAnimLib(playerid,"BEACH");
        PreloadAnimLib(playerid,"SMOKING");
        PreloadAnimLib(playerid,"FOOD");
        PreloadAnimLib(playerid,"ON_LOOKERS");
        PreloadAnimLib(playerid,"DEALER");
        PreloadAnimLib(playerid,"CRACK");
        PreloadAnimLib(playerid,"CARRY");
        PreloadAnimLib(playerid,"COP_AMBIENT");
        PreloadAnimLib(playerid,"PARK");
        PreloadAnimLib(playerid,"INT_HOUSE");
        PreloadAnimLib(playerid,"FOOD");
        gPlayerAnimLibsPreloaded[playerid] = 1;
    }
    new newtext[41], name[MAX_PLAYERS];
    GetPlayerName(playerid, name, MAX_PLAYER_NAME);
    format(newtext, sizeof(newtext), "Hi %s, how are you?", name);
    TextDrawSetString(himessage, newtext);
    TextDrawShowForPlayer(playerid, himessage);
    return 1;
}

gTeam part is not working(GivePlayerWeapon, SetPlayerColor and ShowPlayerDialog). Help me out.

Re: Code not working - Reklez - 25.03.2012

try switching them.

Re: Code not working - Infinitas - 25.03.2012

What is the error exactly?

Re: Code not working - Reklez - 25.03.2012

he said its not working not error. so i give him some tip to make it switch instead of if(...

Re: Code not working - Faisal_khan - 25.03.2012

Thanks for the reply, but it is still not working

pawn Код:

public OnPlayerSpawn(playerid)
{
    SetPlayerInterior(playerid,0);
    switch(gTeam[playerid])
    {
        case 1:
        {
            SetPlayerColor(playerid, COLOR_ORANGE);
            GivePlayerWeapon(playerid, 34, 500);
            GivePlayerWeapon(playerid, 17, 10);
            GivePlayerWeapon(playerid, 24, 200);
            GivePlayerWeapon(playerid, 28, 400);
            ShowPlayerDialog(playerid, 1, DIALOG_STYLE_LIST, "*******Welcome to STAT(Special Tactics Assualt Team)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 2:
        {
            SetPlayerColor(playerid, COLOR_LIGHTBLUE);
            GivePlayerWeapon(playerid, 30, 500);
            GivePlayerWeapon(playerid, 17, 20);
            GivePlayerWeapon(playerid, 23, 300);
            ShowPlayerDialog(playerid, 2, DIALOG_STYLE_LIST, "*******Welcome to SWAT(Special Weapons And Tactics)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 3:
        {
            SetPlayerColor(playerid, COLOR_BLUE);
            GivePlayerWeapon(playerid, 22, 400);
            GivePlayerWeapon(playerid, 17, 10);
            GivePlayerWeapon(playerid, 27, 200);
            GivePlayerWeapon(playerid, 32, 400);
            ShowPlayerDialog(playerid, 3, DIALOG_STYLE_LIST, "*******Welcome to SFPD(San Fierro Police Department)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 4:
        {
            SetPlayerColor(playerid, COLOR_TAN);
            GivePlayerWeapon(playerid, 16, 20);
            GivePlayerWeapon(playerid, 27, 200);
            GivePlayerWeapon(playerid, 29, 300);
            GivePlayerWeapon(playerid, 31, 400);
            ShowPlayerDialog(playerid, 4, DIALOG_STYLE_LIST, "*******Welcome to US Army*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 5:
        {
            SetPlayerColor(playerid, COLOR_WHITE);
            ShowPlayerDialog(playerid, 5, DIALOG_STYLE_LIST, "*******Civilian Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 6:
        {
            SetPlayerColor(playerid, COLOR_INDIGO);
            GivePlayerWeapon(playerid, 22, 50);
            ShowPlayerDialog(playerid, 6, DIALOG_STYLE_LIST, "*******Para Medic Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 7:
        {
            SetPlayerColor(playerid, COLOR_GREY);
            ShowPlayerDialog(playerid, 7, DIALOG_STYLE_LIST, "*******Mechanic Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 8:
        {
            SetPlayerColor(playerid, COLOR_WHITE);
            GivePlayerWeapon(playerid, 23, 200);
            GivePlayerWeapon(playerid, 30, 200);
            GivePlayerWeapon(playerid, 34, 100);
            ShowPlayerDialog(playerid, 8, DIALOG_STYLE_LIST, "*******Hitman Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
        }
    }
        if(!gPlayerAnimLibsPreloaded[playerid])
    {
        PreloadAnimLib(playerid,"BOMBER");
        PreloadAnimLib(playerid,"RAPPING");
        PreloadAnimLib(playerid,"SHOP");
        PreloadAnimLib(playerid,"BEACH");
        PreloadAnimLib(playerid,"SMOKING");
        PreloadAnimLib(playerid,"FOOD");
        PreloadAnimLib(playerid,"ON_LOOKERS");
        PreloadAnimLib(playerid,"DEALER");
        PreloadAnimLib(playerid,"CRACK");
        PreloadAnimLib(playerid,"CARRY");
        PreloadAnimLib(playerid,"COP_AMBIENT");
        PreloadAnimLib(playerid,"PARK");
        PreloadAnimLib(playerid,"INT_HOUSE");
        PreloadAnimLib(playerid,"FOOD");
        gPlayerAnimLibsPreloaded[playerid] = 1;
    }
    new newtext[41], name[MAX_PLAYERS];
    GetPlayerName(playerid, name, MAX_PLAYER_NAME);
    format(newtext, sizeof(newtext), "Hi %s, how are you?", name);
    TextDrawSetString(himessage, newtext);
    TextDrawShowForPlayer(playerid, himessage);
    return 1;
}

AW: Code not working - Campbell- - 25.03.2012

Try to debug, print gTeam[playerid] and check if the value is correct. Aswell you may check if the case clauses get called by using print.

Re: AW: Code not working - Faisal_khan - 25.03.2012

Quote:

Originally Posted by Campbell-

Try to debug, print gTeam[playerid] and check if the value is correct. Aswell you may check if the case clauses get called by using print.

Can you show me how to do it?

AW: Code not working - Campbell- - 25.03.2012

Check: https://sampwiki.blast.hk/wiki/Printf

pawn Код:

print_f("%i", gTeam[playerid]);

To check if a clause gets called:

pawn Код:

print("Clause gets called.");

Re: Code not working - Faisal_khan - 25.03.2012

Can you elaborate a little more?

AW: Code not working - Campbell- - 25.03.2012

pawn Код:

public OnPlayerSpawn(playerid)
{
    SetPlayerInterior(playerid,0);
    print_f("%i", gTeam[playerid]);
    switch(gTeam[playerid])
    {
        case 1:
        {
            print("Case 1 gets called");
            SetPlayerColor(playerid, COLOR_ORANGE);
            GivePlayerWeapon(playerid, 34, 500);
            GivePlayerWeapon(playerid, 17, 10);
            GivePlayerWeapon(playerid, 24, 200);
            GivePlayerWeapon(playerid, 28, 400);
            ShowPlayerDialog(playerid, 1, DIALOG_STYLE_LIST, "*******Welcome to STAT(Special Tactics Assualt Team)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 2:
        {
            print("Case 2 gets called");
            SetPlayerColor(playerid, COLOR_LIGHTBLUE);
            GivePlayerWeapon(playerid, 30, 500);
            GivePlayerWeapon(playerid, 17, 20);
            GivePlayerWeapon(playerid, 23, 300);
            ShowPlayerDialog(playerid, 2, DIALOG_STYLE_LIST, "*******Welcome to SWAT(Special Weapons And Tactics)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 3:
        {
            print("Case 3 gets called");
            SetPlayerColor(playerid, COLOR_BLUE);
            GivePlayerWeapon(playerid, 22, 400);
            GivePlayerWeapon(playerid, 17, 10);
            GivePlayerWeapon(playerid, 27, 200);
            GivePlayerWeapon(playerid, 32, 400);
            ShowPlayerDialog(playerid, 3, DIALOG_STYLE_LIST, "*******Welcome to SFPD(San Fierro Police Department)*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 4:
        {
            print("Case 4 gets called");
            SetPlayerColor(playerid, COLOR_TAN);
            GivePlayerWeapon(playerid, 16, 20);
            GivePlayerWeapon(playerid, 27, 200);
            GivePlayerWeapon(playerid, 29, 300);
            GivePlayerWeapon(playerid, 31, 400);
            ShowPlayerDialog(playerid, 4, DIALOG_STYLE_LIST, "*******Welcome to US Army*******","INFO\n\nSPECIAL COMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 5:
        {
            print("Case 5 gets called");
            SetPlayerColor(playerid, COLOR_WHITE);
            ShowPlayerDialog(playerid, 5, DIALOG_STYLE_LIST, "*******Civilian Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 6:
        {
            print("Case 6 gets called");
            SetPlayerColor(playerid, COLOR_INDIGO);
            GivePlayerWeapon(playerid, 22, 50);
            ShowPlayerDialog(playerid, 6, DIALOG_STYLE_LIST, "*******Para Medic Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 7:
        {
            print("Case 7 gets called");
            SetPlayerColor(playerid, COLOR_GREY);
            ShowPlayerDialog(playerid, 7, DIALOG_STYLE_LIST, "*******Mechanic Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
        }
        case 8:
        {
            print("Case 8 gets called");
            SetPlayerColor(playerid, COLOR_WHITE);
            GivePlayerWeapon(playerid, 23, 200);
            GivePlayerWeapon(playerid, 30, 200);
            GivePlayerWeapon(playerid, 34, 100);
            ShowPlayerDialog(playerid, 8, DIALOG_STYLE_LIST, "*******Hitman Class*******","INFO\n\nCOMMANDS\n\nRULES","SELECT","CLOSE");
        }
    }
        if(!gPlayerAnimLibsPreloaded[playerid])
    {
        PreloadAnimLib(playerid,"BOMBER");
        PreloadAnimLib(playerid,"RAPPING");
        PreloadAnimLib(playerid,"SHOP");
        PreloadAnimLib(playerid,"BEACH");
        PreloadAnimLib(playerid,"SMOKING");
        PreloadAnimLib(playerid,"FOOD");
        PreloadAnimLib(playerid,"ON_LOOKERS");
        PreloadAnimLib(playerid,"DEALER");
        PreloadAnimLib(playerid,"CRACK");
        PreloadAnimLib(playerid,"CARRY");
        PreloadAnimLib(playerid,"COP_AMBIENT");
        PreloadAnimLib(playerid,"PARK");
        PreloadAnimLib(playerid,"INT_HOUSE");
        PreloadAnimLib(playerid,"FOOD");
        gPlayerAnimLibsPreloaded[playerid] = 1;
    }
    new newtext[41], name[MAX_PLAYERS];
    GetPlayerName(playerid, name, MAX_PLAYER_NAME);
    format(newtext, sizeof(newtext), "Hi %s, how are you?", name);
    TextDrawSetString(himessage, newtext);
    TextDrawShowForPlayer(playerid, himessage);
    return 1;
}

Check if what you do fits the prints in the console.