Params won't show up! - Printable Version

Params won't show up! - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Params won't show up! (/showthread.php?tid=321830)

Params won't show up! - Twisted_Insane - 28.02.2012

'Sup y'all?

I just made fast a "setvip"-command, and then, I tested it! Unfortunately, when I just write "/setvip [ID]" or only "/setvip", it doesn't show the usage! There's written, that I've set my VIP-level to 0, even though it should show the usage:

PHP код:



COMMAND:setvip(playerid, params[])

{

    if(PlayerInfo[playerid][pAdmin] >= 5)

    {


            new Target;

            new Level;

            if(!sscanf(params, "ui", Target, Level)) SendClientMessage(playerid,COLOR_RED,"USAGE: /setvip <playerid> <level>");

            {

                //if(Target == playerid) return SendClientMessage(playerid, COLOR_RED, "SERVER: Cant perform this command on yourself!" );

                if(Level > 3) return SendClientMessage(playerid, COLOR_RED, "SERVER: Maximum level is 3!");

                if(Target == INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"ERROR: Wrong player ID");

                if(PlayerInfo[Target][pAdmin] > PlayerInfo[playerid][pAdmin]) return SendClientMessage(playerid,COLOR_RED,"ERROR: You cant perform this on Admins that are equal or higher than your level!");

                PlayerInfo[Target][VIPlevel] = Level;

                new tname[MAX_PLAYER_NAME];

                GetPlayerName(Target,tname,sizeof(tname));

                new pname[MAX_PLAYER_NAME];

                GetPlayerName(playerid,pname,sizeof(pname));

                new MyString[128];

                new TargetString[128];

                format(MyString, sizeof(MyString), "You have set %s VIP Level to %i!", tname, Level);

                format(TargetString, sizeof(TargetString), "You are now VIP Level %i, thanks to %s!", Level, pname);

                SendClientMessage(Target, COLOR_RED, TargetString);

                SendClientMessage(playerid,COLOR_GREEN,MyString);

                PlayerPlaySound(Target,1057,0.0,0.0,0.0);

            }

            

    }

    else SendClientMessage(playerid, COLOR_RED, "ERROR: You have to be an Admin level 4 or higher to perform this command!");

    return 1;

}

Re: Params won't show up! - Babul - 28.02.2012

simple mistake:

pawn Код:

if(!sscanf

should be

pawn Код:

if(sscanf

Re: Params won't show up! - Twisted_Insane - 28.02.2012

Thanks! Well, now it shows the usage, but still a problem: When I just type "/setvip" or "/setvip [ID]" it should return the usage either! But, it shows it and sets my level to 0!

Re: Params won't show up! - Babul - 28.02.2012

oh, i didnt see the missing return - anyways, here is how i would have scripted it:

pawn Код:

COMMAND:setvip(playerid, params[])
{
    if(PlayerInfo[playerid][pAdmin] >= 5)
    {
        new Target;
        new Level;
        if(!sscanf(params, "ui", Target, Level)) 
        {
            //if(Target == playerid) return SendClientMessage(playerid, COLOR_RED, "SERVER: Cant perform this command on yourself!" );
            if(Level > 3) return SendClientMessage(playerid, COLOR_RED, "SERVER: Maximum level is 3!");
            if(Target == INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"ERROR: Wrong player ID");
            if(PlayerInfo[Target][pAdmin] > PlayerInfo[playerid][pAdmin]) return SendClientMessage(playerid,COLOR_RED,"ERROR: You cant perform this on Admins that are equal or higher than your level!");
            PlayerInfo[Target][VIPlevel] = Level;
            new tname[MAX_PLAYER_NAME];
            GetPlayerName(Target,tname,sizeof(tname));
            new pname[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pname,sizeof(pname));
            new MyString[128];
            new TargetString[128];
            format(MyString, sizeof(MyString), "You have set %s VIP Level to %i!", tname, Level);
            format(TargetString, sizeof(TargetString), "You are now VIP Level %i, thanks to %s!", Level, pname);
            SendClientMessage(Target, COLOR_RED, TargetString);
            SendClientMessage(playerid,COLOR_GREEN,MyString);
            PlayerPlaySound(Target,1057,0.0,0.0,0.0);
        }
        else
        {
            SendClientMessage(playerid,COLOR_RED,"USAGE: /setvip <playerid> <level>");
        }
    }
    else
    {
        SendClientMessage(playerid, COLOR_RED, "ERROR: You have to be an Admin level 4 or higher to perform this command!");
    }
    return 1;
}

Re: Params won't show up! - iPLEOMAX - 28.02.2012

Try this, untested:

pawn Код:

COMMAND:setvip(playerid, params[])
{
    if(PlayerInfo[playerid][pAdmin] < 4)
    return SendClientMessage(playerid, COLOR_RED, "ERROR: You have to be an Admin level 4 or higher to perform this command!");

    new Target, Level;
    if(sscanf(params, "ui", Target, Level))
    return SendClientMessage(playerid,COLOR_RED,"USAGE: /setvip <playerid> <level>");

    //if(Target == playerid) return SendClientMessage(playerid, COLOR_RED, "SERVER: Cant perform this command on yourself!" );
    if(Level > 3) return SendClientMessage(playerid, COLOR_RED, "SERVER: Maximum level is 3!");
    if(Target == INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"ERROR: Wrong player ID");
    
    if(PlayerInfo[Target][pAdmin] > PlayerInfo[playerid][pAdmin])
    return SendClientMessage(playerid,COLOR_RED,"ERROR: You cant perform this on Admins that are equal or higher than your level!");

    PlayerInfo[Target][VIPlevel] = Level;
    
    new pname[MAX_PLAYER_NAME], string[128];
    
    GetPlayerName(Target,pname,sizeof(pname));
    format(string, sizeof(string), "You have set %s VIP Level to %i!", pname, Level);
    SendClientMessage(playerid, COLOR_GREEN, string);
    
    GetPlayerName(playerid,pname,sizeof(pname));
    format(string, sizeof(string), "You are now VIP Level %i, thanks to %s!", Level, pname);
    SendClientMessage(Target, COLOR_RED, string);
    
    PlayerPlaySound(Target,1057,0.0,0.0,0.0);
    
    return 1;
}

Re: Params won't show up! - Twisted_Insane - 28.02.2012

Still doesn't work, still gives the message that I set my level to 0, even though I only type "/setvip"...

pawn Код:

COMMAND:setvip(playerid, params[])
{
    if(PlayerInfo[playerid][pAdmin] >= 5)
    {

            new Target;
            new Level;
            if(sscanf(params, "ui", Target, Level)) 
            {
                //if(Target == playerid) return SendClientMessage(playerid, COLOR_RED, "SERVER: Cant perform this command on yourself!" );
                if(Level > 3) return SendClientMessage(playerid, COLOR_RED, "SERVER: Maximum level is 3!");
                if(Target == INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"ERROR: Wrong player ID");
                if(PlayerInfo[Target][pAdmin] > PlayerInfo[playerid][pAdmin]) return SendClientMessage(playerid,COLOR_RED,"ERROR: You cant perform this on Admins that are equal or higher than your level!");
                PlayerInfo[Target][VIPlevel] = Level;
                new tname[MAX_PLAYER_NAME];
                GetPlayerName(Target,tname,sizeof(tname));
                new pname[MAX_PLAYER_NAME];
                GetPlayerName(playerid,pname,sizeof(pname));
                new MyString[128];
                new TargetString[128];
                format(MyString, sizeof(MyString), "You have set %s VIP Level to %i!", tname, Level);
                format(TargetString, sizeof(TargetString), "You are now VIP Level %i, thanks to %s!", Level, pname);
                SendClientMessage(Target, COLOR_RED, TargetString);
                SendClientMessage(playerid,COLOR_GREEN,MyString);
                PlayerPlaySound(Target,1057,0.0,0.0,0.0);
            }
            else
            {
                SendClientMessage(playerid,COLOR_RED,"USAGE: /setvip <playerid> <level>");
            }
            
    }
    else
    {
        SendClientMessage(playerid, COLOR_RED, "ERROR: You have to be an Admin level 4 or higher to perform this command!");
    }
    return 1;
}

EDIT: Tryin' this from iPLEOMAX! I'mma post later what happened!
EDIT2: Yep, thanks iPLEOMAX, all fixed, you betcha!^_^

Re: Params won't show up! - Konstantinos - 28.02.2012

1st way:

pawn Код:

if( !sscanf( params, "ui", Target, Level ) ) 
{
     // Code
     return 1;
}
else return SendClientMessage( playerid, COLOR_RED, "USAGE: /setvip <playerid> <level>" );

2nd way:

pawn Код:

if( sscanf( params, "ui", Target, Level ) ) return SendClientMessage( playerid, COLOR_RED, "USAGE: /setvip <playerid> <level>" );
// Code
return 1;