SA-MP Forums Archive
SetPlayerTeamFromClass & SetPlayerToTeamColor - What Have I Done Wrong ? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: SetPlayerTeamFromClass & SetPlayerToTeamColor - What Have I Done Wrong ? (/showthread.php?tid=318542)


SetPlayerTeamFromClass & SetPlayerToTeamColor - What Have I Done Wrong ? - Mr.Fames - 15.02.2012

Hey guys i will just give you the code and you check if it has any errors or no
First The SetPlayerTeamFromClass function if it is not correct please tell me how to fix it
pawn Код:
SetPlayerTeamFromClass(playerid, classid)
{
    if(classid == 0)
    {
        gTeam[playerid] = TEAM_VAGOS;
    }
    else
    {
        gTeam[playerid] = TEAM_GROVE;
    }
    else
    {
        gTeam[playerid] = TEAM_BALLAS;
    }
    else
    {
        gTeam[playerid] = TEAM_ARMY;
    }
    else
    {
        gTeam[playerid] = TEAM_POLICE;
    }
    else 
    {
        gTeam[playerid] = TEAM_MAFIA;
    }
    else
    {
        gTeam[playerid] = TEAM_ADMINS;
    }
}
And Now The SetPlayerToTeamColor
pawn Код:
SetPlayerToTeamColor(playerid)
{
    if (gTeam[playerid] == TEAM_VAGOS)
    {
        SetPlayerColor(playerid, TEAM_VAGOS_COLOR);
    }
    else if (gTeam[playerid] == TEAM_GROVE)
    {
        SetPlayerColor(playerid, TEAM_GROVE_COLOR);
    }
    else if (gTeam[playerid] == TEAM_BALLAS)
    {
        SetPlayerColor(playerid, TEAM_BALLAS_COLOR);
    }
    else if (gTeam[playerid] == TEAM_ARMY)
    {
        SetPlayerColor(playerid, TEAM_ARMY_COLOR);
    }
    else if (gTeam[playerid] == TEAM_POLICE)
    {
        SetPlayerColor(playerid, TEAM_POLICE_COLOR)
    }
    else if (gTeam[playerid] == TEAM_MAFIA)
    {
        SetPlayerColor(playerid, TEAM_MAFIA_COLOR);
    }
    else if(gTeam[playerid] == TEAM_ADMINS)
    {
        SetPlayerColor(playerid, TEAM_ADMINS_COLOR);
    }
}
Thanks in advance

Re: SetPlayerTeamFromClass & SetPlayerToTeamColor - What Have I Done Wrong ? - Neo Karls - 15.02.2012

In First Script , you cant use else for each cases, this condition is used for only 1 or 2 . For multiple you should use
pawn Код:
if

else if

else
Format

pawn Код:
SetPlayerTeamFromClass(playerid, classid)
{
    if(classid == 0)
    {
        gTeam[playerid] = TEAM_VAGOS;
    }
    else if
    {
        gTeam[playerid] = TEAM_GROVE;
    }
    else if
    {
        gTeam[playerid] = TEAM_BALLAS;
    }
    else if
    {
        gTeam[playerid] = TEAM_ARMY;
    }
    else if
    {
        gTeam[playerid] = TEAM_POLICE;
    }
    else if
    {
        gTeam[playerid] = TEAM_MAFIA;
    }
    else
    {
        gTeam[playerid] = TEAM_ADMINS;
    }
}


Re: SetPlayerTeamFromClass & SetPlayerToTeamColor - What Have I Done Wrong ? - Twisted_Insane - 15.02.2012

@Neo

Lol, you forgot again an "else if" statement, at "Mafia"!

@MrFames

I recommend you to use cases, which are better instead of the "else if" statement! The "cases" are here the skin-numbers, starting from 0! This, for example, is mine:

PHP код:
SetPlayerTeamFromClass(playerid, classid)
{
    switch(classid)
    {
        case 0 .. 2:
        {
            gTeam[playerid] = BALLA;
        }
        case 3 .. 7:
        {
            gTeam[playerid] = GROVE;
        }
        case 8 .. 10:
        {
            gTeam[playerid] = VAGOS;
        }
        case 11 .. 14:
        {
            gTeam[playerid] = AZTECAS;
        }
        case 15 .. 23:
        {
            gTeam[playerid] = POLICE;
        }
        case 24 .. 26:
        {
            gTeam[playerid] = RIFAS;
        }
        case 27 .. 31:
        {
            gTeam[playerid] = LOCO;
        }
    }
} 
Also, at the color-callback:

PHP код:
SetPlayerToTeamColor(playerid)
{
    switch(gTeam[playerid])
    {
        case GROVE:
        {
            SetPlayerColor(playerid, TEAM_GROVE_COLOR);
        }
        case BALLA:
        {
            SetPlayerColor(playerid, TEAM_BALLA_COLOR);
        }
        case VAGOS:
        {
            SetPlayerColor(playerid, TEAM_VAGOS_COLOR);
        }
        case AZTECAS:
        {
            SetPlayerColor(playerid, TEAM_AZTECAS_COLOR);
        }
        case POLICE:
        {
            SetPlayerColor(playerid, TEAM_POLICE_COLOR);
        }
        case RIFAS:
        {
            SetPlayerColor(playerid, TEAM_RIFAS_COLOR);
        }
        case LOCO:
        {
            SetPlayerColor(playerid, TEAM_LOCO_COLOR);
        }
    }
} 


Re: SetPlayerTeamFromClass & SetPlayerToTeamColor - What Have I Done Wrong ? - Mr.Fames - 15.02.2012

hmmm @Tisted_Insane
I didn't get u, what did u mean by skin numbers can u explain more please

Re: SetPlayerTeamFromClass & SetPlayerToTeamColor - What Have I Done Wrong ? - Neo Karls - 15.02.2012

Yeah bro , I was editing throughout there and missed one,but i corrected it before your last reply , anyway thanks btw...

You re right Case Statement is the best conditional statement because , the script is more clear and easy to know.

For Each Case, for example input value is BALLA

then the script will proceed only

case BALLA:
{
SetPlayerColor(playerid, TEAM_BALLA_COLOR);
}

and break to outside the loop ({ })..

Re: SetPlayerTeamFromClass & SetPlayerToTeamColor - What Have I Done Wrong ? - Twisted_Insane - 15.02.2012

Quote:
Originally Posted by Mr.Fames
Посмотреть сообщение
hmmm @Tisted_Insane
I didn't get u, what did u mean by skin numbers can u explain more please
I mean the skins at "OnPlayerRequestClass" and "OnGameModeInit", the skins, which you add there!