Issue with my /r - Printable Version

Issue with my /r - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Issue with my /r (/showthread.php?tid=303952)

Issue with my /r - Azzeto - 16.12.2011

Is there anything wrong with this?

PHP код:



CMD:r(playerid,params[])

{

    new text[128];

    if(sscanf(params,"s",text)) return SendClientMessage(playerid,COLOR_SYNTAX,"[SYNTAX]: /r [message]");

    for(new i; i < MAX_PLAYERS; i++)

       {

        if(PlayerInfo[i][Group] == 1 && PlayerInfo[i][Member] == 1)

        {

            new str[128],pName[MAX_PLAYER_NAME];

            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);

            format(str,sizeof(str),"[Police Radio] Deputy Sheriff %s: %s , Over.",pName,text);

            SendClientMessage(i,COLOR_SYNTAX,str);

        }

        if(PlayerInfo[i][Group] == 1 && PlayerInfo[i][Member] == 2)

        {

            new str[128],pName[MAX_PLAYER_NAME];

            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);

            format(str,sizeof(str),"[Police Radio] Deputy Sheriff Bonus %s: %s , Over.",pName,text);

            SendClientMessage(i,COLOR_SYNTAX,str);

        }

        if(PlayerInfo[i][Group] == 1 && PlayerInfo[i][Member] == 3)

        {

            new str[128],pName[MAX_PLAYER_NAME];

            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);

            format(str,sizeof(str),"[Police Radio] Sergeant %s: %s , Over.",pName,text);

            SendClientMessage(i,COLOR_SYNTAX,str);

        }

        if(PlayerInfo[i][Group] == 1 && PlayerInfo[i][Member] == 4)

        {

            new str[128],pName[MAX_PLAYER_NAME];

            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);

            format(str,sizeof(str),"[Police Radio] Liutenant %s: %s , Over.",pName,text);

            SendClientMessage(i,COLOR_SYNTAX,str);

        }

        if(PlayerInfo[i][Group] == 1 && PlayerInfo[i][Member] == 5)

        {

            new str[128],pName[MAX_PLAYER_NAME];

            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);

            format(str,sizeof(str),"[Police Radio] Under Sheriff %s: %s , Over.",pName,text);

            SendClientMessage(i,COLOR_SYNTAX,str);

        }

        if(PlayerInfo[i][Group] == 1 && PlayerInfo[i][Member] == 6)

        {

            new str[128],pName[MAX_PLAYER_NAME];

            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);

            format(str,sizeof(str),"[Police Radio] Sheriff %s: %s , Over.",pName,text);

            SendClientMessage(i,COLOR_SYNTAX,str);

        }

    }

    return 1;

}

I don't really see anything wrong with this, but it ALWAYS says Sheriff no matter what rank...

Re : Issue with my /r - BigBaws - 16.12.2011

i guess there are something wrong in if(PlayerInfo[i][Group] == 1 && PlayerInfo[i][Member] == 6)
about the '=='

Re: Issue with my /r - kizla - 16.12.2011

fisrt your sscanf is not proprley it must go:

pawn Код:

if(sscanf(params,"s[128]",text)) return SendClientMessage(playerid,COLOR_SYNTAX,"[SYNTAX]: /r [message]");

second give us a variable for Rank?

Re: Issue with my /r - Azzeto - 16.12.2011

Member is Rank.. and I have no issues with the sscanf, that all works fine, I need to know why it says "Sheriff" for like every rank,

And BigBaws, it shouldnt be the == because that means equal to.

Re: Issue with my /r - kizla - 16.12.2011

pawn Код:

CMD:r(playerid,params[])
{
    new text[128];
    if(sscanf(params,"s",text)) return SendClientMessage(playerid,COLOR_SYNTAX,"[SYNTAX]: /r [message]");

     if(PlayerInfo[playerid][Group] == 1 && PlayerInfo[playerid][Member] == 1)
        {
            new str[128],pName[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);
            format(str,sizeof(str),"[Police Radio] Deputy Sheriff %s: %s , Over.",pName,text);
            SendClientMessage(i,COLOR_SYNTAX,str);
        }
        if(PlayerInfo[playerid][Group] == 1 && PlayerInfo[playerid][Member] == 2)
        {
            new str[128],pName[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);
            format(str,sizeof(str),"[Police Radio] Deputy Sheriff Bonus %s: %s , Over.",pName,text);
            SendClientMessage(i,COLOR_SYNTAX,str);
        }
        if(PlayerInfo[playerid][Group] == 1 && PlayerInfo[playerid][Member] == 3)
        {
            new str[128],pName[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);
            format(str,sizeof(str),"[Police Radio] Sergeant %s: %s , Over.",pName,text);
            SendClientMessage(i,COLOR_SYNTAX,str);
        }
        if(PlayerInfo[playerid][Group] == 1 && PlayerInfo[playerid][Member] == 4)
        {
            new str[128],pName[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);
            format(str,sizeof(str),"[Police Radio] Liutenant %s: %s , Over.",pName,text);
            SendClientMessage(i,COLOR_SYNTAX,str);
        }
        if(PlayerInfo[playerid][Group] == 1 && PlayerInfo[playerid][Member] == 5)
        {
            new str[128],pName[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);
            format(str,sizeof(str),"[Police Radio] Under Sheriff %s: %s , Over.",pName,text);
            SendClientMessage(i,COLOR_SYNTAX,str);
        }
        if(PlayerInfo[playerid][Group] == 1 && PlayerInfo[playerid][Member] == 6)
        {
            new str[128],pName[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);
            format(str,sizeof(str),"[Police Radio] Sheriff %s: %s , Over.",pName,text);
            SendClientMessage(i,COLOR_SYNTAX,str);
        }
    }
    return 1;
}

you must have playerid, dont loop...

and instend ranks use public function SendRadioMessage

pawn Код:

forward SendRadioMessage(group, color, string[]);
public SendRadioMessage(group, color, string[])
{
    for(new i = 0; i < MAX_PLAYERS; i++)
    {
        if(PlayerInfo[i][Group] == clan)
        {
            SendClientMessage(i, color, string);
        }
    }
}

Re: Issue with my /r - PrawkC - 16.12.2011

So.. "member" is your rank?

Re: Issue with my /r - Jack_Leslie - 16.12.2011

pawn Код:

stock GetRank(playerid)
{
    new string[126];
    switch(PlayerInfo[playerid][pRank]) // change to your rank variable
    {
        case 8: string = "Chief of Police";
        case 7: string = "Assistant Chief";
        case 6: string = "Commander";
        case 5: string = "Captain";
        case 4: string = "Lieutenant";
        case 3: string = "Sergeant";
        case 2: string = "Police Officer III";
        case 1: string = "Police Officer II";
        default: string = "Police Officer I";
        // change the name of your ranks
    }
    return string;
}

CMD:r(playerid,params[])
{
    new text[128];
    if(sscanf(params,"s",text)) return SendClientMessage(playerid,COLOR_SYNTAX,"[SYNTAX]: /r [message]");
    for(new i; i < MAX_PLAYERS; i++)
       {
        if(PlayerInfo[i][Group] == 1)
        {
            new str[128],pName[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);
            format(str,sizeof(str),"[Police Radio] %s %s: %s , Over.",GetRank(playerid),pName,text);
            SendClientMessage(i,COLOR_SYNTAX,str);
        }
    }
    return 1;
}

Re : Re: Issue with my /r - BigBaws - 16.12.2011

Quote:

Originally Posted by Jack_Leslie

pawn Код:

stock GetRank(playerid)
{
    new string[126];
    switch(PlayerInfo[playerid][pRank]) // change to your rank variable
    {
        case 8: string = "Chief of Police";
        case 7: string = "Assistant Chief";
        case 6: string = "Commander";
        case 5: string = "Captain";
        case 4: string = "Lieutenant";
        case 3: string = "Sergeant";
        case 2: string = "Police Officer III";
        case 1: string = "Police Officer II";
        default: string = "Police Officer I";
        // change the name of your ranks
    }
    return string;
}

CMD:r(playerid,params[])
{
    new text[128];
    if(sscanf(params,"s",text)) return SendClientMessage(playerid,COLOR_SYNTAX,"[SYNTAX]: /r [message]");
    for(new i; i < MAX_PLAYERS; i++)
       {
        if(PlayerInfo[i][Group] == 1)
        {
            new str[128],pName[MAX_PLAYER_NAME];
            GetPlayerName(playerid,pName,MAX_PLAYER_NAME);
            format(str,sizeof(str),"[Police Radio] %s %s: %s , Over.",GetRank(playerid),pName,text);
            SendClientMessage(i,COLOR_SYNTAX,str);
        }
    }
    return 1;
}

that Should working 99%

Re: Issue with my /r - Azzeto - 16.12.2011

@Jack Leslie, I did that, edited everything to my ranks and all, now it says Deputy Sheriff When Im rank six?

PHP код:



stock SDRank(playerid)
{
    new string[126];
    switch(PlayerInfo[playerid][Member]) // change to your rank variable
    {
        case 5: string = "Sheriff";
        case 4: string = "Under Sheriff";
        case 3: string = "Lieutenant";
        case 2: string = "Sergeant";
        case 1: string = "Deputy Sheriff Bonus";
        default: string = "Deputy Sheriff";
    }
    return string;
}

Re: Issue with my /r - PrawkC - 16.12.2011

Quote:

Originally Posted by Azzeto

@Jack Leslie, I did that, edited everything to my ranks and all, now it says Deputy Sheriff When Im rank six?

PHP код:



stock SDRank(playerid)

{

    new string[126];

    switch(PlayerInfo[playerid][Member]) // change to your rank variable

    {

        case 5: string = "Sheriff";

        case 4: string = "Under Sheriff";

        case 3: string = "Lieutenant";

        case 2: string = "Sergeant";

        case 1: string = "Deputy Sheriff Bonus";

        default: string = "Deputy Sheriff";

    }

    return string;

}

Seeing as you scripted it that way.. yeah... if member is equal to 6 it will use the default, you need to add a case 6.

Re: Issue with my /r - Jack_Leslie - 16.12.2011

Quote:

Originally Posted by Azzeto

@Jack Leslie, I did that, edited everything to my ranks and all, now it says Deputy Sheriff When Im rank six?

PHP код:



stock SDRank(playerid)

{

    new string[126];

    switch(PlayerInfo[playerid][Member]) // change to your rank variable

    {

        case 5: string = "Sheriff";

        case 4: string = "Under Sheriff";

        case 3: string = "Lieutenant";

        case 2: string = "Sergeant";

        case 1: string = "Deputy Sheriff Bonus";

        default: string = "Deputy Sheriff";

    }

    return string;

}

Because there's no case 6, so it uses default.

pawn Код:

stock SDRank(playerid)
{
    new string[126];
    switch(PlayerInfo[playerid][Member]) // change to your rank variable
    {
        case 6: string = "Sheriff";
        case 5: string = "Deputy Sheriff";
        case 4: string = "Under Sheriff";
        case 3: string = "Lieutenant";
        case 2: string = "Sergeant";
        case 1: string = "Deputy Sheriff Bonus";
        default: string = // If there is no case for the rank, or the rank is 0, it will use this;
    }
    return string;
}

Re: Issue with my /r - Azzeto - 16.12.2011

Ok, thanks Prawk and Leslie, much appriciated