Loop not working <.< - Printable Version

Loop not working <.< - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Loop not working <.< (/showthread.php?tid=300438)

Loop not working <.< - FireCat - 30.11.2011

Like, I have this loop, but I wan't to check if the player is in range of point of any "hot dog zone".
Even if he ain't, it doesn't say "You aren't near a hot dog stand" <.<

pawn Код:

for(new i, f = MAX_HOTDOGZONES; i < f; i++)
    {
        if(!IsPlayerInRangeOfPoint(playerid,5.0,HotDogPlace[i][0],HotDogPlace[i][1],HotDogPlace[i][2])) count++;
            else break;
        if(count == MAX_HOTDOGZONES) {SendClientMessage(playerid, Red, "« Error »"lyellow"You aren't near a hotdog stand!");break;}
    }

Re: Loop not working <.< - FireCat - 30.11.2011

Quote:

Originally Posted by ******

"else break;". I expected better of you!

Wait what? If he's near a hotdog stand, it breaks the loop! <.<
Whats wrong with that?

Re: Loop not working <.< - wumpyc - 30.11.2011

pawn Код:

if(!IsPlayerInRangeOfPoint(playerid,5.0,HotDogPlace[i][0],HotDogPlace[i][1],HotDogPlace[i][2])) count++;
            else break;
        if(count == MAX_HOTDOGZONES) {SendClientMessage(playerid, Red, "« Error »"lyellow"You aren't near a hotdog stand!");break;}

"playerid" should be "i"

Re: Loop not working <.< - ElkaBlazer - 30.11.2011

pawn Код:

for(new i, f = MAX_HOTDOGZONES; i < f; i++)
    {
        if(!IsPlayerInRangeOfPoint(i,5.0,HotDogPlace[i][0],HotDogPlace[i][1],HotDogPlace[i][2])) count++;
            else break;
        if(count == MAX_HOTDOGZONES//+1) {SendClientMessage(playerid, Red, "« Error »"lyellow"You aren't near a hotdog stand!");break;}
    }

The loop will work as long as i < f , not equals to f

then you checked if count is equals to max_hotdogzones, but it will never be equal to it ...

So you should check for the max zones or whatever +1

Another thing i noticed, is that u used playerif instead of i

Re: Loop not working <.< - Finn - 30.11.2011

Are you sure count is 0 when the loop starts?

Re: Loop not working <.< - [MWR]Blood - 30.11.2011

Quote:

Originally Posted by wumpyc

pawn Код:

if(!IsPlayerInRangeOfPoint(playerid,5.0,HotDogPlace[i][0],HotDogPlace[i][1],HotDogPlace[i][2])) count++;
            else break;
        if(count == MAX_HOTDOGZONES) {SendClientMessage(playerid, Red, "« Error »"lyellow"You aren't near a hotdog stand!");break;}

"playerid" should be "i"

Wait, what?! >.> i = hot dog zones. so, if we put i instead of playerid, we will be checking if the hot dog zones are near any hot dog zones...

Re: Loop not working <.< - [MG]Dimi - 30.11.2011

Maybe?

pawn Код:

for(new i;i <MAX_HOTDOGZONES;i++)
{
    if(!IsPlayerInRangeOfPoint(playerid,5.0,HotDogPlace[i][0],HotDogPlace[i][1],HotDogPlace[i][2])) count++;
    else break;
}
if(count == MAX_HOTDOGZONES) SendClientMessage(playerid, Red, "« Error »"lyellow"You aren't near a hotdog stand!");

Re: Loop not working <.< - FireCat - 30.11.2011

Quote:

Originally Posted by ******

Yeah, the "if count == whatever" should be outside the loop, not in it. And what's wrong with:

pawn Код:

for(new i; i < MAX_HOTDOGZONES; i++)

Isn't it you, who says

pawn Код:

for(new i; i < MAX_HOTDOGZONES; i++)

Is slower than

pawn Код:

for(new i, f = MAX_HOTDOGZONES; i < f; i++)

EDIT:
Whole cmd:

pawn Код:

CMD:sellhotdog(playerid,params[])
{
    if(subteam[playerid] != HOTDOG) return SendClientMessage(playerid,Red,"« Error » "lyellow"You must be a hotdog seller to use this command!");
    new id,price;
    if(sscanf(params,"ui",id,price)) return SendHelpMessage(playerid,"/sellhotdog [id] [price]","It will send a request to the specified id asking if he wants to accept your offer");
    if(!IsPlayerConnected(id)) return SendErrorMessage(playerid,1);
    static Float:x,Float:y,Float:z;
    GetPlayerPos(id,x,y,z);
    if(!IsPlayerInRangeOfPoint(playerid,10.0,x,y,z)) return SendClientMessage(playerid,Red,"« Error » "lyellow"You aren't near that player!");
    static count;
    for(new i;i <MAX_HOTDOGZONES;i++)
    {
        if(!IsPlayerInRangeOfPoint(playerid,5.0,HotDogPlace[i][0],HotDogPlace[i][1],HotDogPlace[i][2])) count++;
        else break;
    }
    if(count == MAX_HOTDOGZONES) return SendClientMessage(playerid, Red, "« Error »"lyellow"You aren't near a hotdog stand!"), count = 0;
    static string[128];
    format(string,sizeof string,"~p~~h~Hot dog seller: ~n~~r~Would you like to buy ~y~1 ~r~hot dog~n~~r~For ~y~$%i~r~?~n~~g~Press Y to buy or N to cancel",price);
    Info(id,string,6000);
    PInfo[id][HSeller] = playerid;
    PInfo[id][HPrice] = price;
    SendClientMessage(playerid, Red, "» "lyellow"Offer sent!");
    return 1;
}