Need Help with /slap - Printable Version

Need Help with /slap - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Need Help with /slap (/showthread.php?tid=296392)

Need Help with /slap - GAMER_PS2 - 11.11.2011

i'm making my own slap command but suddenly i have mistake in this part

pawn Код:

SetPlayerHealth(id,GetPlayerHealth(id) - 10.0);

i got those warnings:

Код:

H:\GTA San Andreas\SAMP Server\filterscripts\Admin.pwn(945) : warning 202: number of arguments does not match definition
H:\GTA San Andreas\SAMP Server\filterscripts\Admin.pwn(945) : warning 213: tag mismatch
Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


2 Warnings.

CODE:

pawn Код:

CMD:slap(playerid,params[])
{
    new id,
        reason[128],
        adminname[MAX_PLAYER_NAME],
        pname[MAX_PLAYER_NAME];
    GetPlayerName(id,pname,MAX_PLAYER_NAME);
    GetPlayerName(playerid,adminname,MAX_PLAYER_NAME);
    if(sscanf(params,"uz",id, reason)) return SendClientMessage(playerid,COLOR_RED,"USAGE: /slap <playername/id> <reason>");
    if(id == INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"ERROR: Player is not connected!");
    SetPlayerScore(id, GetPlayerHealth(id) - 10.0);
    PlayerPlaySound(1149,0,0,0,0);
    return 1;
}

Pls help ASAP

Re: Need Help with /slap - Cypress - 11.11.2011

pawn Код:

CMD:slap(playerid,params[])
{
    new id,
        reason[128],
        adminname[MAX_PLAYER_NAME],
        pname[MAX_PLAYER_NAME],
       Float:health;
    GetPlayerName(id,pname,MAX_PLAYER_NAME);
    GetPlayerName(playerid,adminname,MAX_PLAYER_NAME);
    if(sscanf(params,"us[128]",id, reason)) return SendClientMessage(playerid,COLOR_RED,"USAGE: /slap <playername/id> <reason>");
    if(id == INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"ERROR: Player is not connected!");
    GetPlayerHealth(id, health);
    SetPlayerHealth(id, health - 10.0);
    PlayerPlaySound(1149,0,0,0,0);
    return 1;
}

Re: Need Help with /slap - Biesmen - 11.11.2011

GetPlayerHealth doesn't work like that.
You have to store the health in a float, like this:

pawn Код:

new Float:hp;
GetPlayerHealth(id, hp);

Quote:

Originally Posted by Cypress

pawn Код:

SetPlayerScore(id, -1); // - the amount you want

Wow, that's just.. wow..
You're setting that player's score to -1. You aren't decreasing it. If you want to decrease it you need to use this:

pawn Код:

SetPlayerScore(id, GetPlayerScore(id)-10);

AW: Need Help with /slap - Drebin - 11.11.2011

pawn Код:

SetPlayerHealth(id, -10.0);

This set's the playerid's health to -10, but he wants to reduce the health by 10.
Try this:

pawn Код:

CMD:slap(playerid,params[])
{
    new id;
    new Float:health;
    new reason[128];
    new adminname[MAX_PLAYER_NAME], pname[MAX_PLAYER_NAME];
    GetPlayerName(id,pname,MAX_PLAYER_NAME);
    GetPlayerName(playerid,adminname,MAX_PLAYER_NAME);
    if(sscanf(params,"us[128]",id, reason)) return SendClientMessage(playerid,COLOR_RED,"USAGE: /slap <playername/id> <reason>");
    if(id == INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"ERROR: Player is not connected!");
    GetPlayerHealth(id, health);
    SetPlayerHealth(id, health -10.0);
    PlayerPlaySound(1149,0,0,0,0);
    return 1;
}

Re: Need Help with /slap - GAMER_PS2 - 11.11.2011

i only want is example my health is 100 when it gets slap it will be 90

Re: AW: Need Help with /slap - Cypress - 11.11.2011

Quote:

Originally Posted by Drebin

pawn Код:

SetPlayerHealth(id, -10.0);

This set's the playerid's health to -10, but he wants to reduce the health by 10:

pawn Код:

CMD:slap(playerid,params[])
{
    new id,
    new Float:health;
    reason[128],
    adminname[MAX_PLAYER_NAME],
    pname[MAX_PLAYER_NAME];
    GetPlayerName(id,pname,MAX_PLAYER_NAME);
    GetPlayerName(playerid,adminname,MAX_PLAYER_NAME);
    if(sscanf(params,"uz",id, reason)) return SendClientMessage(playerid,COLOR_RED,"USAGE: /slap <playername/id> <reason>");
    if(id == INVALID_PLAYER_ID) return SendClientMessage(playerid,COLOR_RED,"ERROR: Player is not connected!");
    GetPlayerHealth(id, health);
    SetPlayerHealth(id, health -10.0);
    PlayerPlaySound(1149,0,0,0,0);
    return 1;
}

pawn Код:

new id,
    new Float:health;
    reason[128],
    adminname[MAX_PLAYER_NAME],
    pname[MAX_PLAYER_NAME];

There is already a new parameter.

Quote:

Originally Posted by GAMER_PS2

i only want is example my health is 100 when it gets slap it will be 90

Check the command I posted above.

Re: Need Help with /slap - GAMER_PS2 - 11.11.2011

one problem

Код:

[14:53:52] sscanf warning: 'z' is deprecated, consider using 'S' instead.
[14:53:52] sscanf warning: No default value found.
[14:53:52] sscanf warning: Strings without a length are deprecated, please add a destination size.

Re: AW: Need Help with /slap - Biesmen - 11.11.2011

Quote:

Originally Posted by Cypress

pawn Код:

new id,
    new Float:health;
    reason[128],
    adminname[MAX_PLAYER_NAME],
    pname[MAX_PLAYER_NAME];

There is already a new parameter.

Mate, in that code above is no parameter at all. I don't even see a callback, stock, native, whatever. Or am I blind?

@GAMER_PS2
Use the code of Drebin, that one is fine. However if you want to slap someone to CHECK if he's hacking, then you shouldn't lower his HP by 10, but you should slap him high enough for him to lose HP. If he doesn't lose HP, he's hacking.

AW: Need Help with /slap - Drebin - 11.11.2011

fixd' my code.

Re: Need Help with /slap - Cypress - 11.11.2011

Quote:

Originally Posted by GAMER_PS2

one problem

Код:

[14:53:52] sscanf warning: 'z' is deprecated, consider using 'S' instead.
[14:53:52] sscanf warning: No default value found.
[14:53:52] sscanf warning: Strings without a length are deprecated, please add a destination size.

pawn Код:

if(sscanf(params,"us[128]",id, reason)) return SendClientMessage(playerid,COLOR_RED,"USAGE: /slap <playername/id> <reason>");