Timer problem - Printable Version

Timer problem - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+--- Thread: Timer problem (/showthread.php?tid=288067)

Timer problem - random123 - 06.10.2011

ok so i am trying to make a a text draw that shows up when you get shot and it tells you how much dmg you took, so far i have this, it compiles and when you get shot it shows you what you lost but the text draws do not go away.
this is my first attempt at using a timer so if someone could point me in the right direction I would appreciate it!

Код:

public OnPlayerShootPlayer(Shooter,Target,Float:HealthLost,Float:ArmourLost)
{
    new msg[128],name1[24],name2[24], msg2[128];
	dtxtdraw = TextDrawCreate(400.0,280.0, "~r~ -, health");
	dtxtdraz = TextDrawCreate(450.0,280.0, "~b~ -, armour");
	format(msg, sizeof(msg), "~r~ -%f, health", HealthLost);
	format(msg2, sizeof(msg2), "~b~ -%f, armour", ArmourLost);
	TextDrawSetString(dtxtdraw, msg);
	TextDrawSetString(dtxtdraz, msg2);
	TextDrawShowForPlayer(Target, dtxtdraw);
	TextDrawShowForPlayer(Target, dtxtdraz);
	timer1 = SetTimer("mytimer", 1000, false);
	GetPlayerName(Shooter,name1,24);
    GetPlayerName(Target,name2,24);
	CreateObject(1240, 0, 0, 0, 0.0, 0.0, 0.0, 0.0);
	AttachObjectToPlayer(1, Target, 0.0, 0.0, 1.0, 0, 0, 0);
 	return 1;

}
public mytimer(playerid)
{
	TextDrawHideForPlayer(playerid, dtxtdraw);
	TextDrawHideForPlayer(playerid, dtxtdraw);
	KillTimer(timer1);
	return 1;
}

Re: Timer problem - TheLazySloth - 06.10.2011

Код:

newtimer1[MAX_PLAYERS];forward mytimer(playerid);

public OnGameModeInit()
{dtxtdraw[MAX_PLAYERS] = TextDrawCreate(400.0,280.0, "~r~ -, health");
dtxtdraz[MAX_PLAYERS] = TextDrawCreate(450.0,280.0, "~b~ -, armour");
return 1;}

public OnPlayerShootPlayer(Shooter,Target,Float:HealthLost,Float:ArmourLost)
{new msg[128],
msg2[128];format(msg, sizeof(msg), "~r~ -%f, health", HealthLost);
format(msg2, sizeof(msg2), "~b~ -%f, armour", ArmourLost);

TextDrawSetString(dtxtdraw[playerid], msg);
TextDrawSetString(dtxtdraz[playerid], msg2);

TextDrawShowForPlayer(Target, dtxtdraw[playerid]);
TextDrawShowForPlayer(Target, dtxtdraz[playerid]);

timer1[playerid] = SetTimerEx("mytimer", 1000, false, "d", Target);
return 1;}

public mytimer(playerid)
{	TextDrawHideForPlayer(playerid, dtxtdraw[playerid]);
	TextDrawHideForPlayer(playerid, dtxtdraw[playerid]);
	KillTimer(timer1[playerid]);
	return 1;
}

The above code was posted by you, modified by me.
The above code was not tested!
The above code requires San Andreas Multiplayer 0.3d RC2 and up.

Do not forget to +rep me if this worked or explain further if the problem persists.

Re: Timer problem - System64 - 06.10.2011

try

pawn Код:

timer1 = SetTimerEx("mytimer", 1000, false, "d", playerid /*or try Target than playerid*/);

Re: Timer problem - TheLazySloth - 06.10.2011

@System64 that wont fully work because his variables arn't linked to the playerid.

@random123 My code should work, if it doesn't post compile errors here so I can fix.

Re: Timer problem - random123 - 06.10.2011

Quote:

Originally Posted by TheLazySloth

Код:

newtimer1[MAX_PLAYERS];forward mytimer(playerid);

public OnGameModeInit()
{dtxtdraw[MAX_PLAYERS] = TextDrawCreate(400.0,280.0, "~r~ -, health");
dtxtdraz[MAX_PLAYERS] = TextDrawCreate(450.0,280.0, "~b~ -, armour");
return 1;}

public OnPlayerShootPlayer(Shooter,Target,Float:HealthLost,Float:ArmourLost)
{new msg[128],
msg2[128];format(msg, sizeof(msg), "~r~ -%f, health", HealthLost);
format(msg2, sizeof(msg2), "~b~ -%f, armour", ArmourLost);

TextDrawSetString(dtxtdraw[playerid], msg);
TextDrawSetString(dtxtdraz[playerid], msg2);

TextDrawShowForPlayer(Target, dtxtdraw[playerid]);
TextDrawShowForPlayer(Target, dtxtdraz[playerid]);

timer1[playerid] = SetTimer("mytimer", 1000, false, "d", playerid);
return 1;}

public mytimer(playerid)
{	TextDrawHideForPlayer(playerid, dtxtdraw[playerid]);
	TextDrawHideForPlayer(playerid, dtxtdraw[playerid]);
	KillTimer(timer1[playerid]);
	return 1;
}

The above code was created by you, modified by me.
The above code was not tested!
The above code requires San Andreas Multiplayer 0.3d RC2 and up.

Do not forget to +rep me if this worked or explain further if the problem persists.

Thanks for the help but I am using .3c rc5

Quote:

Originally Posted by System64

try

pawn Код:

timer1 = SetTimerEx("mytimer", 1000, false, "d", playerid /*or try Target than playerid*/);

testing this now

Re: Timer problem - TheLazySloth - 06.10.2011

Quote:

Originally Posted by random123

Thanks for the help but I am using .3c rc5

Note how I said "and up" meaning 0.3d rc2 - rc5

Re: Timer problem - System64 - 06.10.2011

Quote:

Originally Posted by TheLazySloth

@System64 that wont fully work because his variables arn't linked to the playerid.

@random123 My code should work, if it doesn't post compile errors here so I can fix.

How I said, if playerid doesn't work than try Target or Shooter, you code won't work, It must be SetTimerEx not SetTimer and you also use playerid?

Re: Timer problem - TheLazySloth - 06.10.2011

Oh I used playerid because I am used to playerid not Target xD ... My bad.

The reason I say yours isn't going to work is because, say if three people get shot at the same exact time, all three players will get the third player's health loss and not their own.

Thats why this...

Код:

newtimer1[MAX_PLAYERS];forward mytimer(playerid);

public OnGameModeInit()
{dtxtdraw[MAX_PLAYERS] = TextDrawCreate(400.0,280.0, "~r~ -, health");
dtxtdraz[MAX_PLAYERS] = TextDrawCreate(450.0,280.0, "~b~ -, armour");
return 1;}

public OnPlayerShootPlayer(Shooter,Target,Float:HealthLost,Float:ArmourLost)
{new msg[128],
msg2[128];format(msg, sizeof(msg), "~r~ -%f, health", HealthLost);
format(msg2, sizeof(msg2), "~b~ -%f, armour", ArmourLost);

TextDrawSetString(dtxtdraw[Target], msg);
TextDrawSetString(dtxtdraz[Target], msg2);

TextDrawShowForPlayer(Target, dtxtdraw[Target]);
TextDrawShowForPlayer(Target, dtxtdraz[Target]);

timer1[Target] = SetTimerEx("mytimer", 1000, false, "d", Target);
return 1;}

public mytimer(playerid)
{	TextDrawHideForPlayer(playerid, dtxtdraw[playerid]);
	TextDrawHideForPlayer(playerid, dtxtdraw[playerid]);
	KillTimer(timer1[playerid]);
	return 1;
}

... is better.

You had the right idea, but it would've cause bugs.

Re: Timer problem - random123 - 07.10.2011

Quote:

Originally Posted by TheLazySloth

Oh I used playerid because I am used to playerid not Target xD ... My bad.

The reason I say yours isn't going to work is because, say if three people get shot at the same exact time, all three players will get the third player's health loss and not their own.

Thats why this...

Код:

newtimer1[MAX_PLAYERS];forward mytimer(playerid);

public OnGameModeInit()
{dtxtdraw[MAX_PLAYERS] = TextDrawCreate(400.0,280.0, "~r~ -, health");
dtxtdraz[MAX_PLAYERS] = TextDrawCreate(450.0,280.0, "~b~ -, armour");
return 1;}

public OnPlayerShootPlayer(Shooter,Target,Float:HealthLost,Float:ArmourLost)
{new msg[128],
msg2[128];format(msg, sizeof(msg), "~r~ -%f, health", HealthLost);
format(msg2, sizeof(msg2), "~b~ -%f, armour", ArmourLost);

TextDrawSetString(dtxtdraw[Target], msg);
TextDrawSetString(dtxtdraz[Target], msg2);

TextDrawShowForPlayer(Target, dtxtdraw[Target]);
TextDrawShowForPlayer(Target, dtxtdraz[Target]);

timer1[Target] = SetTimerEx("mytimer", 1000, false, "d", Target);
return 1;}

public mytimer(playerid)
{	TextDrawHideForPlayer(playerid, dtxtdraw[playerid]);
	TextDrawHideForPlayer(playerid, dtxtdraw[playerid]);
	KillTimer(timer1[playerid]);
	return 1;
}

... is better.

You had the right idea, but it would've cause bugs.

Ok i put it in and it compiled, will test in a bit

Re: Timer problem - random123 - 08.10.2011

Ok it works thanks for the help