[Help] Cant figure out how to fix these errors..

[Help] Cant figure out how to fix these errors.. - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Help Archive (https://sampforum.blast.hk/forumdisplay.php?fid=89)
+---- Thread: [Help] Cant figure out how to fix these errors.. (/showthread.php?tid=265201)

[Help] Cant figure out how to fix these errors.. - Lilrebel17 - 29.06.2011

Errors...

Код:

C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1114) : error 029: invalid expression, assumed zero
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1114) : error 004: function "OnPlayerDeath" is not implemented
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1114) : error 017: undefined symbol "reason"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1114) : fatal error 107: too many error messages on one line

Code around those lines...

Код:

return 1;
}
if(strcmp("/armory Grenade Upgrade",cmdtext,true,10) == 0)
{
if(GetPlayerMoney(playerid)>=2000)
{
if(GetPlayerTeam(playerid) == 3)
{
	GivePlayerMoney(playerid,-2000);
	GivePlayerWeapon(playerid,39,1000);
	GivePlayerWeapon(playerid,40,1000);
	SendClientMessage(playerid,COLOR_GREEN,"You just upgraded your Grenades");
}
else
{
SendClientMessage(playerid,COLOR_RED,"You must be a Grenadier to upgrade your Grenades");
	}
return 1;
	}
return 0;
	}
}
public OnPlayerDeath(playerid,killerid,reason)//this is line 1114
{
	if(IsPlayerConnected(killerid))
{
	GivePlayerMoney(killerid,200);
	GivePlayerMoney(playerid,-200);
	SpawnPlayer(playerid);
	SendClientMessage(killerid,COLOR_GREEN,"You just looted 500 dollars from the player you killed");
}
	return 1;
}

Re: [Help] Cant figure out how to fix these errors.. - Cyanide - 30.06.2011

Hey. In the future when you're posting codes, I suggest using DracoBlue's TidyPawn which will 'tidy' up your code to make it much easier to read. It's a very useful and free online tool. You should also check this tutorial out, because it seems you don't know how the function strcmp works. Enjoy.

The error is occuring most likely because you're placing your command code outside of the public function, in your case: OnPlayerCommandText should be the public function that your command should be placed in. Below is an example of how it should be placed.

pawn Код:

public OnPlayerCommandText( playerid, cmdtext[ ] )
{
     if( !strcmp( cmdtext, "/armoury", true ) )
     {
           // Code ... 
           return true; 
     }
     return false;
} 

public OnPlayerDeath( playerid, killerid, reason ) 
{   
      // Code
     return true;
}

Re: [Help] Cant figure out how to fix these errors.. - Lilrebel17 - 30.06.2011

Yeah I have all of them under OnPlayerCommandText....Im kinda new to scripting so seeing this question was noobie is kinda no surprise to meh lol

Edit: That didnt really fix the problem I tried that then tidied (Bad spelling) it up but I still get those errors.

Re: [Help] Cant figure out how to fix these errors.. - Shadoww5 - 30.06.2011

PHP код:



    if(strcmp("/armory Grenade Upgrade",cmdtext,true,10) == 0)
    {
        if(GetPlayerMoney(playerid)>=2000)
        {
            if(GetPlayerTeam(playerid) == 3)
            {
                GivePlayerMoney(playerid,-2000);
                GivePlayerWeapon(playerid,39,1000);
                GivePlayerWeapon(playerid,40,1000);
                SendClientMessage(playerid,COLOR_GREEN,"You just upgraded your Grenades");
            }
            else { SendClientMessage(playerid,COLOR_RED,"You must be a Grenadier to upgrade your Grenades"); }
        }
        return 1;
    }
    return 0;
}
public OnPlayerDeath(playerid,killerid,reason)//this is line 1114
{
    if(IsPlayerConnected(killerid))
    {
        GivePlayerMoney(killerid,200);
        GivePlayerMoney(playerid,-200);
        SpawnPlayer(playerid);
        SendClientMessage(killerid,COLOR_GREEN,"You just looted 500 dollars from the player you killed");
    }
    return 1;
}

Re: [Help] Cant figure out how to fix these errors.. - Lilrebel17 - 30.06.2011

Nope still didnt work...

Re: [Help] Cant figure out how to fix these errors.. - PCheriyan007 - 30.06.2011

Quote:

Originally Posted by Lilrebel17

Errors...

Код:

	GivePlayerMoney(killerid,200);
	GivePlayerMoney(playerid,-200);
	SpawnPlayer(playerid);
	SendClientMessage(killerid,COLOR_GREEN,"You just looted 500 dollars from the player you killed");

Since when is $200 suddenly $500. Also try doing this for giving players money on kill.

pawn Код:

new killcash = random(1500);
new string[128];
GivePlayerMoney(killerid, killcash);
GivePlayerMoney(playerid, -killcash);
SpawnPlayer(playerid);
format(string, sizeof(string), "You just killed %s and looted $%d from the them.", GetPlayerName(playerid), killcash);

Re: [Help] Cant figure out how to fix these errors.. - Lilrebel17 - 30.06.2011

Took off a single define I had at the top didnt know if mabye this is why someone couldnt figure it out well here is the updated errors and code..

Errors:

Код:

C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1757) : error 029: invalid expression, assumed zero
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1757) : error 004: function "OnPlayerDeath" is not implemented
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1758) : error 017: undefined symbol "killerid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1761) : error 017: undefined symbol "killerid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1764) : warning 202: number of arguments does not match definition
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1764) : warning 202: number of arguments does not match definition
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1768) : warning 225: unreachable code
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1768) : error 029: invalid expression, assumed zero
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1768) : error 004: function "OnPlayerRequestClass" is not implemented
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1769) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1779) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1789) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1799) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1809) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1819) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1829) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1839) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1849) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1859) : error 017: undefined symbol "classid"
C:\Users\Zack Farmer\Desktop\Lilrebels Folder\BCWAR.pwn(1872) : error 030: compound statement not closed at the end of file (started at line 1719)
Pawn compiler 3.2.3664	 	 	Copyright © 1997-2006, ITB CompuPhase


17 Errors.

Code:

Код:

                if(strcmp("/armory Grenade Upgrade",cmdtext,true,10) == 0) {
                    if(GetPlayerMoney(playerid)>=2000) {
                        if(GetPlayerTeam(playerid) == 3) {
                            GivePlayerMoney(playerid,-2000);
                            GivePlayerWeapon(playerid,39,1000);
                            GivePlayerWeapon(playerid,40,1000);
                            SendClientMessage(playerid,COLOR_GREEN,"You just upgraded your Grenades");
                        }
                        else { SendClientMessage(playerid,COLOR_RED,"You must be a Grenadier to upgrade your Grenades"); }
                    }
                    return 1;
                }
                return 0;
            }
//this is line 1756
            public OnPlayerDeath(playerid,killerid,reason) {
                if(IsPlayerConnected(killerid)) {
                    new killcash = random(1500);
                    new string[128];
                    GivePlayerMoney(killerid, killcash);
                    GivePlayerMoney(playerid, -killcash);
                    SpawnPlayer(playerid);
                    format(string, sizeof(string), "You just killed %s and looted $%d from the them.", GetPlayerName(playerid), killcash);
                }
                return 1;
            }

Re: [Help] Cant figure out how to fix these errors.. - Lilrebel17 - 30.06.2011

Ok so I fixed it mostly I still got 1 error its a missing bracket somewhere but I cant find where...mabye someone can spot it...

code:

Код:

            if(strcmp("/armory Sniper Upgrade",cmdtext,true,10) == 0) {
                if(GetPlayerMoney(playerid)>=2000) {
                    if(GetPlayerTeam(playerid) == 5) {
                        GivePlayerMoney(playerid,-2000);
                        GivePlayerWeapon(playerid,34,1000);
                        SendClientMessage(playerid,COLOR_GREEN,"You have just upgraded your Sniper");
                    }
                    else {
                        SendClientMessage(playerid,COLOR_RED,"You are either not a Sniper or dont have the right amount of money.");
                    }
                    return 1;
                }
                if(strcmp("/armory Grenade Upgrade",cmdtext,true,10) == 0) {
                    if(GetPlayerMoney(playerid)>=2000) {
                        if(GetPlayerTeam(playerid) == 3) {
                            GivePlayerMoney(playerid,-2000);
                            GivePlayerWeapon(playerid,39,1000);
                            GivePlayerWeapon(playerid,40,1000);
                            SendClientMessage(playerid,COLOR_GREEN,"You just upgraded your Grenades");
                        }
                        else {
                            SendClientMessage(playerid,COLOR_RED,"You must be a Grenadier to upgrade your Grenades");
                        }
                        return 1;
                    }
                    return 0;
				}

Re: [Help] Cant figure out how to fix these errors.. - Jay. - 30.06.2011

pawn Код:

if(strcmp("/armory Sniper Upgrade",cmdtext,true,10) == 0) {
                if(GetPlayerMoney(playerid)>=2000)
                {
                    if(GetPlayerTeam(playerid) == 5)
                    {
                        GivePlayerMoney(playerid,-2000);
                        GivePlayerWeapon(playerid,34,1000);
                        SendClientMessage(playerid,COLOR_GREEN,"You have just upgraded your Sniper");
                    }
                    else
                    {
                        SendClientMessage(playerid,COLOR_RED,"You are either not a Sniper or dont have the right         amount of money.");
                    }
                    return 1;
                }
                if(strcmp("/armory Grenade Upgrade",cmdtext,true,10) == 0)
                {
                    if(GetPlayerMoney(playerid)>=2000)
                    {
                        if(GetPlayerTeam(playerid) == 3)
                        {
                            GivePlayerMoney(playerid,-2000);
                            GivePlayerWeapon(playerid,39,1000);
                            GivePlayerWeapon(playerid,40,1000);
                            SendClientMessage(playerid,COLOR_GREEN,"You just upgraded your Grenades");
                        }
                        }
                        else 
                        {
                            SendClientMessage(playerid,COLOR_RED,"You must be a Grenadier to upgrade your Grenades");
                        }
                        return 1;
                    }
                    return 0;
                }

maybe it works. i don't know

Re: [Help] Cant figure out how to fix these errors.. - Lilrebel17 - 30.06.2011

IT FIXED!! Thank you guys!