Could this work? please answer!

Could this work? please answer! - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Help Archive (https://sampforum.blast.hk/forumdisplay.php?fid=89)
+---- Thread: Could this work? please answer! (/showthread.php?tid=239720)

Could this work? please answer! - ricardo178 - 14.03.2011

Hey guys... i am at school and i have no gta here... I made this ban code and i wanna know if it cvould work....
Please give a look, it compile without erros/warmnings...

pawn Код:

Command_ban(playerid, params[])
{
    if(IsPlayerConnected(id))
    {
        if(IsPlayerAdmin(playerid))
        {
            new id;
            if(!sscanf(params, "ui", id))
            {
                new string[64];
                new name[MAX_PLAYER_NAME], PlayerName[MAX_PLAYER_NAME], text[PLAYER_TEXT];
                GetPlayerName(playerid, name, sizeof(name));
                GetPlayerName(id, PlayerName, sizeof(PlayerName));
                GetPlayerText(playerid, text, sizeof(text));
                format(string, sizeof(string), "You has been banned by %s, reason %d", name, text);
                SendClientMessage(playerid, 0x0259EAAA, string);
                format(string, sizeof(string), "You banned %s.)
                SendClientMessage(playerid, 0x0259EAAA, string);
                BanPlayer(id);
            }
            else return SendClientMessage(playerid, 0x0259EAAA, "USAGE: /ban [PlayerId/PartOfName] [Reason]");
        }
        else return SendClientMessage(playerid, 0x0259EAAA, "You are not admin.");
    }
    else return SendClientMessage(playerid, 0x0259EAAA, "Player is not connected.");
}

Re: Could this work? please answer! - Macluawn - 14.03.2011

No, it wouldn't work.

Re: Could this work? please answer! - HyperZ - 14.03.2011

Use this:

pawn Код:

CMD:ban( playerid, params[ ] )
{
    new ID, string[128], reason[66];
    if(!IsPlayerAdmin(playerid)) return SendClientMessage(playerid, 0x0259EAAA, "You are not admin.");
    if(sscanf(params, "uS(No Reason Given)[65]", ID, reason)) return SendClientMessage(playerid, 0x0259EAAA, "USAGE: /ban [PlayerID] [reason]");
    if(IsPlayerConnected(ID) && ID != INVALID_PLAYER_ID && ID != playerid)
    {
        format(string,sizeof(string), "You have been Banned by Administrator \"%s\" Reason: %s", pName(playerid),reason);
        SendClientMessage(ID, 0x0259EAAA, string);
        format(string, sizeof(string), "You have Banned \"%s\" Reason: %s", pName(ID), reason);
        SendClientMessage(playerid, 0x0259EAAA , string);
        format(string, sizeof(string), "Administrator \"%s\" has Banned \"%s\" Reason: %s",pName(playerid),pName(ID),reason);
        SendClientMessageToAll( 0x0259EAAA , string );
        TogglePlayerControllable(ID, false);
        Ban(ID);
    }
    else return SendClientMessage(playerid, -1, "Player is not connected or is yourself");
    return 1;
}

Somewhere in your script:

pawn Код:

stock pName(playerid)
{
    new Name[MAX_PLAYER_NAME];
    GetPlayerName(playerid, Name, sizeof(Name));
    return Name;
}

Re: Could this work? please answer! - Macluawn - 14.03.2011

Clive, your example wouldn't let administrators execute the command, but non-administrators could.

Re: Could this work? please answer! - Markx - 14.03.2011

pawn Код:

CMD:ban(playerid, params[])
{
    //Is Player Admin script here
    {
        new pID, Msg[128];
        if(sscanf(params, "us[60]", pID, params)) return SendClientMessage(playerid, COLOR_RED, "* Usage: /Ban < Player ID > < Reason >");

        if(!IsPlayerConnected(pID)) return SendClientMessage(playerid, COLOR_RED, "That user is not connected!");

        format(Msg, sizeof(Msg), "Admin: %s(%d) has banned: %s(%d) for: %s", pName(playerid), playerid, pName(pID), pID, params);
        SendClientMessageToAll(COLOR_GREY, Msg);

        return BanEx(pID, "Admin Ban!");
    }
    else return SendClientMessage(playerid, COLOR_RED, "This command is for admin lvl 3 + only!");
}

Re: Could this work? please answer! - HyperZ - 14.03.2011

Quote:

Originally Posted by Macluawn

Clive, your example wouldn't let administrators execute the command, but non-administrators could.

+1. :P
Srry i was frgt "!"

i've edited ma post.

Edit: i lol'd @ Markx.

Re: Could this work? please answer! - ricardo178 - 14.03.2011

Hey guys!!! The only think that shouldn't work is the reazon...
If i remove the reazon i am sure it work! I just wanna know, how do the server get the reazon!
I used GetPlayerText and i have no idea if this exist!

Re: Could this work? please answer! - ricardo178 - 14.03.2011

ok, this work well, but don't ask for reazon... just ban! I want this to tell the reazin too! But in my script form... Or just tell me what to add! THANKS

pawn Код:

COMMAND:iban(playerid, params[])
{
    new id;
    if(IsPlayerConnected(id))
    {
        if(IsPlayerAdmin(playerid))
        {
            if(!sscanf(params, "ui", id))
            {
                new string[64];
                new name[MAX_PLAYER_NAME], PlayerName[MAX_PLAYER_NAME];
                GetPlayerName(playerid, name, sizeof(name));
                GetPlayerName(id, PlayerName, sizeof(PlayerName));
                format(string, sizeof(string), "You has been banned by %s.", name);
                SendClientMessage(playerid, 0x0259EAAA, string);
                format(string, sizeof(string), "You banned %s.", id);
                SendClientMessage(playerid, 0x0259EAAA, string);
                Ban(id);
                return 1;
            }
            else return SendClientMessage(playerid, 0x0259EAAA, "USAGE: /ban [PlayerId/PartOfName]");
        }
        else return SendClientMessage(playerid, 0x0259EAAA, "You are not admin.");
    }
    else return SendClientMessage(playerid, 0x0259EAAA, "Player is not connected.");
}