SA-MP Forums Archive
What's wrong with this /park? - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Help Archive (https://sampforum.blast.hk/forumdisplay.php?fid=89)
+---- Thread: What's wrong with this /park? (/showthread.php?tid=234093)


What's wrong with this /park? - Ferrari123 - 03.03.2011

I've made a /park command to go along with my car dealership and it's quite basic, though it doesn't show any text, nor does it work when I use it. If anyone could point out to me what's wrong, that'd be good.

Код:
if(strcmp(cmd, "/park", true) == 0)
	{
	    new name[MAX_PLAYERS];
		new Float:x,Float:y,Float:z;
		new Float:a;
		new carid;
		new getcarid;
		if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey]) { carid = PlayerInfo[playerid][pPcarkey]; }
		else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey2]) { carid = PlayerInfo[playerid][pPcarkey2]; }
		else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey3]) { carid = PlayerInfo[playerid][pPcarkey3]; }
		else { return 1; }
		getcarid = GetPlayerVehicleID(playerid);
		GetPlayerName(playerid, name, sizeof (name));
		GetVehiclePos(carid, x, y, z);
		//GetPlayerFacingAngle(playerid, a);
		GetVehicleZAngle(carid, a);
		if(IsPlayerInVehicle(playerid,carid) && CarInfo[carid][cOwned] == 1)
		{
			if(PlayerInfo[playerid][pPcarkey] == 999 && PlayerInfo[playerid][pPcarkey2] == 999 & PlayerInfo[playerid][pPcarkey3])
			{
				SendClientMessage(playerid, COLOR_GREY, "You don't own a car.");
				return 1;
			}
			if(getcarid == carid)
			{
				CarInfo[carid][cLocationx] = x;
				CarInfo[carid][cLocationy] = y;
				CarInfo[carid][cLocationz] = z;
				CarInfo[carid][cAngle] = a;
				format(string, sizeof(string), "~n~ You have parked your vehicle in this location. ~n~");
				GameTextForPlayer(playerid, "~r~You have parked your vehicle in this position. It will respawn here.", 10000, 3);
				OnPropUpdate();
				OnPlayerUpdate(playerid);
				DestroyVehicle(carid);
				CreateVehicle(CarInfo[carid][cModel],CarInfo[carid][cLocationx],CarInfo[carid][cLocationy],CarInfo[carid][cLocationz]+1.0,CarInfo[carid][cAngle],CarInfo[carid][cColorOne],CarInfo[carid][cColorTwo],7200000);
				TogglePlayerControllable(playerid, 1);
				return 1;
			}
		}
	}


Re: What's wrong with this /park? - YungGee - 03.03.2011

dude return it -.-

Re: What's wrong with this /park? - Ferrari123 - 03.03.2011

Look at the code, I did return it

Re: What's wrong with this /park? - YungGee - 03.03.2011

the last return i see is returning this: if(getcarid == carid)

...

I dont see the command being returned..Shall i show u?

Re: What's wrong with this /park? - Ferrari123 - 03.03.2011

Yes, because I'm not seeing anything wrong with that

Re: What's wrong with this /park? - YungGee - 03.03.2011

pawn Код:
if(strcmp(cmd, "/park", true) == 0)
    {
        new name[MAX_PLAYERS];
        new Float:x,Float:y,Float:z;
        new Float:a;
        new carid;
        new getcarid;
              
        if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey]) { carid = PlayerInfo[playerid][pPcarkey]; }
        else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey2]) { carid = PlayerInfo[playerid][pPcarkey2]; }
        else if(GetPlayerVehicleID(playerid) == PlayerInfo[playerid][pPcarkey3]) { carid = PlayerInfo[playerid][pPcarkey3]; }
        else { return 1; }
        getcarid = GetPlayerVehicleID(playerid);
        GetPlayerName(playerid, name, sizeof (name));
        GetVehiclePos(carid, x, y, z);
        //GetPlayerFacingAngle(playerid, a);
        GetVehicleZAngle(carid, a);
 //below is the starting if statement u forgot to return..
        if(IsPlayerInVehicle(playerid,carid) && CarInfo[carid][cOwned] == 1)
        {
            if(PlayerInfo[playerid][pPcarkey] == 999 && PlayerInfo[playerid][pPcarkey2] == 999 & PlayerInfo[playerid][pPcarkey3])
            {
                SendClientMessage(playerid, COLOR_GREY, "You don't own a car.");
                return 1;
            }
            if(getcarid == carid)
            {
                CarInfo[carid][cLocationx] = x;
                CarInfo[carid][cLocationy] = y;
                CarInfo[carid][cLocationz] = z;
                CarInfo[carid][cAngle] = a;
                format(string, sizeof(string), "~n~ You have parked your vehicle in this location. ~n~");
                GameTextForPlayer(playerid, "~r~You have parked your vehicle in this position. It will respawn here.", 10000, 3);
                OnPropUpdate();
                OnPlayerUpdate(playerid);
                DestroyVehicle(carid);
                CreateVehicle(CarInfo[carid][cModel],CarInfo[carid][cLocationx],CarInfo[carid][cLocationy],CarInfo[carid][cLocationz]+1.0,CarInfo[carid][cAngle],CarInfo[carid][cColorOne],CarInfo[carid][cColorTwo],7200000);
                TogglePlayerControllable(playerid, 1);
                return 1;
            }
        }
                return 1;//missing return
}
Should work fine now..

EDIT: comment fixed may have loose indentations