Two big problems (extra parameters & adminchat)

Two big problems (extra parameters & adminchat) - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Help Archive (https://sampforum.blast.hk/forumdisplay.php?fid=89)
+---- Thread: Two big problems (extra parameters & adminchat) (/showthread.php?tid=201302)

Two big problems (extra parameters & adminchat) - admantis - 20.12.2010

I have 2 problems
1) Problem 1: when i type /a it shows 'USAGE: /a(dmin) [text]' but if i type text it only shows 'Administrator Admantis:' but the text isn't showing.

pawn Код:

if (strcmp("/a",cmd, true) == 0 || strcmp("/admin",cmd,true)==0)
    {
        tmp = strtok(cmdtext,idx);
        if(!strlen(tmp))
        {
                return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");
        }
        new msg = strval(tmp);
        new seniormsg[128], juniormsg[128], leadmsg[128];
        GetPlayerName(playerid,seniormsg,sizeof(seniormsg));
        GetPlayerName(playerid,juniormsg,sizeof(juniormsg));
        format(seniormsg,sizeof(seniormsg),"Senior Administrator %s: %s",seniormsg,msg);
        format(juniormsg,sizeof(juniormsg),"Junior Administrator %s: %s",juniormsg,msg);
        format(leadmsg,sizeof(leadmsg),"Lead Administrator %s: %s",leadmsg,msg);
        if (PlayerInfo[playerid][pAdminLevel] == 1) SendAdminMessage(COLOR_LIGHTGREEN, juniormsg);
        if (PlayerInfo[playerid][pAdminLevel] == 2) SendAdminMessage(COLOR_LIGHTGREEN, seniormsg);
        if (PlayerInfo[playerid][pAdminLevel] == 3) SendAdminMessage(COLOR_LIGHTGREEN, leadmsg);
        return 1;
    }

stock SendAdminMessage(color,const string[])
{
    for(new i = 0; i < MAX_PLAYERS; i++)
    {
        if(IsPlayerConnected(i) == 1) if(PlayerInfo[i][pAdminLevel] > 0) SendClientMessage(i, color, string);
    }
    return 1;
}

2nd Problem: I have this script which works like /givepermisson [id] [ammount] but when I type the number like /givepermisson 0 5 it will give me like 53 permissons or any random high number like 49 53 56..

pawn Код:

if(strcmp("/givepermisson", cmd, true) == 0)
    {
        if(PlayerInfo[playerid][pAdminLevel] == 3)
        {
            tmp = strtok(cmdtext,idx);
            if(!strlen(tmp))
            {
                return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /givepermisson [id] [ammount]");
            }
            new amm[MAX_PLAYERS]; // amm = AMMount
            amm = strrest(cmdtext, idx);
            if (!strlen(amm)) SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /givepermisson [id] [givepermisson]");
            new id = strval(tmp);
            new pid = playerid;
            if(!IsPlayerConnected(id))
            {
                return SendClientMessage(playerid,COLOR_GRAY,"AdmCmd: This player is not online!");
            }
            if (PlayerInfo[id][pPermissons] < 500)
            {
                new amsg[100];
                new victimid[MAX_PLAYERS];
                GetPlayerName(id, victimid, sizeof(victimid));
                format(amsg,sizeof(amsg),"AdmCmd: You have given %s %d permissons!",victimid,amm);
                SendClientMessage(pid,COLOR_LIGHTBLUE,amsg);
                PlayerInfo[id][pPermissons] = PlayerInfo[id][pPermissons] + amm[playerid];
                PlayHintSoundAtPos(playerid);
                return 1;
            }
            else SendClientMessage(pid,COLOR_GRAY,"AdmCmd: This player already haves too many permissons (over 100)!");
        }
        else
        {
            SendClientMessage(playerid,COLOR_GRAY,"You don't have authorization.");
            return 1;
        }
    }

Thanks

Re: Two big problems (extra parameters & adminchat) - willsuckformoney - 20.12.2010

pawn Код:

if (strcmp("/a",cmd, true) == 0 || strcmp("/admin",cmd,true)==0)
    {
        tmp = strtok(cmdtext,idx); new msg = strval(tmp);
        if(!strlen(msg)) return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");
        new seniormsg[128], juniormsg[128], leadmsg[128];
        GetPlayerName(playerid,seniormsg,sizeof(seniormsg));
        GetPlayerName(playerid,juniormsg,sizeof(juniormsg));
        format(seniormsg,sizeof(seniormsg),"Senior Administrator %s: %s",seniormsg,msg);
        format(juniormsg,sizeof(juniormsg),"Junior Administrator %s: %s",juniormsg,msg);
        format(leadmsg,sizeof(leadmsg),"Lead Administrator %s: %s",leadmsg,msg);
        if (PlayerInfo[playerid][pAdminLevel] == 1) SendAdminMessage(COLOR_LIGHTGREEN, juniormsg);
        if (PlayerInfo[playerid][pAdminLevel] == 2) SendAdminMessage(COLOR_LIGHTGREEN, seniormsg);
        if (PlayerInfo[playerid][pAdminLevel] == 3) SendAdminMessage(COLOR_LIGHTGREEN, leadmsg);
        return 1;
    }

EDIT:

pawn Код:

if(strcmp("/givepermisson", cmd, true) == 0)
    {
        if(PlayerInfo[playerid][pAdminLevel] == 3)
        {
            tmp = strtok(cmdtext,idx);
            new amm[MAX_PLAYERS]; // amm = AMMount
            amm = strrest(cmdtext, idx);
            if (!strlen(amm)) SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /givepermisson [id] [givepermisson]");
            new id = strval(tmp);
            new pid = playerid;
            if(!strlen(tmp))
            {
                return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /givepermisson [id] [ammount]");
            }
            if(!IsPlayerConnected(id))
            {
                return SendClientMessage(playerid,COLOR_GRAY,"AdmCmd: This player is not online!");
            }
            if (PlayerInfo[id][pPermissons] < 500)
            {
                new amsg[100];
                new victimid[MAX_PLAYERS];
                GetPlayerName(id, victimid, sizeof(victimid));
                format(amsg,sizeof(amsg),"AdmCmd: You have given %s %d permissons!",victimid,amm);
                SendClientMessage(pid,COLOR_LIGHTBLUE,amsg);
                PlayerInfo[id][pPermissons] = PlayerInfo[id][pPermissons] + amm[playerid];
                PlayHintSoundAtPos(playerid);
                return 1;
            }
            else SendClientMessage(pid,COLOR_GRAY,"AdmCmd: This player already haves too many permissons (over 100)!");
        }
        else
        {
            SendClientMessage(playerid,COLOR_GRAY,"You don't have authorization.");
            return 1;
        }
    }

strlen and IsPlayerConnected comes after the variables, getting player name etc.

Respuesta: Re: Two big problems (extra parameters & adminchat) - admantis - 20.12.2010

Quote:

Originally Posted by willsuckformoney

pawn Код:

if (strcmp("/a",cmd, true) == 0 || strcmp("/admin",cmd,true)==0)
    {
        tmp = strtok(cmdtext,idx); new msg = strval(tmp);
        if(!strlen(msg)) return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");
        new seniormsg[128], juniormsg[128], leadmsg[128];
        GetPlayerName(playerid,seniormsg,sizeof(seniormsg));
        GetPlayerName(playerid,juniormsg,sizeof(juniormsg));
        format(seniormsg,sizeof(seniormsg),"Senior Administrator %s: %s",seniormsg,msg);
        format(juniormsg,sizeof(juniormsg),"Junior Administrator %s: %s",juniormsg,msg);
        format(leadmsg,sizeof(leadmsg),"Lead Administrator %s: %s",leadmsg,msg);
        if (PlayerInfo[playerid][pAdminLevel] == 1) SendAdminMessage(COLOR_LIGHTGREEN, juniormsg);
        if (PlayerInfo[playerid][pAdminLevel] == 2) SendAdminMessage(COLOR_LIGHTGREEN, seniormsg);
        if (PlayerInfo[playerid][pAdminLevel] == 3) SendAdminMessage(COLOR_LIGHTGREEN, leadmsg);
        return 1;
    }

pawn Код:

C:\Archivos de programa\Rockstar Games\GTA San Andreas\San Fierro Harbor\0.3b\gamemodes\sanfierroharbor.pwn(1216) : error 035: argument type mismatch (argument 1)

if(!strlen(msg)) return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");

Re: Two big problems (extra parameters & adminchat) - willsuckformoney - 20.12.2010

pawn Код:

if(!strlen(tmp)) return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");

Try that then.

EDIT: Check my first post again.

Respuesta: Re: Two big problems (extra parameters & adminchat) - admantis - 20.12.2010

Quote:

Originally Posted by willsuckformoney

pawn Код:

if(!strlen(tmp)) return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");

Try that then.

EDIT: Check my first post again.

No errors but I have the same bug.
'Lead Administrator Admantis:' but no text after /admin

pawn Код:

if (strcmp("/a",cmd, true) == 0 || strcmp("/admin",cmd,true)==0)
    {
        tmp = strtok(cmdtext,idx); new msg = strval(tmp);
        if(!strlen(tmp)) return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");
        new seniormsg[128], juniormsg[128], leadmsg[128];
        GetPlayerName(playerid,seniormsg,sizeof(seniormsg));
        GetPlayerName(playerid,juniormsg,sizeof(juniormsg));
        GetPlayerName(playerid,leadmsg,sizeof(leadmsg));
        format(seniormsg,sizeof(seniormsg),"Senior Administrator %s: %s",seniormsg,msg);
        format(juniormsg,sizeof(juniormsg),"Junior Administrator %s: %s",juniormsg,msg);
        format(leadmsg,sizeof(leadmsg),"Lead Administrator %s: %s",leadmsg,msg);
        if (PlayerInfo[playerid][pAdminLevel] == 1) SendAdminMessage(COLOR_LIGHTGREEN, juniormsg);
        if (PlayerInfo[playerid][pAdminLevel] == 2) SendAdminMessage(COLOR_LIGHTGREEN, seniormsg);
        if (PlayerInfo[playerid][pAdminLevel] == 3) SendAdminMessage(COLOR_LIGHTGREEN, leadmsg);
        return 1;
    }

Re: Two big problems (extra parameters & adminchat) - willsuckformoney - 20.12.2010

Try replacing SendAdminMessage with SendClientMessage, may not work. Looking at something else too.

EDIT: You have sscanf and zcmd?

Respuesta: Re: Two big problems (extra parameters & adminchat) - admantis - 20.12.2010

Quote:

Originally Posted by willsuckformoney

Try replacing SendAdminMessage with SendClientMessage, may not work. Looking at something else too.

EDIT: You have sscanf and zcmd?

pawn Код:

stock SendAdminMessage(color,const string[])
{
    for(new i = 0; i < MAX_PLAYERS; i++)
    {
        if(IsPlayerConnected(i) == 1) if(PlayerInfo[i][pAdminLevel] > 0) SendClientMessage(i, color, string);
    }
    return 1;
}

Thats wat does SendAdminMessage, loop, check if players are admin and Send a client message so I doubt that's the problem.

And no I don't know how to use sscanf or zcmd, only strtok with strcmp but im very used to it so I dont care

Re: Two big problems (extra parameters & adminchat) - willsuckformoney - 20.12.2010

pawn Код:

CMD:admin(playerid,params[])
{
    tmp = strtok(cmdtext,idx);
    new msg = strval(tmp);
    if(!strlen(tmp)) return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");
    new seniormsg[128], juniormsg[128], leadmsg[128], Name[24];
    GetPlayerName(playerid,Name,24);
    format(seniormsg,sizeof(seniormsg),"Senior Administrator %s: %s",name,msg);
    format(juniormsg,sizeof(juniormsg),"Junior Administrator %s: %s",name,msg);
    format(leadmsg,sizeof(leadmsg),"Lead Administrator %s: %s",name,msg);
    if (PlayerInfo[playerid][pAdminLevel] == 1) SendAdminMessage(COLOR_LIGHTGREEN, juniormsg);
    else if (PlayerInfo[playerid][pAdminLevel] == 2) SendAdminMessage(COLOR_LIGHTGREEN, seniormsg);
    else if (PlayerInfo[playerid][pAdminLevel] == 3) SendAdminMessage(COLOR_LIGHTGREEN, leadmsg);
    return 1;
}

Respuesta: Re: Two big problems (extra parameters & adminchat) - admantis - 20.12.2010

Quote:

Originally Posted by willsuckformoney

pawn Код:

CMD:admin(playerid,params[])
{
    tmp = strtok(cmdtext,idx);
    new msg = strval(tmp);
    if(!strlen(tmp)) return SendClientMessage(playerid,COLOR_LIGHTRED,"USAGE: /a(admin) [text]");
    new seniormsg[128], juniormsg[128], leadmsg[128], Name[24];
    GetPlayerName(playerid,Name,24);
    format(seniormsg,sizeof(seniormsg),"Senior Administrator %s: %s",name,msg);
    format(juniormsg,sizeof(juniormsg),"Junior Administrator %s: %s",name,msg);
    format(leadmsg,sizeof(leadmsg),"Lead Administrator %s: %s",name,msg);
    if (PlayerInfo[playerid][pAdminLevel] == 1) SendAdminMessage(COLOR_LIGHTGREEN, juniormsg);
    else if (PlayerInfo[playerid][pAdminLevel] == 2) SendAdminMessage(COLOR_LIGHTGREEN, seniormsg);
    else if (PlayerInfo[playerid][pAdminLevel] == 3) SendAdminMessage(COLOR_LIGHTGREEN, leadmsg);
    return 1;
}

isnt "Name" and "name" different? I mean, because it's case sensitive, right?

pawn Код:

C:\Archivos de programa\Rockstar Games\GTA San Andreas\San Fierro Harbor\0.3b\gamemodes\sanfierroharbor.pwn(1236) : error 017: undefined symbol "name"
C:\Archivos de programa\Rockstar Games\GTA San Andreas\San Fierro Harbor\0.3b\gamemodes\sanfierroharbor.pwn(1237) : error 017: undefined symbol "name"
C:\Archivos de programa\Rockstar Games\GTA San Andreas\San Fierro Harbor\0.3b\gamemodes\sanfierroharbor.pwn(1238) : error 017: undefined symbol "name"
Pawn compiler 3.2.3664          Copyright (c) 1997-2006, ITB CompuPhase


3 Errors.

Re: Two big problems (extra parameters & adminchat) - willsuckformoney - 20.12.2010

Yeah, my bad.
Replace these lines

pawn Код:

format(seniormsg,sizeof(seniormsg),"Senior Administrator %s: %s",name,msg);
    format(juniormsg,sizeof(juniormsg),"Junior Administrator %s: %s",name,msg);
    format(leadmsg,sizeof(leadmsg),"Lead Administrator %s: %s",name,msg);

with these

pawn Код:

format(seniormsg,sizeof(seniormsg),"Senior Administrator %s: %s",Name,msg);
    format(juniormsg,sizeof(juniormsg),"Junior Administrator %s: %s",Name,msg);
    format(leadmsg,sizeof(leadmsg),"Lead Administrator %s: %s",Name,msg);