Question - Printable Version

Question - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Help Archive (https://sampforum.blast.hk/forumdisplay.php?fid=89)
+---- Thread: Question (/showthread.php?tid=182065)

Question - Scriptissue - 08.10.2010

How can I make a script or feature that allows to get the players location, such as /trace, I tired using getplayerpos but It didn't work, the main point is to send a client message of the location of the player who will be traced.
Can any one help me with that ? >.

Re: Question - Sascha - 08.10.2010

as dcmd:

Код:

public OnPlayerCommandText(playerid, cmdtext[])
{
 dcmd(trace, 5, cmdtext);
 return 1;
}

Код:

dcmd_trace(playerid, params[])
{
 if(!strlen(params)){
  SendClientMessage(playerid, YOURCOLOR, "/trace [id]");
  return 1;
 }
 new pid = strval(params);
 if(!IsPlayerConnected(pid)){
  SendClientMessage(playerid, YOURCOLOR, "Player is not connected");
  return 1;
 }else{
  new string[256], name[MAX_PLAYER_NAME], Float:x, Float:y, Float:z;
  GetPlayerName(pid, name, sizeof(name));
  GetPlayerPos(pid, x, y, z);
  format(string, sizeof(string), "%s's position: %f, %f, %f", name, x, y, z);
  SendClientMessage(playerid, YOURCOLOR, string);
  }
 }
 return 1;
}

Just wrote that fast so I don't know if I made any mistake, just try it and reply whether it worked or not

Re: Question - Scriptissue - 09.10.2010

[php]

PHP код:



wn(86) :  error 017: undefined symbol "dcmd"

C:\Documents and Settings\My Documents\Downloads\)\filterscripts\Tracefeature.pwn(246) : warning 203: symbol is never used: "dcmd_trace"

this is how I put the script:

pawn Код:

#pragma tabsize 0
public OnPlayerCommandText(playerid, cmdtext[])
{
    line 86: dcmd(trace, 5, cmdtext);
     return 1;

    }
    
    dcmd_trace(playerid, params[])
{
 if(!strlen(params)){
  SendClientMessage(playerid, YOURCOLOR, "/trace [id]");
  return 1;
 }
 new pid = strval(params);
 if(!IsPlayerConnected(pid)){
  SendClientMessage(playerid, YOURCOLOR, "Player is not connected");
  return 1;
 }else{
  new string[256], name[MAX_PLAYER_NAME], Float:x, Float:y, Float:z;
  GetPlayerName(pid, name, sizeof(name));
  GetPlayerPos(pid, x, y, z);
  format(string, sizeof(string), "%s's position: %f, %f, %f", name, x, y, z);
  SendClientMessage(playerid, YOURCOLOR, string);
  }
 }

this is who I defined the dcmd:

PHP код:



#define dcmd(%1,%2,%3) if ((strcmp((%3)[1], #%1, true, (%2)) == 0) && ((((%3)[(%2) + 1] == 0) && (dcmd_%1(playerid, "")))||(((%3)[(%2) + 1] == 32) && (dcmd_%1(playerid, (%3)[(%2) + 2]))))) return 1

Re: Question - Sascha - 09.10.2010

this should work actually... :

Код:

#define dcmd(%1,%2,%3) if ((strcmp((%3)[1], #%1, true, (%2)) == 0) && ((((%3)[(%2) + 1] == 0) && (dcmd_%1(playerid, "")))||(((%3)[(%2) + 1] == 32) && (dcmd_%1(playerid, (%3)[(%2) + 2]))))) return 1


public OnPlayerCommandText(playerid, cmdtext[])
{
	dcmd(trace, 5, cmdtext);
	return 0;
}

dcmd_trace(playerid, params[])
{
 if(!strlen(params)){
  SendClientMessage(playerid, YOURCOLOR, "/trace [id]");
  return 1;
 }
 new pid = strval(params);
 if(!IsPlayerConnected(pid)){
  SendClientMessage(playerid, YOURCOLOR, "Player is not connected");
  return 1;
 }else{
  new string[256], name[MAX_PLAYER_NAME], Float:x, Float:y, Float:z;
  GetPlayerName(pid, name, sizeof(name));
  GetPlayerPos(pid, x, y, z);
  format(string, sizeof(string), "%s's position: %f, %f, %f", name, x, y, z);
  SendClientMessage(playerid, YOURCOLOR, string);
  }
 }
 return 1;
}

Re: Question - Rachael - 09.10.2010

A string size of 256 is a bit of a waste of resources, as far as I can see it only needs to be 72, and if you use %.0f in the format you only need about 60.

I doubt the average player would be interested in knowing a players position to 5 decimal places.

Re: Question - Sascha - 09.10.2010

I just wrote this up... I didn't count for the length of the text...

Re: Question - Retardedwolf - 09.10.2010

Quote:

Originally Posted by Rachael

I doubt the average player would be interested in knowing a players position to 5 decimal places.

ikr, I recommend using floatround

Re: Question - Sascha - 09.10.2010

Quote:

Originally Posted by Retardedwolf

ikr, I recommend using floatround

indeed actually

.. haven't thought of this...

instead of:

Код:

format(string, sizeof(string), "%s's position: %f, %f, %f", name, x, y, z);

add:

Код:

floatround(x, floatround_round);
floatround(y, floatround_round);
floatround(z, floatround_round);
format(string, sizeof(string), "%s's positions: %.0f, %.0f, %.0f", name, x, y, z);

Re: Question - Scriptissue - 09.10.2010

It works, first of all I'm so thankful, second of all, when I trace someone, it prints the result as:
test's positions: 301, 412, 510.
Is there any way to change it into a name ? for example if the player is at the Grove street, the script will show that he is at Grove street.

Re: Question - Retardedwolf - 09.10.2010

Quote:

Originally Posted by Scriptissue

It works, first of all I'm so thankful, second of all, when I trace someone, it prints the result as:
test's positions: 301, 412, 510.
Is there any way to change it into a name ? for example if the player is at the Grove street, the script will show that he is at Grove street.

Use the zones include?