help me for command :(( - Printable Version

help me for command :(( - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Help Archive (https://sampforum.blast.hk/forumdisplay.php?fid=89)
+---- Thread: help me for command :(( (/showthread.php?tid=180948)

help me for command :(( - eXtr1kE - 03.10.2010

Код:

CMD:makeadmin(playerid, params[])
{
	new para1,level,string[256], giveplayer[MAX_PLAYER_NAME],sendername[MAX_PLAYER_NAME],idx;
	new tmp[256];
	if(IsPlayerConnected(playerid)) {
		if (sscanf(params, "us", para1, level)) { SendClientMessage(playerid, COLOR_GRAD2, "USAGE: /makeadmin [playerid/PartOfName] [level(1-3)]"); return 1; }
		para1 = ReturnUser(tmp);
		level = strval(tmp);
        tmp = strtok(params, idx);
		if (PlayerInfo[playerid][pAdmin] >= 1337) {
	        if(IsPlayerConnected(para1)) {
			    if(para1 != INVALID_PLAYER_ID) {
					GetPlayerName(para1, giveplayer, sizeof(giveplayer));
					GetPlayerName(playerid, sendername, sizeof(sendername));
					PlayerInfo[para1][pAdmin] = level;
					printf("AdmCmd: %s has promoted %s to a level %d admin.", sendername, giveplayer, level);
					format(string, sizeof(string), "   You have been promoted to a level %d admin by %s", level, sendername);
					SendClientMessage(para1, COLOR_LIGHTBLUE, string);
					format(string, sizeof(string), "   You have promoted %s to a level %d admin.", giveplayer,level);
					SendClientMessage(playerid, COLOR_LIGHTBLUE, string);
		        }
			}
		}
		else { SendClientMessage(playerid, COLOR_GRAD1, "   you are not authorized to use that command!"); }
	}
	return 1;
}

So, after writing /makeadmin extrike 1338 server crashes in a few seconds, I do not know what to do: |

Re: help me for command :(( - Memoryz - 03.10.2010

Instead of putting their name "extrike" try putting their ID?

Re: help me for command :(( - MadeMan - 03.10.2010

pawn Код:

CMD:makeadmin(playerid, params[])
{
    new para1,level,string[128], giveplayer[MAX_PLAYER_NAME],sendername[MAX_PLAYER_NAME];
    if(IsPlayerConnected(playerid)) {
        if (sscanf(params, "ui", para1, level)) { SendClientMessage(playerid, COLOR_GRAD2, "USAGE: /makeadmin [playerid/PartOfName] [level(1-3)]"); return 1; }
        if (PlayerInfo[playerid][pAdmin] >= 1337) {
            if(IsPlayerConnected(para1)) {
                if(para1 != INVALID_PLAYER_ID) {
                    GetPlayerName(para1, giveplayer, sizeof(giveplayer));
                    GetPlayerName(playerid, sendername, sizeof(sendername));
                    PlayerInfo[para1][pAdmin] = level;
                    printf("AdmCmd: %s has promoted %s to a level %d admin.", sendername, giveplayer, level);
                    format(string, sizeof(string), "   You have been promoted to a level %d admin by %s", level, sendername);
                    SendClientMessage(para1, COLOR_LIGHTBLUE, string);
                    format(string, sizeof(string), "   You have promoted %s to a level %d admin.", giveplayer,level);
                    SendClientMessage(playerid, COLOR_LIGHTBLUE, string);
                }
            }
        }
        else { SendClientMessage(playerid, COLOR_GRAD1, "   you are not authorized to use that command!"); }
    }
    return 1;
}

EDIT: sscanf should be "ui"

Re: help me for command :(( - Stefan_Toretto - 03.10.2010

Whats the difference?

Re: help me for command :(( - eXtr1kE - 03.10.2010

well ..
....

Re: help me for command :(( - mmrk - 03.10.2010

Remove those:

pawn Код:

para1 = ReturnUser(tmp);
level = strval(tmp);
tmp = strtok(params, idx);

Why you use string here?

pawn Код:

if (sscanf(params, "us", para1, level)) { SendClientMessage(playerid, COLOR_GRAD2, "USAGE: /makeadmin [playerid/PartOfName] [level(1-3)]"); return 1; }

Try this:

pawn Код:

if (sscanf(params, "ui", para1, level)) { SendClientMessage(playerid, COLOR_GRAD2, "USAGE: /makeadmin [playerid/PartOfName] [level(1-3)]"); return 1; }

Re: help me for command :(( - samgreen - 03.10.2010

pawn Код:

CMD:makeadmin(playerid, params[])
{
    if (PlayerInfo[playerid][pAdmin] >= 1337) {
        new para1,level;

        if (sscanf(params, "ud", para1, level)) { 
            SendClientMessage(playerid, COLOR_GRAD2, "USAGE: /makeadmin [playerid/PartOfName] [level(1-3)]"); 
            return 1; 
        }
    
        new string[128], giveplayer[MAX_PLAYER_NAME],sendername[MAX_PLAYER_NAME];
        GetPlayerName(para1, giveplayer, sizeof(giveplayer));
        GetPlayerName(playerid, sendername, sizeof(sendername));
        
        PlayerInfo[para1][pAdmin] = level;
        
        printf("AdmCmd: %s has promoted %s to a level %d admin.", sendername, giveplayer, level);
        
        format(string, sizeof(string), "   You have been promoted to a level %d admin by %s", level, sendername);
        SendClientMessage(para1, COLOR_LIGHTBLUE, string);
        
        format(string, sizeof(string), "   You have promoted %s to a level %d admin.", giveplayer,level);
        SendClientMessage(playerid, COLOR_LIGHTBLUE, string);
    } else { 
        SendClientMessage(playerid, COLOR_GRAD1, "   you are not authorized to use that command!"); 
    }
    
    return 1;
}

You had a ton of useless if statements in your code. Try and think logically when writing commands. If a player is sending a command, obviously they are connected. No need to check for things like that.

Re: help me for command :(( - Mike_Peterson - 03.10.2010

Quote:

Originally Posted by samgreen

You should check if the targetid is connected and return a message: This player is not connected.

Re: help me for command :(( - samgreen - 03.10.2010

Quote:

Originally Posted by Mike_Peterson

You should check if the targetid is connected and return a message: This player is not connected.

Unnecessary, sscanf already verifies the name / playerid.