Need help with Strcmp :S - Printable Version

Need help with Strcmp :S - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Scripting Help (https://sampforum.blast.hk/forumdisplay.php?fid=12)
+---- Forum: Help Archive (https://sampforum.blast.hk/forumdisplay.php?fid=89)
+---- Thread: Need help with Strcmp :S (/showthread.php?tid=157080)

Need help with Strcmp :S - [Nino] - 05.07.2010

I got a problem with strcmp..

My Code:

Код:

if(strcmp(GetName(playerid), dini_Get(string, "Owner"), true))
{
if(CarInfo[CarID][Engine] == 0)
{
//Start engine
CarInfo[CarID][Engine] = 1;//This should happen if the name of the player = the owner of the car.
TogglePlayerControllable(playerid, 1);//This should happen if the name of the player = the owner of the car.
}
}
else
{
SendClientMessage(playerid, Red, "You have no keys for this car.");//And this should happen if the name of the player is not the owner.
}

And now my problem: All players can start the engine. How can I fix it ? Only the carowner should be able to start the engine...

Re: Need help with Strcmp :S - woot - 05.07.2010

pawn Код:

if(!strcmp(GetName(playerid), dini_Get(string, "Owner"), true))
{
    ...
}

Re: Need help with Strcmp :S - DeathOnaStick - 05.07.2010

Quote:

Originally Posted by exora

pawn Код:

if(!strcmp(GetName(playerid), dini_Get(string, "Owner"), true))
{
    ...
}

Shouldn't it be like this:

pawn Код:

if(!strcmp(GetName(playerid)&&dini_Get(string, "Owner"), true)==1)
{
    ...
}

Correct me if im wrong.

Cheers.

AW: Need help with Strcmp :S - [Nino] - 05.07.2010

Quote:

Originally Posted by exora

pawn Код:

if(!strcmp(GetName(playerid), dini_Get(string, "Owner"), true))
{
    ...
}

dont work

now it always say: You have no keys for this car.

Quote:

Originally Posted by DeathOnaStick

Shouldn't it be like this:

pawn Код:

if(!strcmp(GetName(playerid)&&dini_Get(string, "Owner"), true)==1)
{
    ...
}

Correct me if im wrong.

Cheers.

dont work..

Re: Need help with Strcmp :S - dice7 - 05.07.2010

That is also correct, but I doubt it would compile (in theory it should). The only problem is that Strcmp can also return -1 (string2 is greater then string1 (it returns 1 on the opposite)), so it wouldn't work in all cases where the string wouldn't be the same.

pawn Код:

if(!strcmp(GetName(playerid), dini_Get(string, "Owner"), true))
{
    ...
}

Is the correct form for checking if the players name matches the owners one. Check if it saves in the file correctly

Re: Need help with Strcmp :S - -Sneaky- - 05.07.2010

Код:

if(!strcmp(GetName(playerid), dini_Get(string, "Owner"), true))
{
    if(CarInfo[CarID][Engine] == 0)
    {
        //Start engine
        CarInfo[CarID][Engine] = 1;//This should happen if the name of the player = the owner of the car.
        TogglePlayerControllable(playerid, 1);//This should happen if the name of the player = the owner of the car.
    }
}
else
{
    SendClientMessage(playerid, Red, "You have no keys for this car.");//And this should happen if the name of the  player is not the owner.
}

This should work.

AW: Need help with Strcmp :S - [Nino] - 05.07.2010

still dont work ..
and yes its saves in the file correct..
maybe its some other problem with the code.. here is my whole code for this function:

Код:

public OnPlayerKeyStateChange(playerid, newkeys, oldkeys)
{
if(newkeys == KEY_WALK)
	{
	if(IsPlayerInAnyVehicle(playerid))
	{
	if(GetPlayerVehicleSeat(playerid) == 0)
	{
	new CarID = GetPlayerVehicleID(playerid);
	new string[100];
	format(string, sizeof(string),"/Cars/Car(%d).Cfg", CarID);
	if(!strcmp(GetName(playerid), dini_Get(string, "Owner"), true))
	{
	if(CarInfo[CarID][Engine] == 0)
	{
	CarInfo[CarID][Engine] = 1;
	TogglePlayerControllable(playerid, 1);
	}
	}
	else
	{
	SendClientMessage(playerid, Red, "You have no keys for this car.");
	}
	}
	}
	return 1;
	}
return 1;
}

btw: getname function:

stock GetName(playerid)
{
new PlayerName[MAX_PLAYER_NAME];
GetPlayerName(playerid, PlayerName, sizeof(PlayerName));
return PlayerName;
}

Re: Need help with Strcmp :S - dice7 - 05.07.2010

pawn Код:

printf("%s", GetName(playerid));
                printf("%s", dini_Get(string, "Owner"));
                if(!strcmp(GetName(playerid), dini_Get(string, "Owner"), true))
                {
                    if(CarInfo[CarID][Engine] == 0)
                    {
                        CarInfo[CarID][Engine] = 1;
                        TogglePlayerControllable(playerid, 1);
                    }
                }
                else
                {
                    SendClientMessage(playerid, Red, "You have no keys for this car.");
                }

Try this to see if the printed names match. Because if they do, then I have no idea why strcmp fails

AW: Need help with Strcmp :S - [Nino] - 05.07.2010

lol -.-

[19:35:35] PlayerName: [Nino]
[19:35:35] CarOwner: [Nino]

Re: Need help with Strcmp :S - -Sneaky- - 05.07.2010

Are you sure CarInfo[CarID][Engine] is 0?