[Plugin] [REL] MySQL Plugin (Now on github!)

[Plugin] [REL] MySQL Plugin (Now on github!) - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Plugin Development (https://sampforum.blast.hk/forumdisplay.php?fid=18)
+--- Thread: [Plugin] [REL] MySQL Plugin (Now on github!) (/showthread.php?tid=56564)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128

AW: Re: [REL] MySQL Plugin (****** Project) - maddinat0r - 01.09.2013

Quote:

Originally Posted by KyleSmith

Is it possible to speed up mysql_real_escape_string?

It takes 193ms for me for about 600 length string.

I'm using R30.

It's not so easy to improve the escaping speed, but I'll see what I can do.

Quote:

Originally Posted by AndreT

I think I see a potential problem with the code in CScripting.cpp.

The memory allocated for the output of the C mysql_real_escape_string must be (2*strlen(input))+1. Assuming that you usually know what you're doing, when you write PAWN code, you do this:

pawn Код:

new src[32];
new dest[64];
mysql_real_escape_string(src, dest); // max_len=sizeof(destination) by default

What the plugin native then does is:

pawn Код:

size_t DestLen = (params[4] <= 0 ? 8192 : params[4]); // DestLen becmes 64 (in our case at least)
// ...
char *StrBuffer = (char *)malloc(DestLen*2+1); // Allocates 64*2+1=129 bytes of memory
memset(StrBuffer, 0, DestLen*2 + 1); // Set it all to zeros (?)
cell StringLen = (cell)mysql_real_escape_string(ConnPtr, StrBuffer, Source, strlen(Source));
StrAmx::SetCString(amx, params[2], StrBuffer, params[4]);
free(StrBuffer);

Also, I think that memset needn't be used here - the C mysql_real_escape_string appends a NULL byte by itself. To allocate 64+1 bytes of memory (aka. what we need here to be on the safe side), it needs to make use of the SourceLen variable (cannot exceed 32 in our example) and double it and add 1 byte for the NULL.

I assume this is not going to make a relevant speed difference, and perhaps the AMX interactions with large arrays is just slow, but using heap allocation (alloca instead of malloc) is a possibility here as well. Once again may not make a relevant speed difference, and may even be dangerous (if you start allocating megabytes!)

Looks like I already saw that problem while developing R33, the current code is already using the length of the source string.
Yes, it looks like the library's mysql_real_escape_string appends a NULL-byte, didn't saw that. This indeed saves me the use of memset, thanks for pointing that out.

Quote:

Originally Posted by AndreT

I assume this is not going to make a relevant speed difference, and perhaps the AMX interactions with large arrays is just slow, but using heap allocation (alloca instead of malloc) is a possibility here as well.

I think you meant stack allocation instead of heap. Using stack allocation instead of heap decreases performance by ~6.29%.

Quote:

Originally Posted by Misiur

Hi guys, last time (R8 ) there were some issues with mysql_format and linux - is this fixed now?

I completely rewrote mysql_format in R28 and tested it on Linux, I doubt that there are any problems now.

Re: [REL] MySQL Plugin (****** Project) - WopsS - 06.09.2013

Thanks BlueG and Pain123

Re: [REL] MySQL Plugin (****** Project) - maddinat0r - 07.09.2013

Quote:

Originally Posted by Lorenc_

Also, I am not sure if anyone else asked but have you tried running the SQL plugin on a single core? I think it crashes

One of my beta testers has a pretty old one-core CPU and experienced crashes since R21. Well, he didn't got any crashes while using R33 though.

Re: [REL] MySQL Plugin (****** Project) - IstuntmanI - 07.09.2013

Quote:

Originally Posted by Pain123

One of my beta testers has a pretty old one-core CPU and experienced crashes since R21. Well, he didn't got any crashes while using R33 though.

I guess you're talking about me, haha.

Yes, it was fixed in R33.

Re: [REL] MySQL Plugin (****** Project) - Kyle - 07.09.2013

How long left for R33! I really want it for the few non threaded queries I need! xD

Re: [REL] MySQL Plugin (****** Project) - Tomer!.$ - 08.09.2013

Question!
Is there a way to query two strings?

Re: [REL] MySQL Plugin (****** Project) - B-Matt - 08.09.2013

Quote:

Originally Posted by Tomer!.$

Question!
Is there a way to query two strings?

What you think?

AW: [REL] MySQL Plugin (****** Project) - maddinat0r - 08.09.2013

R33 is released (finally).
Changes:
- added ORM system
- improved Windows XP compatibility (proven to work now)
- added parameter values to debug native log messages
- improved y_inline compatiblity code
- "orm_select" and "orm_insert" support y_inline (use "orm_select_inline" and "orm_insert_inline")
- added Cache-tags to cache_set_active, cache_save and cache_delete
- added natives "cache_get_row_count" and "cache_get_field_count"
- added more safety checks
- speed improvements
- fixed bug where mysql_free_result wasn't called internally if callback processing was skipped
- improved thread safety
- improved HTML-logging, reduced file size
- code cleanup
- rewrote the whole (multi-)threading system, multi-threading works now only per-connection (every connection has their own thread)
- added native "mysql_query" for unthreaded queries
- native "mysql_reconnect" no longer returns true if connection was successful and false if not, use "mysql_errno" instead
- improved makefile, use "make" to create a dynamic and static version, "make dynamic" and "make static" are self-explaining

A tutorial for the new ORM system is available here (thanks to AndreT for this): https://sampforum.blast.hk/showthread.php?tid=461766
Thanks to the beta testers who participated in the whole testing process. And also thanks to everyone who encouraged me to this release.

Re: [REL] MySQL Plugin (****** Project) - -Prodigy- - 08.09.2013

Very nice work.

Re: [REL] MySQL Plugin (****** Project) - Luis- - 08.09.2013

Brilliant I shall be updating tomorrow.

Re: [REL] MySQL Plugin (****** Project) - Kyle - 08.09.2013

Well done on all the hard work.

Re: [REL] MySQL Plugin (****** Project) - Scenario - 09.09.2013

Too bad I didn't get to test any of R33 for you. I've been super busy with my new job and stuff.

Looking forward to see what's in store for the next feature-set!

Re: AW: [REL] MySQL Plugin (****** Project) - IstuntmanI - 09.09.2013

Quote:

Originally Posted by Pain123

R33 is released (finally).
Changes:
- added ORM system
- improved Windows XP compatibility (proven to work now)
- added parameter values to debug native log messages
- improved y_inline compatiblity code
- "orm_select" and "orm_insert" support y_inline (use "orm_select_inline" and "orm_insert_inline")
- added Cache-tags to cache_set_active, cache_save and cache_delete
- added natives "cache_get_row_count" and "cache_get_field_count"
- added more safety checks
- speed improvements
- fixed bug where mysql_free_result wasn't called internally if callback processing was skipped
- improved thread safety
- improved HTML-logging, reduced file size
- code cleanup
- rewrote the whole (multi-)threading system, multi-threading works now only per-connection (every connection has their own thread)
- added native "mysql_query" for unthreaded queries
- native "mysql_reconnect" no longer returns true if connection was successful and false if not, use "mysql_errno" instead
- improved makefile, use "make" to create a dynamic and static version, "make dynamic" and "make static" are self-explaining

A tutorial for the new ORM system is available here (thanks to AndreT for this): https://sampforum.blast.hk/showthread.php?tid=461766
Thanks to the beta testers who participated in the whole testing process. And also thanks to everyone who encouraged me to this release.

Awesome ! =X

Re: [REL] MySQL Plugin (****** Project) - maddinat0r - 09.09.2013

Quote:

Originally Posted by -Prodigy-

Very nice work.

Quote:

Originally Posted by Luis-

Brilliant I shall be updating tomorrow.

Quote:

Originally Posted by KyleSmith

Well done on all the hard work.

Quote:

Originally Posted by IstuntmanI

Awesome ! =X

Thank you

Quote:

Originally Posted by RealCop228

Too bad I didn't get to test any of R33 for you. I've been super busy with my new job and stuff.

Looking forward to see what's in store for the next feature-set!

No problem, the real life goes first.
Hm, I don't have any planned features yet. If someone has any suggestions, feel free to share them with me/us!

Re: [REL] MySQL Plugin (****** Project) - iJumbo - 09.09.2013

Testing ...

awesome ∞+rep

AW: [REL] MySQL Plugin (****** Project) - ThomasTailor93 - 09.09.2013

What's the difference between plugin for MySQL 5.1 and 5.5?

Re: AW: [REL] MySQL Plugin (****** Project) - maddinat0r - 09.09.2013

Quote:

Originally Posted by ThomasTailor93

What's the difference between plugin for MySQL 5.1 and 5.5?

Some Linux distributions only provide packages for a specific version of the MySQL server. For example, Debian 6 (Squeeze) installs MySQL server v5.1 if you run "apt-get install mysql-server", but Debian 7 install MySQL server v5.5 if you run the same command. The shared (dynamic) version of the plugin can't be compatible to both versions, that's why there is one plugin for each MySQL server version.

Re: AW: [REL] MySQL Plugin (****** Project) - [IZ]Kira - 09.09.2013

Quote:

Originally Posted by Pain123

'Finally ! <3 great job man ! X:

Re: [REL] MySQL Plugin (****** Project) - Falcon. - 09.09.2013

testing R33...
So far, no problem found.

thanks for the update, and continue with your good work !!

Re: [REL] MySQL Plugin (****** Project) - Luis- - 09.09.2013

I've always used versions of BlueG's plugin, one was an edited version by AndreT. I have never had issues with it. It's a great plugin.