[FilterScript] Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer )

[FilterScript] Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Printable Version

+- SA-MP Forums Archive (https://sampforum.blast.hk)
+-- Forum: SA-MP Scripting and Plugins (https://sampforum.blast.hk/forumdisplay.php?fid=8)
+--- Forum: Filterscripts (https://sampforum.blast.hk/forumdisplay.php?fid=17)
+--- Thread: [FilterScript] Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) (/showthread.php?tid=630780)

Pages: 1 2

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - AndySedeyn - 20.03.2017

I like how you put excessive whitespaces everywhere and then cram everything together elsewhere:

PHP код:



for( new j=0;j<6;j++ )

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Logic_ - 20.03.2017

Some errors:
1. You're mixing indentation styles.

2. This can be shortened:

PHP код:



JOB_DELIVERER_VEHICLES[ DELIVERER_VEHICLES[ 0 ] ] = 0; JOB_DELIVERER_VEHICLES[ DELIVERER_VEHICLES[ 1 ] ]= 0;

    JOB_DELIVERER_VEHICLES[ DELIVERER_VEHICLES[ 2 ] ] = 0; JOB_DELIVERER_VEHICLES[ DELIVERER_VEHICLES[ 3 ] ]= 0;

    JOB_DELIVERER_VEHICLES[ DELIVERER_VEHICLES[ 4 ] ] = 0; JOB_DELIVERER_VEHICLES[ DELIVERER_VEHICLES[ 5 ] ]= 0;

3. Your commands has a very different style, which can be shortened.

4. Remove , params[]) if params aren't used in the commands.

5. Why you're using public keyword and forwarding them if they are used like ordinary functions?

6. Optimize this

PHP код:



if(VID == DELIVERER_VEHICLES[ 0 ] || VID == DELIVERER_VEHICLES[ 1 ] || VID == DELIVERER_VEHICLES[ 2 ] || VID == DELIVERER_VEHICLES[ 3 ] || VID == DELIVERER_VEHICLES[ 4 ] || VID == DELIVERER_VEHICLES[ 5 ])

7. Shorten if statements by combining them into one or so.

8. Use Streamer functions instead of using ordinary checkpoints or pick-ups, use dynamic areas and stuff.

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Bolex_ - 20.03.2017

Quote:

Originally Posted by AndySedeyn

I like how you put excessive whitespaces everywhere and then cram everything together elsewhere:

PHP код:



for( new j=0;j<6;j++ )

Going to solve this all soon as i re-install my windows

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Hunud - 20.03.2017

Will wait for fix. Keep good work

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Bolex_ - 20.03.2017

Tnx

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Hunud - 21.03.2017

I make new map and there is remove object but where i put it?

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Bolex_ - 21.03.2017

Quote:

Originally Posted by Hunud

I make new map and there is remove object but where i put it?

New objects replace inside OnFilterScriptInit() and RemoveBuildingForPlayer inside OnPlayerConnect()

OT: *Some changes are made in script!*

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Bolex_ - 23.03.2017

Thanks

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Hunud - 26.03.2017

Quote:

Originally Posted by Scripter18

New objects replace inside OnFilterScriptInit() and RemoveBuildingForPlayer inside OnPlayerConnect()

OT: *Some changes are made in script!*

Thanks

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - LittleSpy - 30.03.2017

Good Job

Re: Fuel Deliverer Job v1.5 | ( foreach, izcmd, streamer ) - Bolex_ - 06.04.2017

Quote:

Originally Posted by Inceptio

Perfecto FS.

I'm glad you like it